public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Sasha Levin <sashal@kernel.org>
To: linux-kernel@vger.kernel.org, stable@vger.kernel.org
Cc: Boris Burkov <boris@bur.io>, Qu Wenruo <wqu@suse.com>,
	David Sterba <dsterba@suse.com>, Sasha Levin <sashal@kernel.org>,
	clm@fb.com, josef@toxicpanda.com, linux-btrfs@vger.kernel.org
Subject: [PATCH AUTOSEL 6.1 04/19] btrfs: make btrfs_clear_delalloc_extent() free delalloc reserve
Date: Mon, 22 Apr 2024 19:18:18 -0400	[thread overview]
Message-ID: <20240422231845.1607921-4-sashal@kernel.org> (raw)
In-Reply-To: <20240422231845.1607921-1-sashal@kernel.org>

From: Boris Burkov <boris@bur.io>

[ Upstream commit 3c6f0c5ecc8910d4ffb0dfe85609ebc0c91c8f34 ]

Currently, this call site in btrfs_clear_delalloc_extent() only converts
the reservation. We are marking it not delalloc, so I don't think it
makes sense to keep the rsv around.  This is a path where we are not
sure to join a transaction, so it leads to incorrect free-ing during
umount.

Helps with the pass rate of generic/269 and generic/475.

Reviewed-by: Qu Wenruo <wqu@suse.com>
Signed-off-by: Boris Burkov <boris@bur.io>
Signed-off-by: David Sterba <dsterba@suse.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>
---
 fs/btrfs/inode.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/fs/btrfs/inode.c b/fs/btrfs/inode.c
index f7f4bcc094642..10ded9c2be03b 100644
--- a/fs/btrfs/inode.c
+++ b/fs/btrfs/inode.c
@@ -2472,7 +2472,7 @@ void btrfs_clear_delalloc_extent(struct inode *vfs_inode,
 		 */
 		if (bits & EXTENT_CLEAR_META_RESV &&
 		    root != fs_info->tree_root)
-			btrfs_delalloc_release_metadata(inode, len, false);
+			btrfs_delalloc_release_metadata(inode, len, true);
 
 		/* For sanity tests. */
 		if (btrfs_is_testing(fs_info))
-- 
2.43.0


  parent reply	other threads:[~2024-04-22 23:57 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-04-22 23:18 [PATCH AUTOSEL 6.1 01/19] tools/power turbostat: Fix added raw MSR output Sasha Levin
2024-04-22 23:18 ` [PATCH AUTOSEL 6.1 02/19] tools/power turbostat: Increase the limit for fd opened Sasha Levin
2024-04-22 23:18 ` [PATCH AUTOSEL 6.1 03/19] tools/power turbostat: Fix Bzy_MHz documentation typo Sasha Levin
2024-04-22 23:18 ` Sasha Levin [this message]
2024-04-22 23:18 ` [PATCH AUTOSEL 6.1 05/19] btrfs: always clear PERTRANS metadata during commit Sasha Levin
2024-04-22 23:18 ` [PATCH AUTOSEL 6.1 06/19] memblock tests: fix undefined reference to `early_pfn_to_nid' Sasha Levin
2024-04-22 23:18 ` [PATCH AUTOSEL 6.1 07/19] memblock tests: fix undefined reference to `panic' Sasha Levin
2024-04-22 23:18 ` [PATCH AUTOSEL 6.1 08/19] memblock tests: fix undefined reference to `BIT' Sasha Levin
2024-04-22 23:18 ` [PATCH AUTOSEL 6.1 09/19] scsi: target: Fix SELinux error when systemd-modules loads the target module Sasha Levin
2024-04-22 23:18 ` [PATCH AUTOSEL 6.1 10/19] blk-iocost: avoid out of bounds shift Sasha Levin
2024-04-22 23:18 ` [PATCH AUTOSEL 6.1 11/19] gpu: host1x: Do not setup DMA for virtual devices Sasha Levin
2024-04-22 23:18 ` [PATCH AUTOSEL 6.1 12/19] MIPS: scall: Save thread_info.syscall unconditionally on entry Sasha Levin
2024-04-22 23:18 ` [PATCH AUTOSEL 6.1 13/19] tools/power/turbostat: Fix uncore frequency file string Sasha Levin
2024-04-22 23:18 ` [PATCH AUTOSEL 6.1 14/19] drm/amdgpu: Refine IB schedule error logging Sasha Levin
2024-04-22 23:18 ` [PATCH AUTOSEL 6.1 15/19] selftests: timers: Fix valid-adjtimex signed left-shift undefined behavior Sasha Levin
2024-04-22 23:18 ` [PATCH AUTOSEL 6.1 16/19] Drivers: hv: vmbus: Track decrypted status in vmbus_gpadl Sasha Levin
2024-04-22 23:18 ` [PATCH AUTOSEL 6.1 17/19] uio_hv_generic: Don't free decrypted memory Sasha Levin
2024-04-22 23:18 ` [PATCH AUTOSEL 6.1 18/19] Drivers: hv: vmbus: Don't free ring buffers that couldn't be re-encrypted Sasha Levin
2024-04-22 23:18 ` [PATCH AUTOSEL 6.1 19/19] iommu: mtk: fix module autoloading Sasha Levin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240422231845.1607921-4-sashal@kernel.org \
    --to=sashal@kernel.org \
    --cc=boris@bur.io \
    --cc=clm@fb.com \
    --cc=dsterba@suse.com \
    --cc=josef@toxicpanda.com \
    --cc=linux-btrfs@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=stable@vger.kernel.org \
    --cc=wqu@suse.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox