* [PATCH] clocksource: Make the int help prompt unit readable in ncurses
@ 2024-04-28 10:21 Borislav Petkov
2024-04-28 15:39 ` Randy Dunlap
` (2 more replies)
0 siblings, 3 replies; 6+ messages in thread
From: Borislav Petkov @ 2024-04-28 10:21 UTC (permalink / raw)
To: Thomas Gleixner
Cc: X86 ML, LKML, Borislav Petkov (AMD), Paul E . McKenney,
Waiman Long
From: "Borislav Petkov (AMD)" <bp@alien8.de>
When doing
make menuconfig
and searching for the CLOCKSOURCE_WATCHDOG_MAX_SKEW_US config item, the
help says:
│ Symbol: CLOCKSOURCE_WATCHDOG_MAX_SKEW_US [=125]
│ Type : integer
│ Range : [50 1000]
│ Defined at kernel/time/Kconfig:204
│ Prompt: Clocksource watchdog maximum allowable skew (in s)
^^^^^
│ Depends on: GENERIC_CLOCKEVENTS [=y] && CLOCKSOURCE_WATCHDOG [=y]
because on some terminals, it cannot display the 'μ' char, unicode
number 0x3bc.
So simply write it out so that there's no trouble.
Signed-off-by: Borislav Petkov (AMD) <bp@alien8.de>
Cc: Paul E. McKenney <paulmck@kernel.org>
Cc: Waiman Long <longman@redhat.com>
---
kernel/time/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/kernel/time/Kconfig b/kernel/time/Kconfig
index fc3b1a06c981..8ebb6d5a106b 100644
--- a/kernel/time/Kconfig
+++ b/kernel/time/Kconfig
@@ -202,7 +202,7 @@ config HIGH_RES_TIMERS
the size of the kernel image.
config CLOCKSOURCE_WATCHDOG_MAX_SKEW_US
- int "Clocksource watchdog maximum allowable skew (in μs)"
+ int "Clocksource watchdog maximum allowable skew (in microseconds)"
depends on CLOCKSOURCE_WATCHDOG
range 50 1000
default 125
--
2.43.0
^ permalink raw reply related [flat|nested] 6+ messages in thread* Re: [PATCH] clocksource: Make the int help prompt unit readable in ncurses
2024-04-28 10:21 [PATCH] clocksource: Make the int help prompt unit readable in ncurses Borislav Petkov
@ 2024-04-28 15:39 ` Randy Dunlap
2024-04-29 16:04 ` Paul E. McKenney
2024-04-29 22:19 ` [tip: timers/core] " tip-bot2 for Borislav Petkov (AMD)
2 siblings, 0 replies; 6+ messages in thread
From: Randy Dunlap @ 2024-04-28 15:39 UTC (permalink / raw)
To: Borislav Petkov, Thomas Gleixner
Cc: X86 ML, LKML, Borislav Petkov (AMD), Paul E . McKenney,
Waiman Long
On 4/28/24 3:21 AM, Borislav Petkov wrote:
> From: "Borislav Petkov (AMD)" <bp@alien8.de>
>
> When doing
>
> make menuconfig
>
> and searching for the CLOCKSOURCE_WATCHDOG_MAX_SKEW_US config item, the
> help says:
>
> │ Symbol: CLOCKSOURCE_WATCHDOG_MAX_SKEW_US [=125]
> │ Type : integer
> │ Range : [50 1000]
> │ Defined at kernel/time/Kconfig:204
> │ Prompt: Clocksource watchdog maximum allowable skew (in s)
> ^^^^^
>
> │ Depends on: GENERIC_CLOCKEVENTS [=y] && CLOCKSOURCE_WATCHDOG [=y]
>
> because on some terminals, it cannot display the 'μ' char, unicode
> number 0x3bc.
>
> So simply write it out so that there's no trouble.
>
> Signed-off-by: Borislav Petkov (AMD) <bp@alien8.de>
> Cc: Paul E. McKenney <paulmck@kernel.org>
> Cc: Waiman Long <longman@redhat.com>
Acked-by: Randy Dunlap <rdunlap@infradead.org>
Thanks.
> ---
> kernel/time/Kconfig | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/kernel/time/Kconfig b/kernel/time/Kconfig
> index fc3b1a06c981..8ebb6d5a106b 100644
> --- a/kernel/time/Kconfig
> +++ b/kernel/time/Kconfig
> @@ -202,7 +202,7 @@ config HIGH_RES_TIMERS
> the size of the kernel image.
>
> config CLOCKSOURCE_WATCHDOG_MAX_SKEW_US
> - int "Clocksource watchdog maximum allowable skew (in μs)"
> + int "Clocksource watchdog maximum allowable skew (in microseconds)"
> depends on CLOCKSOURCE_WATCHDOG
> range 50 1000
> default 125
--
#Randy
https://people.kernel.org/tglx/notes-about-netiquette
https://subspace.kernel.org/etiquette.html
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] clocksource: Make the int help prompt unit readable in ncurses
2024-04-28 10:21 [PATCH] clocksource: Make the int help prompt unit readable in ncurses Borislav Petkov
2024-04-28 15:39 ` Randy Dunlap
@ 2024-04-29 16:04 ` Paul E. McKenney
2024-04-29 22:29 ` Borislav Petkov
2024-04-29 22:19 ` [tip: timers/core] " tip-bot2 for Borislav Petkov (AMD)
2 siblings, 1 reply; 6+ messages in thread
From: Paul E. McKenney @ 2024-04-29 16:04 UTC (permalink / raw)
To: Borislav Petkov
Cc: Thomas Gleixner, X86 ML, LKML, Borislav Petkov (AMD), Waiman Long
On Sun, Apr 28, 2024 at 12:21:43PM +0200, Borislav Petkov wrote:
> From: "Borislav Petkov (AMD)" <bp@alien8.de>
>
> When doing
>
> make menuconfig
>
> and searching for the CLOCKSOURCE_WATCHDOG_MAX_SKEW_US config item, the
> help says:
>
> │ Symbol: CLOCKSOURCE_WATCHDOG_MAX_SKEW_US [=125]
> │ Type : integer
> │ Range : [50 1000]
> │ Defined at kernel/time/Kconfig:204
> │ Prompt: Clocksource watchdog maximum allowable skew (in s)
> ^^^^^
>
> │ Depends on: GENERIC_CLOCKEVENTS [=y] && CLOCKSOURCE_WATCHDOG [=y]
>
> because on some terminals, it cannot display the 'μ' char, unicode
> number 0x3bc.
>
> So simply write it out so that there's no trouble.
>
> Signed-off-by: Borislav Petkov (AMD) <bp@alien8.de>
> Cc: Paul E. McKenney <paulmck@kernel.org>
> Cc: Waiman Long <longman@redhat.com>
So all the world is not yet a UTF-8? ;-)
Acked-by: Paul E. McKenney <paulmck@kernel.org>
> ---
> kernel/time/Kconfig | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/kernel/time/Kconfig b/kernel/time/Kconfig
> index fc3b1a06c981..8ebb6d5a106b 100644
> --- a/kernel/time/Kconfig
> +++ b/kernel/time/Kconfig
> @@ -202,7 +202,7 @@ config HIGH_RES_TIMERS
> the size of the kernel image.
>
> config CLOCKSOURCE_WATCHDOG_MAX_SKEW_US
> - int "Clocksource watchdog maximum allowable skew (in μs)"
> + int "Clocksource watchdog maximum allowable skew (in microseconds)"
> depends on CLOCKSOURCE_WATCHDOG
> range 50 1000
> default 125
> --
> 2.43.0
>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] clocksource: Make the int help prompt unit readable in ncurses
2024-04-29 16:04 ` Paul E. McKenney
@ 2024-04-29 22:29 ` Borislav Petkov
2024-04-29 22:54 ` Paul E. McKenney
0 siblings, 1 reply; 6+ messages in thread
From: Borislav Petkov @ 2024-04-29 22:29 UTC (permalink / raw)
To: Paul E. McKenney
Cc: Borislav Petkov, Thomas Gleixner, X86 ML, LKML, Waiman Long
On Mon, Apr 29, 2024 at 09:04:30AM -0700, Paul E. McKenney wrote:
> So all the world is not yet a UTF-8? ;-)
... and it's not like I'm not trying. I have a fairly new debian
testing, xterm v390 and libncurses5 v6.3 but nope, no joy.
I betcha it is some stupid conversion thing.
--
Regards/Gruss,
Boris.
https://people.kernel.org/tglx/notes-about-netiquette
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH] clocksource: Make the int help prompt unit readable in ncurses
2024-04-29 22:29 ` Borislav Petkov
@ 2024-04-29 22:54 ` Paul E. McKenney
0 siblings, 0 replies; 6+ messages in thread
From: Paul E. McKenney @ 2024-04-29 22:54 UTC (permalink / raw)
To: Borislav Petkov
Cc: Borislav Petkov, Thomas Gleixner, X86 ML, LKML, Waiman Long
On Tue, Apr 30, 2024 at 12:29:02AM +0200, Borislav Petkov wrote:
> On Mon, Apr 29, 2024 at 09:04:30AM -0700, Paul E. McKenney wrote:
> > So all the world is not yet a UTF-8? ;-)
>
> ... and it's not like I'm not trying. I have a fairly new debian
> testing, xterm v390 and libncurses5 v6.3 but nope, no joy.
>
> I betcha it is some stupid conversion thing.
Worse things could happen! ;-)
Thanx, Paul
^ permalink raw reply [flat|nested] 6+ messages in thread
* [tip: timers/core] clocksource: Make the int help prompt unit readable in ncurses
2024-04-28 10:21 [PATCH] clocksource: Make the int help prompt unit readable in ncurses Borislav Petkov
2024-04-28 15:39 ` Randy Dunlap
2024-04-29 16:04 ` Paul E. McKenney
@ 2024-04-29 22:19 ` tip-bot2 for Borislav Petkov (AMD)
2 siblings, 0 replies; 6+ messages in thread
From: tip-bot2 for Borislav Petkov (AMD) @ 2024-04-29 22:19 UTC (permalink / raw)
To: linux-tip-commits
Cc: Borislav Petkov (AMD), Thomas Gleixner, Paul E. McKenney,
Randy Dunlap, x86, linux-kernel
The following commit has been merged into the timers/core branch of tip:
Commit-ID: 54db412e618e9c43e5167f809a901f554e8c43e2
Gitweb: https://git.kernel.org/tip/54db412e618e9c43e5167f809a901f554e8c43e2
Author: Borislav Petkov (AMD) <bp@alien8.de>
AuthorDate: Sun, 28 Apr 2024 12:21:43 +02:00
Committer: Thomas Gleixner <tglx@linutronix.de>
CommitterDate: Tue, 30 Apr 2024 00:12:22 +02:00
clocksource: Make the int help prompt unit readable in ncurses
When doing
make menuconfig
and searching for the CLOCKSOURCE_WATCHDOG_MAX_SKEW_US config item, the
help says:
│ Symbol: CLOCKSOURCE_WATCHDOG_MAX_SKEW_US [=125]
│ Type : integer
│ Range : [50 1000]
│ Defined at kernel/time/Kconfig:204
│ Prompt: Clocksource watchdog maximum allowable skew (in s)
^^^
│ Depends on: GENERIC_CLOCKEVENTS [=y] && CLOCKSOURCE_WATCHDOG [=y]
because on some terminals, it cannot display the 'μ' char, unicode
number 0x3bc.
So simply write it out so that there's no trouble.
Signed-off-by: Borislav Petkov (AMD) <bp@alien8.de>
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
Acked-by: Paul E. McKenney <paulmck@kernel.org>
Acked-by: Randy Dunlap <rdunlap@infradead.org>
Link: https://lore.kernel.org/r/20240428102143.26764-1-bp@kernel.org
---
kernel/time/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/kernel/time/Kconfig b/kernel/time/Kconfig
index fc3b1a0..8ebb6d5 100644
--- a/kernel/time/Kconfig
+++ b/kernel/time/Kconfig
@@ -202,7 +202,7 @@ config HIGH_RES_TIMERS
the size of the kernel image.
config CLOCKSOURCE_WATCHDOG_MAX_SKEW_US
- int "Clocksource watchdog maximum allowable skew (in μs)"
+ int "Clocksource watchdog maximum allowable skew (in microseconds)"
depends on CLOCKSOURCE_WATCHDOG
range 50 1000
default 125
^ permalink raw reply related [flat|nested] 6+ messages in thread
end of thread, other threads:[~2024-04-29 22:54 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-04-28 10:21 [PATCH] clocksource: Make the int help prompt unit readable in ncurses Borislav Petkov
2024-04-28 15:39 ` Randy Dunlap
2024-04-29 16:04 ` Paul E. McKenney
2024-04-29 22:29 ` Borislav Petkov
2024-04-29 22:54 ` Paul E. McKenney
2024-04-29 22:19 ` [tip: timers/core] " tip-bot2 for Borislav Petkov (AMD)
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox