From: Greg KH <gregkh@linuxfoundation.org>
To: Shahar Avidar <ikobh7@gmail.com>
Cc: hverkuil-cisco@xs4all.nl, andriy.shevchenko@linux.intel.com,
robh@kernel.org, felixkimbu1@gmail.com, dan.carpenter@linaro.org,
krzysztof.kozlowski@linaro.org, linux-staging@lists.linux.dev,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] staging: pi433: Use class_create instead of class_register.
Date: Wed, 1 May 2024 16:12:48 +0200 [thread overview]
Message-ID: <2024050109-reward-vision-58e9@gregkh> (raw)
In-Reply-To: <20240501055820.603272-2-ikobh7@gmail.com>
On Wed, May 01, 2024 at 08:58:19AM +0300, Shahar Avidar wrote:
> Make use of a higher level API.
What does this mean?
> Reduce global memory allocation from struct class to pointer size.
No, you increased memory allocation here, why do you think you reduced
it?
Also, this looks like a revert of commit f267da65bb6b ("staging: pi433:
make pi433_class constant"), accepted a few months ago, why not just
call it out as an explicit revert if that's what you want to do?
class_create is going away "soon", why add this back when people are
working so hard to remove its usage? What tutorial did you read that
made you want to make this change?
thanks,
greg k-h
next prev parent reply other threads:[~2024-05-01 14:12 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-01 5:58 [PATCH 0/2] staging: pi433: Use class_create API Shahar Avidar
2024-05-01 5:58 ` [PATCH 1/2] staging: pi433: Use class_create instead of class_register Shahar Avidar
2024-05-01 14:00 ` Dan Carpenter
2024-05-01 14:14 ` Greg KH
2024-05-02 8:51 ` Shahar Avidar
2024-05-01 14:12 ` Greg KH [this message]
2024-05-02 8:40 ` Shahar Avidar
2024-05-02 8:54 ` Greg KH
2024-05-01 5:58 ` [PATCH 2/2] staging: pi433: Rename goto label Shahar Avidar
2024-05-01 14:06 ` Dan Carpenter
2024-05-02 8:44 ` Shahar Avidar
2024-05-02 8:59 ` Dan Carpenter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2024050109-reward-vision-58e9@gregkh \
--to=gregkh@linuxfoundation.org \
--cc=andriy.shevchenko@linux.intel.com \
--cc=dan.carpenter@linaro.org \
--cc=felixkimbu1@gmail.com \
--cc=hverkuil-cisco@xs4all.nl \
--cc=ikobh7@gmail.com \
--cc=krzysztof.kozlowski@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox