From: Lee Jones <lee@kernel.org>
To: Markus Elfring <Markus.Elfring@web.de>
Cc: wangkaiyuan@inspur.com, kernel-janitors@vger.kernel.org,
Chen-Yu Tsai <wens@csie.org>, LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] mfd: axp20x: convert to use maple tree register cache
Date: Thu, 2 May 2024 10:33:16 +0100 [thread overview]
Message-ID: <20240502093316.GI5338@google.com> (raw)
In-Reply-To: <a7db79ae-71a4-4d73-a7a3-7bd19f8e57ba@web.de>
On Mon, 29 Apr 2024, Markus Elfring wrote:
> > The maple tree register cache is based on a much more modern data structure
> > than the rbtree cache and makes optimisation choices which are probably
> > more appropriate for modern systems than those made by the rbtree cache.
>
> Please choose another imperative wording for an improved change description.
> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?h=v6.9-rc5#n94
This review comment is seldom helpful.
You may as well stop using it.
--
Lee Jones [李琼斯]
next prev parent reply other threads:[~2024-05-02 9:33 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-29 2:45 [PATCH] mfd: axp20x: convert to use maple tree register cache wangkaiyuan
2024-04-29 7:12 ` Markus Elfring
2024-05-02 9:33 ` Lee Jones [this message]
2024-05-02 10:41 ` Markus Elfring
2024-05-02 9:32 ` (subset) [PATCH] " Lee Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240502093316.GI5338@google.com \
--to=lee@kernel.org \
--cc=Markus.Elfring@web.de \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=wangkaiyuan@inspur.com \
--cc=wens@csie.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox