[PATCH] mfd: axp20x: convert to use maple tree register cache

[PATCH] mfd: axp20x: convert to use maple tree register cache

[wangkaiyuan]

The maple tree register cache is based on a much more modern data structure
than the rbtree cache and makes optimisation choices which are probably
more appropriate for modern systems than those made by the rbtree cache.

Signed-off-by: wangkaiyuan <wangkaiyuan@inspur.com>
---
 drivers/mfd/axp20x.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/mfd/axp20x.c b/drivers/mfd/axp20x.c
index 48ce6ea693ce..f2c0f144c0fc 100644
--- a/drivers/mfd/axp20x.c
+++ b/drivers/mfd/axp20x.c
@@ -422,7 +422,7 @@ static const struct regmap_config axp717_regmap_config = {
 	.wr_table = &axp717_writeable_table,
 	.volatile_table = &axp717_volatile_table,
 	.max_register = AXP717_CPUSLDO_CONTROL,
-	.cache_type = REGCACHE_RBTREE,
+	.cache_type = REGCACHE_MAPLE,
 };
 
 static const struct regmap_config axp806_regmap_config = {
-- 
2.27.0

Re: [PATCH] mfd: axp20x: convert to use maple tree register cache

[Markus Elfring]

> The maple tree register cache is based on a much more modern data structure
> than the rbtree cache and makes optimisation choices which are probably
> more appropriate for modern systems than those made by the rbtree cache.

Please choose another imperative wording for an improved change description.
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?h=v6.9-rc5#n94

Regards,
Markus

Re: (subset) [PATCH] mfd: axp20x: convert to use maple tree register cache

[Lee Jones]

On Mon, 29 Apr 2024 10:45:47 +0800, wangkaiyuan wrote:
> The maple tree register cache is based on a much more modern data structure
> than the rbtree cache and makes optimisation choices which are probably
> more appropriate for modern systems than those made by the rbtree cache.
> 
> 

Applied, thanks!

[1/1] mfd: axp20x: convert to use maple tree register cache
      commit: a0fb1c6608c5ff7526e77031e3e90475529414e3

--
Lee Jones [李琼斯]

Re: [PATCH] mfd: axp20x: convert to use maple tree register cache

[Lee Jones]

On Mon, 29 Apr 2024, Markus Elfring wrote:

> > The maple tree register cache is based on a much more modern data structure
> > than the rbtree cache and makes optimisation choices which are probably
> > more appropriate for modern systems than those made by the rbtree cache.
> 
> Please choose another imperative wording for an improved change description.
> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?h=v6.9-rc5#n94

This review comment is seldom helpful.

You may as well stop using it.

-- 
Lee Jones [李琼斯]

Re: mfd: axp20x: convert to use maple tree register cache

[Markus Elfring]

>>> The maple tree register cache is based on a much more modern data structure
>>> than the rbtree cache and makes optimisation choices which are probably
>>> more appropriate for modern systems than those made by the rbtree cache.
>>
>> Please choose another imperative wording for an improved change description.
>> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?h=v6.9-rc5#n94
>
> This review comment is seldom helpful.

* Does such a feedback indicate a questionable communication conflict?

* Are you still looking for a better wording suggestion?


> You may as well stop using it.

Should patch reviewers and further contributors care more for the compliance
with known development processes?

Regards,
Markus