* [PATCH] scftorture: make torture_type static
@ 2024-05-29 20:45 Jeff Johnson
2024-05-29 22:16 ` Paul E. McKenney
0 siblings, 1 reply; 2+ messages in thread
From: Jeff Johnson @ 2024-05-29 20:45 UTC (permalink / raw)
To: Paul E. McKenney; +Cc: linux-kernel, kernel-janitors, Jeff Johnson
Fix the 'make C=1' warning:
kernel/scftorture.c:71:6: warning: symbol 'torture_type' was not declared. Should it be static?
Signed-off-by: Jeff Johnson <quic_jjohnson@quicinc.com>
---
kernel/scftorture.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/kernel/scftorture.c b/kernel/scftorture.c
index 59032aaccd18..13ad348143ca 100644
--- a/kernel/scftorture.c
+++ b/kernel/scftorture.c
@@ -67,7 +67,7 @@ torture_param(int, weight_many_wait, -1, "Testing weight for multi-CPU operation
torture_param(int, weight_all, -1, "Testing weight for all-CPU no-wait operations.");
torture_param(int, weight_all_wait, -1, "Testing weight for all-CPU operations.");
-char *torture_type = "";
+static char *torture_type = "";
#ifdef MODULE
# define SCFTORT_SHUTDOWN 0
---
base-commit: 4a4be1ad3a6efea16c56615f31117590fd881358
change-id: 20240529-static-scftorture-c86eccd9e30e
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] scftorture: make torture_type static
2024-05-29 20:45 [PATCH] scftorture: make torture_type static Jeff Johnson
@ 2024-05-29 22:16 ` Paul E. McKenney
0 siblings, 0 replies; 2+ messages in thread
From: Paul E. McKenney @ 2024-05-29 22:16 UTC (permalink / raw)
To: Jeff Johnson; +Cc: linux-kernel, kernel-janitors
On Wed, May 29, 2024 at 01:45:40PM -0700, Jeff Johnson wrote:
> Fix the 'make C=1' warning:
> kernel/scftorture.c:71:6: warning: symbol 'torture_type' was not declared. Should it be static?
>
> Signed-off-by: Jeff Johnson <quic_jjohnson@quicinc.com>
I queued both this and the scftorture.c fix, thank you!!!
Thanx, Paul
> ---
> kernel/scftorture.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/kernel/scftorture.c b/kernel/scftorture.c
> index 59032aaccd18..13ad348143ca 100644
> --- a/kernel/scftorture.c
> +++ b/kernel/scftorture.c
> @@ -67,7 +67,7 @@ torture_param(int, weight_many_wait, -1, "Testing weight for multi-CPU operation
> torture_param(int, weight_all, -1, "Testing weight for all-CPU no-wait operations.");
> torture_param(int, weight_all_wait, -1, "Testing weight for all-CPU operations.");
>
> -char *torture_type = "";
> +static char *torture_type = "";
>
> #ifdef MODULE
> # define SCFTORT_SHUTDOWN 0
>
> ---
> base-commit: 4a4be1ad3a6efea16c56615f31117590fd881358
> change-id: 20240529-static-scftorture-c86eccd9e30e
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2024-05-29 22:16 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-05-29 20:45 [PATCH] scftorture: make torture_type static Jeff Johnson
2024-05-29 22:16 ` Paul E. McKenney
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox