* [PATCH] perf genelf: remove unused struct 'options'
@ 2024-06-02 0:05 linux
2024-06-03 16:32 ` Ian Rogers
2024-06-04 22:15 ` Namhyung Kim
0 siblings, 2 replies; 3+ messages in thread
From: linux @ 2024-06-02 0:05 UTC (permalink / raw)
To: peterz, mingo, jolsa, irogers
Cc: linux-perf-users, linux-kernel, Dr. David Alan Gilbert
From: "Dr. David Alan Gilbert" <linux@treblig.org>
'options' has been unused since
commit fa7f7e735495 ("perf jit: Move test functionality in to a test").
Remove it.
Signed-off-by: Dr. David Alan Gilbert <linux@treblig.org>
---
tools/perf/util/genelf.c | 5 -----
1 file changed, 5 deletions(-)
diff --git a/tools/perf/util/genelf.c b/tools/perf/util/genelf.c
index ac17a3cb59dc..c8f6bee1fa61 100644
--- a/tools/perf/util/genelf.c
+++ b/tools/perf/util/genelf.c
@@ -54,11 +54,6 @@ typedef struct {
char name[0]; /* Start of the name+desc data */
} Elf_Note;
-struct options {
- char *output;
- int fd;
-};
-
static char shd_string_table[] = {
0,
'.', 't', 'e', 'x', 't', 0, /* 1 */
--
2.45.1
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] perf genelf: remove unused struct 'options'
2024-06-02 0:05 [PATCH] perf genelf: remove unused struct 'options' linux
@ 2024-06-03 16:32 ` Ian Rogers
2024-06-04 22:15 ` Namhyung Kim
1 sibling, 0 replies; 3+ messages in thread
From: Ian Rogers @ 2024-06-03 16:32 UTC (permalink / raw)
To: linux; +Cc: peterz, mingo, jolsa, linux-perf-users, linux-kernel
On Sat, Jun 1, 2024 at 5:05 PM <linux@treblig.org> wrote:
>
> From: "Dr. David Alan Gilbert" <linux@treblig.org>
>
> 'options' has been unused since
> commit fa7f7e735495 ("perf jit: Move test functionality in to a test").
>
> Remove it.
>
> Signed-off-by: Dr. David Alan Gilbert <linux@treblig.org>
Hi/thanks David,
Reviewed-by: Ian Rogers <irogers@google.com>
Ian
> ---
> tools/perf/util/genelf.c | 5 -----
> 1 file changed, 5 deletions(-)
>
> diff --git a/tools/perf/util/genelf.c b/tools/perf/util/genelf.c
> index ac17a3cb59dc..c8f6bee1fa61 100644
> --- a/tools/perf/util/genelf.c
> +++ b/tools/perf/util/genelf.c
> @@ -54,11 +54,6 @@ typedef struct {
> char name[0]; /* Start of the name+desc data */
> } Elf_Note;
>
> -struct options {
> - char *output;
> - int fd;
> -};
> -
> static char shd_string_table[] = {
> 0,
> '.', 't', 'e', 'x', 't', 0, /* 1 */
> --
> 2.45.1
>
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] perf genelf: remove unused struct 'options'
2024-06-02 0:05 [PATCH] perf genelf: remove unused struct 'options' linux
2024-06-03 16:32 ` Ian Rogers
@ 2024-06-04 22:15 ` Namhyung Kim
1 sibling, 0 replies; 3+ messages in thread
From: Namhyung Kim @ 2024-06-04 22:15 UTC (permalink / raw)
To: irogers, peterz, jolsa, mingo, linux; +Cc: linux-perf-users, linux-kernel
On Sun, 2 Jun 2024 01:05:05 +0100, linux@treblig.org wrote:
> From: "Dr. David Alan Gilbert" <linux@treblig.org>
>
> 'options' has been unused since
> commit fa7f7e735495 ("perf jit: Move test functionality in to a test").
>
> Remove it.
>
> [...]
Applied to perf-tools-next, thanks!
Best regards,
--
Namhyung Kim <namhyung@kernel.org>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2024-06-04 22:15 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-06-02 0:05 [PATCH] perf genelf: remove unused struct 'options' linux
2024-06-03 16:32 ` Ian Rogers
2024-06-04 22:15 ` Namhyung Kim
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox