From: Masami Hiramatsu (Google) <mhiramat@kernel.org>
To: Jeff Johnson <quic_jjohnson@quicinc.com>
Cc: "Naveen N. Rao" <naveen.n.rao@linux.ibm.com>,
Anil S Keshavamurthy <anil.s.keshavamurthy@intel.com>,
"David S. Miller" <davem@davemloft.net>,
<linux-kernel@vger.kernel.org>,
<linux-trace-kernel@vger.kernel.org>,
<kernel-janitors@vger.kernel.org>
Subject: Re: [PATCH] samples: kprobes: add missing MODULE_DESCRIPTION() macros
Date: Sun, 2 Jun 2024 11:30:18 +0900 [thread overview]
Message-ID: <20240602113018.4771521d3651150422919cef@kernel.org> (raw)
In-Reply-To: <20240601-md-samples-kprobes-v1-1-b6a772353893@quicinc.com>
On Sat, 1 Jun 2024 18:31:55 -0700
Jeff Johnson <quic_jjohnson@quicinc.com> wrote:
> make allmodconfig && make W=1 C=1 reports:
> WARNING: modpost: missing MODULE_DESCRIPTION() in samples/kprobes/kprobe_example.o
> WARNING: modpost: missing MODULE_DESCRIPTION() in samples/kprobes/kretprobe_example.o
>
> Add the missing invocations of the MODULE_DESCRIPTION() macro.
>
OK, these are also good to me too.
Thanks,
> Signed-off-by: Jeff Johnson <quic_jjohnson@quicinc.com>
> ---
> samples/kprobes/kprobe_example.c | 1 +
> samples/kprobes/kretprobe_example.c | 1 +
> 2 files changed, 2 insertions(+)
>
> diff --git a/samples/kprobes/kprobe_example.c b/samples/kprobes/kprobe_example.c
> index ef44c614c6d9..53ec6c8b8c40 100644
> --- a/samples/kprobes/kprobe_example.c
> +++ b/samples/kprobes/kprobe_example.c
> @@ -125,4 +125,5 @@ static void __exit kprobe_exit(void)
>
> module_init(kprobe_init)
> module_exit(kprobe_exit)
> +MODULE_DESCRIPTION("sample kernel module showing the use of kprobes");
> MODULE_LICENSE("GPL");
> diff --git a/samples/kprobes/kretprobe_example.c b/samples/kprobes/kretprobe_example.c
> index ed79fd3d48fb..65d6dcafd742 100644
> --- a/samples/kprobes/kretprobe_example.c
> +++ b/samples/kprobes/kretprobe_example.c
> @@ -104,4 +104,5 @@ static void __exit kretprobe_exit(void)
>
> module_init(kretprobe_init)
> module_exit(kretprobe_exit)
> +MODULE_DESCRIPTION("sample kernel module showing the use of return probes");
> MODULE_LICENSE("GPL");
>
> ---
> base-commit: b050496579632f86ee1ef7e7501906db579f3457
> change-id: 20240601-md-samples-kprobes-efb32cbcc8dd
>
--
Masami Hiramatsu (Google) <mhiramat@kernel.org>
prev parent reply other threads:[~2024-06-02 2:30 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-02 1:31 [PATCH] samples: kprobes: add missing MODULE_DESCRIPTION() macros Jeff Johnson
2024-06-02 2:30 ` Masami Hiramatsu [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240602113018.4771521d3651150422919cef@kernel.org \
--to=mhiramat@kernel.org \
--cc=anil.s.keshavamurthy@intel.com \
--cc=davem@davemloft.net \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-trace-kernel@vger.kernel.org \
--cc=naveen.n.rao@linux.ibm.com \
--cc=quic_jjohnson@quicinc.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox