* [PATCH] samples: kprobes: add missing MODULE_DESCRIPTION() macros
@ 2024-06-02 1:31 Jeff Johnson
2024-06-02 2:30 ` Masami Hiramatsu
0 siblings, 1 reply; 2+ messages in thread
From: Jeff Johnson @ 2024-06-02 1:31 UTC (permalink / raw)
To: Naveen N. Rao, Anil S Keshavamurthy, David S. Miller,
Masami Hiramatsu
Cc: linux-kernel, linux-trace-kernel, kernel-janitors, Jeff Johnson
make allmodconfig && make W=1 C=1 reports:
WARNING: modpost: missing MODULE_DESCRIPTION() in samples/kprobes/kprobe_example.o
WARNING: modpost: missing MODULE_DESCRIPTION() in samples/kprobes/kretprobe_example.o
Add the missing invocations of the MODULE_DESCRIPTION() macro.
Signed-off-by: Jeff Johnson <quic_jjohnson@quicinc.com>
---
samples/kprobes/kprobe_example.c | 1 +
samples/kprobes/kretprobe_example.c | 1 +
2 files changed, 2 insertions(+)
diff --git a/samples/kprobes/kprobe_example.c b/samples/kprobes/kprobe_example.c
index ef44c614c6d9..53ec6c8b8c40 100644
--- a/samples/kprobes/kprobe_example.c
+++ b/samples/kprobes/kprobe_example.c
@@ -125,4 +125,5 @@ static void __exit kprobe_exit(void)
module_init(kprobe_init)
module_exit(kprobe_exit)
+MODULE_DESCRIPTION("sample kernel module showing the use of kprobes");
MODULE_LICENSE("GPL");
diff --git a/samples/kprobes/kretprobe_example.c b/samples/kprobes/kretprobe_example.c
index ed79fd3d48fb..65d6dcafd742 100644
--- a/samples/kprobes/kretprobe_example.c
+++ b/samples/kprobes/kretprobe_example.c
@@ -104,4 +104,5 @@ static void __exit kretprobe_exit(void)
module_init(kretprobe_init)
module_exit(kretprobe_exit)
+MODULE_DESCRIPTION("sample kernel module showing the use of return probes");
MODULE_LICENSE("GPL");
---
base-commit: b050496579632f86ee1ef7e7501906db579f3457
change-id: 20240601-md-samples-kprobes-efb32cbcc8dd
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] samples: kprobes: add missing MODULE_DESCRIPTION() macros
2024-06-02 1:31 [PATCH] samples: kprobes: add missing MODULE_DESCRIPTION() macros Jeff Johnson
@ 2024-06-02 2:30 ` Masami Hiramatsu
0 siblings, 0 replies; 2+ messages in thread
From: Masami Hiramatsu @ 2024-06-02 2:30 UTC (permalink / raw)
To: Jeff Johnson
Cc: Naveen N. Rao, Anil S Keshavamurthy, David S. Miller,
linux-kernel, linux-trace-kernel, kernel-janitors
On Sat, 1 Jun 2024 18:31:55 -0700
Jeff Johnson <quic_jjohnson@quicinc.com> wrote:
> make allmodconfig && make W=1 C=1 reports:
> WARNING: modpost: missing MODULE_DESCRIPTION() in samples/kprobes/kprobe_example.o
> WARNING: modpost: missing MODULE_DESCRIPTION() in samples/kprobes/kretprobe_example.o
>
> Add the missing invocations of the MODULE_DESCRIPTION() macro.
>
OK, these are also good to me too.
Thanks,
> Signed-off-by: Jeff Johnson <quic_jjohnson@quicinc.com>
> ---
> samples/kprobes/kprobe_example.c | 1 +
> samples/kprobes/kretprobe_example.c | 1 +
> 2 files changed, 2 insertions(+)
>
> diff --git a/samples/kprobes/kprobe_example.c b/samples/kprobes/kprobe_example.c
> index ef44c614c6d9..53ec6c8b8c40 100644
> --- a/samples/kprobes/kprobe_example.c
> +++ b/samples/kprobes/kprobe_example.c
> @@ -125,4 +125,5 @@ static void __exit kprobe_exit(void)
>
> module_init(kprobe_init)
> module_exit(kprobe_exit)
> +MODULE_DESCRIPTION("sample kernel module showing the use of kprobes");
> MODULE_LICENSE("GPL");
> diff --git a/samples/kprobes/kretprobe_example.c b/samples/kprobes/kretprobe_example.c
> index ed79fd3d48fb..65d6dcafd742 100644
> --- a/samples/kprobes/kretprobe_example.c
> +++ b/samples/kprobes/kretprobe_example.c
> @@ -104,4 +104,5 @@ static void __exit kretprobe_exit(void)
>
> module_init(kretprobe_init)
> module_exit(kretprobe_exit)
> +MODULE_DESCRIPTION("sample kernel module showing the use of return probes");
> MODULE_LICENSE("GPL");
>
> ---
> base-commit: b050496579632f86ee1ef7e7501906db579f3457
> change-id: 20240601-md-samples-kprobes-efb32cbcc8dd
>
--
Masami Hiramatsu (Google) <mhiramat@kernel.org>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2024-06-02 2:30 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-06-02 1:31 [PATCH] samples: kprobes: add missing MODULE_DESCRIPTION() macros Jeff Johnson
2024-06-02 2:30 ` Masami Hiramatsu
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox