* [PATCH RFT] pinctrl: da9062: replace gpiochip_get_desc() with gpio_device_get_desc()
@ 2024-06-18 11:18 Bartosz Golaszewski
2024-06-18 11:27 ` Linus Walleij
2024-06-25 7:13 ` Bartosz Golaszewski
0 siblings, 2 replies; 4+ messages in thread
From: Bartosz Golaszewski @ 2024-06-18 11:18 UTC (permalink / raw)
To: Support Opensource, Linus Walleij
Cc: linux-gpio, linux-kernel, Bartosz Golaszewski
From: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
In order to finally confine the unsafe gpiochip_get_desc() to
drivers/gpio/, let's convert this driver to using the safer alternative
that takes the gpio_device as argument.
Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
---
drivers/pinctrl/pinctrl-da9062.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/pinctrl/pinctrl-da9062.c b/drivers/pinctrl/pinctrl-da9062.c
index 22e3cd2cc963..6f44a13b90ce 100644
--- a/drivers/pinctrl/pinctrl-da9062.c
+++ b/drivers/pinctrl/pinctrl-da9062.c
@@ -139,7 +139,7 @@ static int da9062_gpio_direction_input(struct gpio_chip *gc,
{
struct da9062_pctl *pctl = gpiochip_get_data(gc);
struct regmap *regmap = pctl->da9062->regmap;
- struct gpio_desc *desc = gpiochip_get_desc(gc, offset);
+ struct gpio_desc *desc = gpio_device_get_desc(gc->gpiodev, offset);
unsigned int gpi_type;
int ret;
--
2.43.0
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH RFT] pinctrl: da9062: replace gpiochip_get_desc() with gpio_device_get_desc()
2024-06-18 11:18 [PATCH RFT] pinctrl: da9062: replace gpiochip_get_desc() with gpio_device_get_desc() Bartosz Golaszewski
@ 2024-06-18 11:27 ` Linus Walleij
2024-06-18 11:34 ` Bartosz Golaszewski
2024-06-25 7:13 ` Bartosz Golaszewski
1 sibling, 1 reply; 4+ messages in thread
From: Linus Walleij @ 2024-06-18 11:27 UTC (permalink / raw)
To: Bartosz Golaszewski
Cc: Support Opensource, linux-gpio, linux-kernel, Bartosz Golaszewski
On Tue, Jun 18, 2024 at 1:18 PM Bartosz Golaszewski <brgl@bgdev.pl> wrote:
> From: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
>
> In order to finally confine the unsafe gpiochip_get_desc() to
> drivers/gpio/, let's convert this driver to using the safer alternative
> that takes the gpio_device as argument.
>
> Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
Acked-by: Linus Walleij <linus.walleij@linaro.org>
I guess you will apply this to the GPIO tree, else tell me what to do!
Yours,
Linus Walleij
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH RFT] pinctrl: da9062: replace gpiochip_get_desc() with gpio_device_get_desc()
2024-06-18 11:27 ` Linus Walleij
@ 2024-06-18 11:34 ` Bartosz Golaszewski
0 siblings, 0 replies; 4+ messages in thread
From: Bartosz Golaszewski @ 2024-06-18 11:34 UTC (permalink / raw)
To: Linus Walleij
Cc: Support Opensource, linux-gpio, linux-kernel, Bartosz Golaszewski
On Tue, Jun 18, 2024 at 1:27 PM Linus Walleij <linus.walleij@linaro.org> wrote:
>
> On Tue, Jun 18, 2024 at 1:18 PM Bartosz Golaszewski <brgl@bgdev.pl> wrote:
>
> > From: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
> >
> > In order to finally confine the unsafe gpiochip_get_desc() to
> > drivers/gpio/, let's convert this driver to using the safer alternative
> > that takes the gpio_device as argument.
> >
> > Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
>
> Acked-by: Linus Walleij <linus.walleij@linaro.org>
>
> I guess you will apply this to the GPIO tree, else tell me what to do!
>
> Yours,
> Linus Walleij
I can, yes. Thank you.
I'll give it some time to possibly get a Tested-by from Dialog.
Bart
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH RFT] pinctrl: da9062: replace gpiochip_get_desc() with gpio_device_get_desc()
2024-06-18 11:18 [PATCH RFT] pinctrl: da9062: replace gpiochip_get_desc() with gpio_device_get_desc() Bartosz Golaszewski
2024-06-18 11:27 ` Linus Walleij
@ 2024-06-25 7:13 ` Bartosz Golaszewski
1 sibling, 0 replies; 4+ messages in thread
From: Bartosz Golaszewski @ 2024-06-25 7:13 UTC (permalink / raw)
To: Support Opensource, Linus Walleij, Bartosz Golaszewski
Cc: Bartosz Golaszewski, linux-gpio, linux-kernel
From: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
On Tue, 18 Jun 2024 13:18:24 +0200, Bartosz Golaszewski wrote:
> In order to finally confine the unsafe gpiochip_get_desc() to
> drivers/gpio/, let's convert this driver to using the safer alternative
> that takes the gpio_device as argument.
>
>
Applied, thanks!
[1/1] pinctrl: da9062: replace gpiochip_get_desc() with gpio_device_get_desc()
commit: 8657af6c0a9afaa11947b7476119834898823b52
Best regards,
--
Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2024-06-25 7:13 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-06-18 11:18 [PATCH RFT] pinctrl: da9062: replace gpiochip_get_desc() with gpio_device_get_desc() Bartosz Golaszewski
2024-06-18 11:27 ` Linus Walleij
2024-06-18 11:34 ` Bartosz Golaszewski
2024-06-25 7:13 ` Bartosz Golaszewski
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox