* [PATCH] drm: Remove unused function rcar_cmm_write
@ 2024-06-19 7:54 Jiapeng Chong
2024-06-19 9:16 ` Sergey Shtylyov
2024-06-19 9:24 ` Kieran Bingham
0 siblings, 2 replies; 4+ messages in thread
From: Jiapeng Chong @ 2024-06-19 7:54 UTC (permalink / raw)
To: laurent.pinchart
Cc: kieran.bingham+renesas, airlied, daniel, dri-devel,
linux-renesas-soc, linux-kernel, Jiapeng Chong, Abaci Robot
The function are defined in the rcar_cmm.c file, but not called
elsewhere, so delete the unused function.
drivers/gpu/drm/renesas/rcar-du/rcar_cmm.c:35:19: warning: unused function 'rcar_cmm_read'.
Reported-by: Abaci Robot <abaci@linux.alibaba.com>
Closes: https://bugzilla.openanolis.cn/show_bug.cgi?id=9364
Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>
---
drivers/gpu/drm/renesas/rcar-du/rcar_cmm.c | 5 -----
1 file changed, 5 deletions(-)
diff --git a/drivers/gpu/drm/renesas/rcar-du/rcar_cmm.c b/drivers/gpu/drm/renesas/rcar-du/rcar_cmm.c
index 26a2f5ad8ee5..883b960e9acc 100644
--- a/drivers/gpu/drm/renesas/rcar-du/rcar_cmm.c
+++ b/drivers/gpu/drm/renesas/rcar-du/rcar_cmm.c
@@ -32,11 +32,6 @@ struct rcar_cmm {
} lut;
};
-static inline int rcar_cmm_read(struct rcar_cmm *rcmm, u32 reg)
-{
- return ioread32(rcmm->base + reg);
-}
-
static inline void rcar_cmm_write(struct rcar_cmm *rcmm, u32 reg, u32 data)
{
iowrite32(data, rcmm->base + reg);
--
2.20.1.7.g153144c
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] drm: Remove unused function rcar_cmm_write
2024-06-19 7:54 [PATCH] drm: Remove unused function rcar_cmm_write Jiapeng Chong
@ 2024-06-19 9:16 ` Sergey Shtylyov
2024-06-19 16:53 ` Laurent Pinchart
2024-06-19 9:24 ` Kieran Bingham
1 sibling, 1 reply; 4+ messages in thread
From: Sergey Shtylyov @ 2024-06-19 9:16 UTC (permalink / raw)
To: Jiapeng Chong, laurent.pinchart
Cc: kieran.bingham+renesas, airlied, daniel, dri-devel,
linux-renesas-soc, linux-kernel, Abaci Robot
On 6/19/24 10:54 AM, Jiapeng Chong wrote:
> The function are defined in the rcar_cmm.c file, but not called
s/are/is/.
> elsewhere, so delete the unused function.
Anywhere, maybe?
> drivers/gpu/drm/renesas/rcar-du/rcar_cmm.c:35:19: warning: unused function 'rcar_cmm_read'.
>
> Reported-by: Abaci Robot <abaci@linux.alibaba.com>
> Closes: https://bugzilla.openanolis.cn/show_bug.cgi?id=9364
> Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>
[...]
MBR, Sergey
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] drm: Remove unused function rcar_cmm_write
2024-06-19 7:54 [PATCH] drm: Remove unused function rcar_cmm_write Jiapeng Chong
2024-06-19 9:16 ` Sergey Shtylyov
@ 2024-06-19 9:24 ` Kieran Bingham
1 sibling, 0 replies; 4+ messages in thread
From: Kieran Bingham @ 2024-06-19 9:24 UTC (permalink / raw)
To: Jiapeng Chong, laurent.pinchart
Cc: airlied, daniel, dri-devel, linux-renesas-soc, linux-kernel,
Jiapeng Chong, Abaci Robot
Quoting Jiapeng Chong (2024-06-19 08:54:36)
> The function are defined in the rcar_cmm.c file, but not called
> elsewhere, so delete the unused function.
>
> drivers/gpu/drm/renesas/rcar-du/rcar_cmm.c:35:19: warning: unused function 'rcar_cmm_read'.
Indeed it's unused.
Reviewed-by: Kieran Bingham <kieran.bingham+renesas@ideasonboard.com>
> Reported-by: Abaci Robot <abaci@linux.alibaba.com>
> Closes: https://bugzilla.openanolis.cn/show_bug.cgi?id=9364
> Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>
> ---
> drivers/gpu/drm/renesas/rcar-du/rcar_cmm.c | 5 -----
> 1 file changed, 5 deletions(-)
>
> diff --git a/drivers/gpu/drm/renesas/rcar-du/rcar_cmm.c b/drivers/gpu/drm/renesas/rcar-du/rcar_cmm.c
> index 26a2f5ad8ee5..883b960e9acc 100644
> --- a/drivers/gpu/drm/renesas/rcar-du/rcar_cmm.c
> +++ b/drivers/gpu/drm/renesas/rcar-du/rcar_cmm.c
> @@ -32,11 +32,6 @@ struct rcar_cmm {
> } lut;
> };
>
> -static inline int rcar_cmm_read(struct rcar_cmm *rcmm, u32 reg)
> -{
> - return ioread32(rcmm->base + reg);
> -}
> -
> static inline void rcar_cmm_write(struct rcar_cmm *rcmm, u32 reg, u32 data)
> {
> iowrite32(data, rcmm->base + reg);
> --
> 2.20.1.7.g153144c
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] drm: Remove unused function rcar_cmm_write
2024-06-19 9:16 ` Sergey Shtylyov
@ 2024-06-19 16:53 ` Laurent Pinchart
0 siblings, 0 replies; 4+ messages in thread
From: Laurent Pinchart @ 2024-06-19 16:53 UTC (permalink / raw)
To: Sergey Shtylyov
Cc: Jiapeng Chong, kieran.bingham+renesas, airlied, daniel, dri-devel,
linux-renesas-soc, linux-kernel, Abaci Robot
On Wed, Jun 19, 2024 at 12:16:47PM +0300, Sergey Shtylyov wrote:
> On 6/19/24 10:54 AM, Jiapeng Chong wrote:
>
> > The function are defined in the rcar_cmm.c file, but not called
>
> s/are/is/.
>
> > elsewhere, so delete the unused function.
>
> Anywhere, maybe?
I'll fix those.
Reviewed-by: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>
> > drivers/gpu/drm/renesas/rcar-du/rcar_cmm.c:35:19: warning: unused function 'rcar_cmm_read'.
> >
> > Reported-by: Abaci Robot <abaci@linux.alibaba.com>
> > Closes: https://bugzilla.openanolis.cn/show_bug.cgi?id=9364
> > Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>
>
> [...]
--
Regards,
Laurent Pinchart
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2024-06-19 16:54 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-06-19 7:54 [PATCH] drm: Remove unused function rcar_cmm_write Jiapeng Chong
2024-06-19 9:16 ` Sergey Shtylyov
2024-06-19 16:53 ` Laurent Pinchart
2024-06-19 9:24 ` Kieran Bingham
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox