* [PATCH v1] devres: Fix memory leakage due to driver API devm_free_percpu()
@ 2024-06-19 13:38 Zijun Hu
2024-06-19 14:53 ` Greg KH
0 siblings, 1 reply; 3+ messages in thread
From: Zijun Hu @ 2024-06-19 13:38 UTC (permalink / raw)
To: gregkh, rafael, davem, madalin.bucur; +Cc: linux-kernel, stable, Zijun Hu
It will cause memory leakage when use driver API devm_free_percpu()
to free memory allocated by devm_alloc_percpu(), fixed by using
devres_release() instead of devres_destroy() within devm_free_percpu().
Fixes: ff86aae3b411 ("devres: add devm_alloc_percpu()")
Cc: stable@vger.kernel.org
Signed-off-by: Zijun Hu <quic_zijuhu@quicinc.com>
---
drivers/base/devres.c | 6 +++++-
1 file changed, 5 insertions(+), 1 deletion(-)
diff --git a/drivers/base/devres.c b/drivers/base/devres.c
index 3df0025d12aa..082dbb296b6e 100644
--- a/drivers/base/devres.c
+++ b/drivers/base/devres.c
@@ -1222,7 +1222,11 @@ EXPORT_SYMBOL_GPL(__devm_alloc_percpu);
*/
void devm_free_percpu(struct device *dev, void __percpu *pdata)
{
- WARN_ON(devres_destroy(dev, devm_percpu_release, devm_percpu_match,
+ /*
+ * Use devres_release() to prevent memory leakage as
+ * devm_free_pages() does.
+ */
+ WARN_ON(devres_release(dev, devm_percpu_release, devm_percpu_match,
(__force void *)pdata));
}
EXPORT_SYMBOL_GPL(devm_free_percpu);
--
2.7.4
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH v1] devres: Fix memory leakage due to driver API devm_free_percpu()
2024-06-19 13:38 [PATCH v1] devres: Fix memory leakage due to driver API devm_free_percpu() Zijun Hu
@ 2024-06-19 14:53 ` Greg KH
2024-06-20 11:56 ` quic_zijuhu
0 siblings, 1 reply; 3+ messages in thread
From: Greg KH @ 2024-06-19 14:53 UTC (permalink / raw)
To: Zijun Hu; +Cc: rafael, davem, madalin.bucur, linux-kernel, stable
On Wed, Jun 19, 2024 at 09:38:01PM +0800, Zijun Hu wrote:
> It will cause memory leakage when use driver API devm_free_percpu()
> to free memory allocated by devm_alloc_percpu(), fixed by using
> devres_release() instead of devres_destroy() within devm_free_percpu().
>
> Fixes: ff86aae3b411 ("devres: add devm_alloc_percpu()")
> Cc: stable@vger.kernel.org
> Signed-off-by: Zijun Hu <quic_zijuhu@quicinc.com>
> ---
> drivers/base/devres.c | 6 +++++-
> 1 file changed, 5 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/base/devres.c b/drivers/base/devres.c
> index 3df0025d12aa..082dbb296b6e 100644
> --- a/drivers/base/devres.c
> +++ b/drivers/base/devres.c
> @@ -1222,7 +1222,11 @@ EXPORT_SYMBOL_GPL(__devm_alloc_percpu);
> */
> void devm_free_percpu(struct device *dev, void __percpu *pdata)
> {
> - WARN_ON(devres_destroy(dev, devm_percpu_release, devm_percpu_match,
> + /*
> + * Use devres_release() to prevent memory leakage as
> + * devm_free_pages() does.
> + */
> + WARN_ON(devres_release(dev, devm_percpu_release, devm_percpu_match,
> (__force void *)pdata));
> }
> EXPORT_SYMBOL_GPL(devm_free_percpu);
> --
> 2.7.4
>
>
These are good fixes, how are you finding them? Care to write up some
kunit tests for the devres apis?
thanks,
greg k-h
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH v1] devres: Fix memory leakage due to driver API devm_free_percpu()
2024-06-19 14:53 ` Greg KH
@ 2024-06-20 11:56 ` quic_zijuhu
0 siblings, 0 replies; 3+ messages in thread
From: quic_zijuhu @ 2024-06-20 11:56 UTC (permalink / raw)
To: Greg KH; +Cc: rafael, davem, madalin.bucur, linux-kernel, stable
On 6/19/2024 10:53 PM, Greg KH wrote:
> On Wed, Jun 19, 2024 at 09:38:01PM +0800, Zijun Hu wrote:
>> It will cause memory leakage when use driver API devm_free_percpu()
>> to free memory allocated by devm_alloc_percpu(), fixed by using
>> devres_release() instead of devres_destroy() within devm_free_percpu().
>>
>> Fixes: ff86aae3b411 ("devres: add devm_alloc_percpu()")
>> Cc: stable@vger.kernel.org
>> Signed-off-by: Zijun Hu <quic_zijuhu@quicinc.com>
>> ---
>> drivers/base/devres.c | 6 +++++-
>> 1 file changed, 5 insertions(+), 1 deletion(-)
>>
>> diff --git a/drivers/base/devres.c b/drivers/base/devres.c
>> index 3df0025d12aa..082dbb296b6e 100644
>> --- a/drivers/base/devres.c
>> +++ b/drivers/base/devres.c
>> @@ -1222,7 +1222,11 @@ EXPORT_SYMBOL_GPL(__devm_alloc_percpu);
>> */
>> void devm_free_percpu(struct device *dev, void __percpu *pdata)
>> {
>> - WARN_ON(devres_destroy(dev, devm_percpu_release, devm_percpu_match,
>> + /*
>> + * Use devres_release() to prevent memory leakage as
>> + * devm_free_pages() does.
>> + */
>> + WARN_ON(devres_release(dev, devm_percpu_release, devm_percpu_match,
>> (__force void *)pdata));
>> }
>> EXPORT_SYMBOL_GPL(devm_free_percpu);
>> --
>> 2.7.4
>>
>>
>
> These are good fixes, how are you finding them? Care to write up some
> kunit tests for the devres apis?
>
find them by reading code.😀
> thanks,
>
> greg k-h
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2024-06-20 11:57 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-06-19 13:38 [PATCH v1] devres: Fix memory leakage due to driver API devm_free_percpu() Zijun Hu
2024-06-19 14:53 ` Greg KH
2024-06-20 11:56 ` quic_zijuhu
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox