The Linux Kernel Mailing List
 help / color / mirror / Atom feed
* [PATCH 1/1] iommu/vt-d: Remove comment for def_domain_type
@ 2024-06-24  2:43 Lu Baolu
  2024-06-25  2:24 ` Tian, Kevin
  0 siblings, 1 reply; 2+ messages in thread
From: Lu Baolu @ 2024-06-24  2:43 UTC (permalink / raw)
  To: iommu; +Cc: Joerg Roedel, Will Deacon, Robin Murphy, linux-kernel, Lu Baolu

The comment for def_domain_type is outdated. Part of it is irrelevant.
Furthermore, it could just be deleted since the iommu_ops::def_domain_type
callback is properly documented in iommu.h, so individual implementations
shouldn't need to repeat that. Remove it to avoid confusion.

Signed-off-by: Lu Baolu <baolu.lu@linux.intel.com>
---
 drivers/iommu/intel/iommu.c | 11 -----------
 1 file changed, 11 deletions(-)

diff --git a/drivers/iommu/intel/iommu.c b/drivers/iommu/intel/iommu.c
index ccde5f5972e4..640081933aed 100644
--- a/drivers/iommu/intel/iommu.c
+++ b/drivers/iommu/intel/iommu.c
@@ -2177,17 +2177,6 @@ static bool device_rmrr_is_relaxable(struct device *dev)
 		return false;
 }
 
-/*
- * Return the required default domain type for a specific device.
- *
- * @dev: the device in query
- * @startup: true if this is during early boot
- *
- * Returns:
- *  - IOMMU_DOMAIN_DMA: device requires a dynamic mapping domain
- *  - IOMMU_DOMAIN_IDENTITY: device requires an identical mapping domain
- *  - 0: both identity and dynamic domains work for this device
- */
 static int device_def_domain_type(struct device *dev)
 {
 	if (dev_is_pci(dev)) {
-- 
2.34.1


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* RE: [PATCH 1/1] iommu/vt-d: Remove comment for def_domain_type
  2024-06-24  2:43 [PATCH 1/1] iommu/vt-d: Remove comment for def_domain_type Lu Baolu
@ 2024-06-25  2:24 ` Tian, Kevin
  0 siblings, 0 replies; 2+ messages in thread
From: Tian, Kevin @ 2024-06-25  2:24 UTC (permalink / raw)
  To: Lu Baolu, iommu@lists.linux.dev
  Cc: Joerg Roedel, Will Deacon, Robin Murphy,
	linux-kernel@vger.kernel.org

> From: Lu Baolu <baolu.lu@linux.intel.com>
> Sent: Monday, June 24, 2024 10:43 AM
> 
> The comment for def_domain_type is outdated. Part of it is irrelevant.
> Furthermore, it could just be deleted since the
> iommu_ops::def_domain_type
> callback is properly documented in iommu.h, so individual implementations
> shouldn't need to repeat that. Remove it to avoid confusion.
> 
> Signed-off-by: Lu Baolu <baolu.lu@linux.intel.com>

Reviewed-by: Kevin Tian <kevin.tian@intel.com>

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2024-06-25  2:24 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-06-24  2:43 [PATCH 1/1] iommu/vt-d: Remove comment for def_domain_type Lu Baolu
2024-06-25  2:24 ` Tian, Kevin

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox