[PATCH 1/1] iommu/vt-d: Downgrade warning for pre-enabled IR

[PATCH 1/1] iommu/vt-d: Downgrade warning for pre-enabled IR

[Lu Baolu]

Emitting a warning is overkill in intel_setup_irq_remapping() since the
interrupt remapping is pre-enabled. For example, there's no guarantee
that kexec will explicitly disable interrupt remapping before booting a
new kernel. As a result, users are seeing warning messages like below
when they kexec boot a kernel, though there is nothing wrong:

 DMAR-IR: IRQ remapping was enabled on dmar18 but we are not in kdump mode
 DMAR-IR: IRQ remapping was enabled on dmar17 but we are not in kdump mode
 DMAR-IR: IRQ remapping was enabled on dmar16 but we are not in kdump mode
 ... ...

Downgrade the severity of this message to avoid user confusion.

CC: Paul Menzel <pmenzel@molgen.mpg.de>
Link: https://lore.kernel.org/linux-iommu/5517f76a-94ad-452c-bae6-34ecc0ec4831@molgen.mpg.de/
Signed-off-by: Lu Baolu <baolu.lu@linux.intel.com>
---
 drivers/iommu/intel/irq_remapping.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/iommu/intel/irq_remapping.c b/drivers/iommu/intel/irq_remapping.c
index e4a70886678c..e090ca07364b 100644
--- a/drivers/iommu/intel/irq_remapping.c
+++ b/drivers/iommu/intel/irq_remapping.c
@@ -597,8 +597,8 @@ static int intel_setup_irq_remapping(struct intel_iommu *iommu)
 
 	if (ir_pre_enabled(iommu)) {
 		if (!is_kdump_kernel()) {
-			pr_warn("IRQ remapping was enabled on %s but we are not in kdump mode\n",
-				iommu->name);
+			pr_info_once("IRQ remapping was enabled on %s but we are not in kdump mode\n",
+				     iommu->name);
 			clear_ir_pre_enabled(iommu);
 			iommu_disable_irq_remapping(iommu);
 		} else if (iommu_load_old_irte(iommu))
-- 
2.34.1

RE: [PATCH 1/1] iommu/vt-d: Downgrade warning for pre-enabled IR

[Tian, Kevin]

> From: Lu Baolu <baolu.lu@linux.intel.com>
> Sent: Tuesday, June 25, 2024 12:39 PM
> 
> Emitting a warning is overkill in intel_setup_irq_remapping() since the
> interrupt remapping is pre-enabled. For example, there's no guarantee
> that kexec will explicitly disable interrupt remapping before booting a
> new kernel. As a result, users are seeing warning messages like below
> when they kexec boot a kernel, though there is nothing wrong:
> 
>  DMAR-IR: IRQ remapping was enabled on dmar18 but we are not in kdump
> mode
>  DMAR-IR: IRQ remapping was enabled on dmar17 but we are not in kdump
> mode
>  DMAR-IR: IRQ remapping was enabled on dmar16 but we are not in kdump
> mode
>  ... ...
> 
> Downgrade the severity of this message to avoid user confusion.
> 
> CC: Paul Menzel <pmenzel@molgen.mpg.de>
> Link: https://lore.kernel.org/linux-iommu/5517f76a-94ad-452c-bae6-
> 34ecc0ec4831@molgen.mpg.de/
> Signed-off-by: Lu Baolu <baolu.lu@linux.intel.com>

Reviewed-by: Kevin Tian <kevin.tian@intel.com>