* [PATCH] usb/usbip: remove unnecessary code
@ 2024-06-25 5:13 Xiaobo Liu
2024-06-28 17:16 ` Shuah Khan
0 siblings, 1 reply; 2+ messages in thread
From: Xiaobo Liu @ 2024-06-25 5:13 UTC (permalink / raw)
To: valentina.manea.m, shuah, i; +Cc: gregkh, linux-usb, linux-kernel, Xiaobo Liu
Both if branches assign a value to the `cmd` variable.
We can remove the cmd variable and use `pdu->base.command` directly.
Signed-off-by: Xiaobo Liu <cppcoffee@gmail.com>
---
drivers/usb/usbip/usbip_common.c | 10 +---------
1 file changed, 1 insertion(+), 9 deletions(-)
diff --git a/drivers/usb/usbip/usbip_common.c b/drivers/usb/usbip/usbip_common.c
index a2b2da125..74a01a265 100644
--- a/drivers/usb/usbip/usbip_common.c
+++ b/drivers/usb/usbip/usbip_common.c
@@ -568,17 +568,9 @@ static void correct_endian_ret_unlink(struct usbip_header_ret_unlink *pdu,
void usbip_header_correct_endian(struct usbip_header *pdu, int send)
{
- __u32 cmd = 0;
-
- if (send)
- cmd = pdu->base.command;
-
correct_endian_basic(&pdu->base, send);
- if (!send)
- cmd = pdu->base.command;
-
- switch (cmd) {
+ switch (pdu->base.command) {
case USBIP_CMD_SUBMIT:
correct_endian_cmd_submit(&pdu->u.cmd_submit, send);
break;
--
2.34.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] usb/usbip: remove unnecessary code
2024-06-25 5:13 [PATCH] usb/usbip: remove unnecessary code Xiaobo Liu
@ 2024-06-28 17:16 ` Shuah Khan
0 siblings, 0 replies; 2+ messages in thread
From: Shuah Khan @ 2024-06-28 17:16 UTC (permalink / raw)
To: Xiaobo Liu, valentina.manea.m, shuah, i
Cc: gregkh, linux-usb, linux-kernel, Shuah Khan
On 6/24/24 23:13, Xiaobo Liu wrote:
> Both if branches assign a value to the `cmd` variable.
> We can remove the cmd variable and use `pdu->base.command` directly.
>
> Signed-off-by: Xiaobo Liu <cppcoffee@gmail.com>
This is a duplicate patch and same comments and NAK on this
patch.
> ---
> drivers/usb/usbip/usbip_common.c | 10 +---------
> 1 file changed, 1 insertion(+), 9 deletions(-)
>
> diff --git a/drivers/usb/usbip/usbip_common.c b/drivers/usb/usbip/usbip_common.c
> index a2b2da125..74a01a265 100644
> --- a/drivers/usb/usbip/usbip_common.c
> +++ b/drivers/usb/usbip/usbip_common.c
> @@ -568,17 +568,9 @@ static void correct_endian_ret_unlink(struct usbip_header_ret_unlink *pdu,
>
> void usbip_header_correct_endian(struct usbip_header *pdu, int send)
> {
> - __u32 cmd = 0;
> -
> - if (send)
> - cmd = pdu->base.command;
> -
> correct_endian_basic(&pdu->base, send);
>
> - if (!send)
> - cmd = pdu->base.command;
> -
> - switch (cmd) {
> + switch (pdu->base.command) {
> case USBIP_CMD_SUBMIT:
> correct_endian_cmd_submit(&pdu->u.cmd_submit, send);
> break;
thanks,
-- Shuah
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2024-06-28 17:16 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-06-25 5:13 [PATCH] usb/usbip: remove unnecessary code Xiaobo Liu
2024-06-28 17:16 ` Shuah Khan
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox