From: Yazen Ghannam <yazen.ghannam@amd.com>
To: Nikolay Borisov <nik.borisov@suse.com>
Cc: linux-edac@vger.kernel.org, linux-kernel@vger.kernel.org,
tony.luck@intel.com, x86@kernel.org, avadhut.naik@amd.com,
john.allen@amd.com
Subject: Re: [PATCH v2 4/5] x86/mce: Define mce_prep_record() helpers for common and per-CPU fields
Date: Tue, 25 Jun 2024 21:45:42 -0400 [thread overview]
Message-ID: <20240626014542.GC1086@yaz-khff2.amd.com> (raw)
In-Reply-To: <bbdf9caa-7c0f-44d1-a69d-a5cecc7cd4fa@suse.com>
On Tue, Jun 25, 2024 at 04:19:40PM +0300, Nikolay Borisov wrote:
[...]
> > +
> > +void mce_prep_record_per_cpu(unsigned int cpu, struct mce *m)
> > +{
> > + m->cpu = cpu;
> > + m->extcpu = cpu;
> > + m->apicid = cpu_data(m->extcpu).topo.initial_apicid;
> > + m->microcode = cpu_data(m->extcpu).microcode;
> > + m->ppin = cpu_data(m->extcpu).ppin;
>
> nit: Similar to tglx's feedback for patch 2 you could use topology_ppin()
>
> > + m->socketid = cpu_data(m->extcpu).topo.pkg_id;
> nit: topology_physical_package_id()
>
>
Yes, will update both.
Thanks,
Yazen
next prev parent reply other threads:[~2024-06-26 1:45 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-24 21:20 [PATCH v2 0/5] Rework mce_setup() Yazen Ghannam
2024-06-24 21:20 ` [PATCH v2 1/5] x86/topology: Export helper to get CPU number from APIC ID Yazen Ghannam
2024-06-25 6:50 ` Thomas Gleixner
2024-06-26 1:42 ` Yazen Ghannam
2024-06-28 8:37 ` Borislav Petkov
2024-06-28 14:15 ` Yazen Ghannam
2024-06-28 14:45 ` Borislav Petkov
2024-07-01 17:51 ` Yazen Ghannam
2024-07-01 19:07 ` Borislav Petkov
2024-07-12 14:28 ` Yazen Ghannam
2024-06-24 21:20 ` [PATCH v2 2/5] x86/mce: Fixup APIC ID search for x86 CPER decoding Yazen Ghannam
2024-06-25 6:50 ` Thomas Gleixner
2024-06-26 1:44 ` Yazen Ghannam
2024-06-24 21:20 ` [PATCH v2 3/5] x86/mce: Rename mce_setup() to mce_prep_record() Yazen Ghannam
2024-06-24 21:20 ` [PATCH v2 4/5] x86/mce: Define mce_prep_record() helpers for common and per-CPU fields Yazen Ghannam
2024-06-25 13:19 ` Nikolay Borisov
2024-06-26 1:45 ` Yazen Ghannam [this message]
2024-06-24 21:20 ` [PATCH v2 5/5] x86/mce: Use mce_prep_record() helpers for apei_smca_report_x86_error() Yazen Ghannam
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240626014542.GC1086@yaz-khff2.amd.com \
--to=yazen.ghannam@amd.com \
--cc=avadhut.naik@amd.com \
--cc=john.allen@amd.com \
--cc=linux-edac@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nik.borisov@suse.com \
--cc=tony.luck@intel.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox