From: Thomas Gleixner <tglx@linutronix.de>
To: Yazen Ghannam <yazen.ghannam@amd.com>, linux-edac@vger.kernel.org
Cc: linux-kernel@vger.kernel.org, tony.luck@intel.com,
x86@kernel.org, avadhut.naik@amd.com, john.allen@amd.com,
Yazen Ghannam <yazen.ghannam@amd.com>
Subject: Re: [PATCH v2 1/5] x86/topology: Export helper to get CPU number from APIC ID
Date: Tue, 25 Jun 2024 08:50:13 +0200 [thread overview]
Message-ID: <87ed8l7byy.ffs@tglx> (raw)
In-Reply-To: <20240624212008.663832-2-yazen.ghannam@amd.com>
On Mon, Jun 24 2024 at 16:20, Yazen Ghannam wrote:
> The need to look up a CPU number from an APIC ID is done in at least one
> other place outside of APIC/topology code:
> apei_smca_report_x86_error().
The need .... is done?
> #ifdef CONFIG_X86_LOCAL_APIC
> int topology_get_logical_id(u32 apicid, enum x86_topology_domains at_level);
> +int topology_get_cpunr(u32 apic_id);
> #else
> static inline int topology_get_logical_id(u32 apicid, enum x86_topology_domains at_level)
> {
> return 0;
> }
> +
> +static inline int topology_get_cpunr(u32 apic_id)
> +{
> + return -ENODEV;
Why ENODEV and not 0?
> +}
> #endif
Thanks,
tglx
next prev parent reply other threads:[~2024-06-25 6:50 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-24 21:20 [PATCH v2 0/5] Rework mce_setup() Yazen Ghannam
2024-06-24 21:20 ` [PATCH v2 1/5] x86/topology: Export helper to get CPU number from APIC ID Yazen Ghannam
2024-06-25 6:50 ` Thomas Gleixner [this message]
2024-06-26 1:42 ` Yazen Ghannam
2024-06-28 8:37 ` Borislav Petkov
2024-06-28 14:15 ` Yazen Ghannam
2024-06-28 14:45 ` Borislav Petkov
2024-07-01 17:51 ` Yazen Ghannam
2024-07-01 19:07 ` Borislav Petkov
2024-07-12 14:28 ` Yazen Ghannam
2024-06-24 21:20 ` [PATCH v2 2/5] x86/mce: Fixup APIC ID search for x86 CPER decoding Yazen Ghannam
2024-06-25 6:50 ` Thomas Gleixner
2024-06-26 1:44 ` Yazen Ghannam
2024-06-24 21:20 ` [PATCH v2 3/5] x86/mce: Rename mce_setup() to mce_prep_record() Yazen Ghannam
2024-06-24 21:20 ` [PATCH v2 4/5] x86/mce: Define mce_prep_record() helpers for common and per-CPU fields Yazen Ghannam
2024-06-25 13:19 ` Nikolay Borisov
2024-06-26 1:45 ` Yazen Ghannam
2024-06-24 21:20 ` [PATCH v2 5/5] x86/mce: Use mce_prep_record() helpers for apei_smca_report_x86_error() Yazen Ghannam
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87ed8l7byy.ffs@tglx \
--to=tglx@linutronix.de \
--cc=avadhut.naik@amd.com \
--cc=john.allen@amd.com \
--cc=linux-edac@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=tony.luck@intel.com \
--cc=x86@kernel.org \
--cc=yazen.ghannam@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox