From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Akash Kumar <quic_akakum@quicinc.com>
Cc: Thinh Nguyen <Thinh.Nguyen@synopsys.com>,
Jing Leng <jleng@ambarella.com>, Felipe Balbi <balbi@kernel.org>,
Jack Pham <quic_jackp@quicinc.com>,
kernel@quicinc.com, Wesley Cheng <quic_wcheng@quicinc.com>,
Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
Daniel Scally <dan.scally@ideasonboard.com>,
Vijayavardhan Vennapusa <quic_vvreddy@quicinc.com>,
Krishna Kurapati <quic_kriskura@quicinc.com>,
linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] usb: gadget: uvc: Add H264 frame format support
Date: Wed, 10 Jul 2024 13:51:44 +0200 [thread overview]
Message-ID: <2024071054-anatomist-purchase-1e98@gregkh> (raw)
In-Reply-To: <20240708041328.1942-1-quic_akakum@quicinc.com>
On Mon, Jul 08, 2024 at 09:43:28AM +0530, Akash Kumar wrote:
> Add support for framebased frame format which can be used to support
> multiple formats like H264 or H265 other than mjpeg and YUV frames.
>
> Framebased format is set to H264 by default, which can be updated to
> other formats by updating the GUID through guid configfs attribute.
>
> Signed-off-by: Akash Kumar <quic_akakum@quicinc.com>
> ---
> drivers/usb/gadget/function/uvc_configfs.c | 570 ++++++++++++++++++---
> drivers/usb/gadget/function/uvc_configfs.h | 34 +-
> drivers/usb/gadget/function/uvc_v4l2.c | 80 ++-
> include/uapi/linux/usb/video.h | 62 +++
> 4 files changed, 638 insertions(+), 108 deletions(-)
DOn't you need to add the new configfs entries to Documentation/ABI/?
And how is anyone going to know about this new api or format if there
are not new files? WHere is it now documented?
thanks,
greg k-h
next prev parent reply other threads:[~2024-07-10 11:51 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-08 4:13 [PATCH] usb: gadget: uvc: Add H264 frame format support Akash Kumar
2024-07-10 11:51 ` Greg Kroah-Hartman [this message]
2024-07-11 8:13 ` AKASH KUMAR
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2024071054-anatomist-purchase-1e98@gregkh \
--to=gregkh@linuxfoundation.org \
--cc=Thinh.Nguyen@synopsys.com \
--cc=balbi@kernel.org \
--cc=dan.scally@ideasonboard.com \
--cc=jleng@ambarella.com \
--cc=kernel@quicinc.com \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=quic_akakum@quicinc.com \
--cc=quic_jackp@quicinc.com \
--cc=quic_kriskura@quicinc.com \
--cc=quic_vvreddy@quicinc.com \
--cc=quic_wcheng@quicinc.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox