* [PATCH] driver:core: no need to set a default value for want_async
@ 2024-07-11 15:05 李哲
2024-07-11 15:13 ` Greg KH
0 siblings, 1 reply; 2+ messages in thread
From: 李哲 @ 2024-07-11 15:05 UTC (permalink / raw)
To: gregkh, rafael; +Cc: linux-kernel, 李哲
The default value of this member variable is false,
which is only set to true when asynchronous loading is required,
and does not need to be set to false during synchronization
Signed-off-by: 李哲 <sensor1010@163.com>
---
drivers/base/dd.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/base/dd.c b/drivers/base/dd.c
index d047919d1f5e..47351d98f6e1 100644
--- a/drivers/base/dd.c
+++ b/drivers/base/dd.c
@@ -1014,7 +1014,6 @@ static int __device_attach(struct device *dev, bool allow_async)
struct device_attach_data data = {
.dev = dev,
.check_async = allow_async,
- .want_async = false,
};
if (dev->parent)
--
2.17.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] driver:core: no need to set a default value for want_async
2024-07-11 15:05 [PATCH] driver:core: no need to set a default value for want_async 李哲
@ 2024-07-11 15:13 ` Greg KH
0 siblings, 0 replies; 2+ messages in thread
From: Greg KH @ 2024-07-11 15:13 UTC (permalink / raw)
To: 李哲; +Cc: rafael, linux-kernel
On Thu, Jul 11, 2024 at 08:05:45AM -0700, 李哲 wrote:
> The default value of this member variable is false,
> which is only set to true when asynchronous loading is required,
> and does not need to be set to false during synchronization
>
> Signed-off-by: 李哲 <sensor1010@163.com>
> ---
> drivers/base/dd.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/base/dd.c b/drivers/base/dd.c
> index d047919d1f5e..47351d98f6e1 100644
> --- a/drivers/base/dd.c
> +++ b/drivers/base/dd.c
> @@ -1014,7 +1014,6 @@ static int __device_attach(struct device *dev, bool allow_async)
> struct device_attach_data data = {
> .dev = dev,
> .check_async = allow_async,
> - .want_async = false,
This is good to keep as-is for documentation alone, it doesn't actually
change anything and makes it obvious.
thanks,
greg k-h
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2024-07-11 15:13 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-07-11 15:05 [PATCH] driver:core: no need to set a default value for want_async 李哲
2024-07-11 15:13 ` Greg KH
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox