* [PATCH] iommu: Move IOMMU_DIRTY_NO_CLEAR define
@ 2024-07-12 11:31 Shameer Kolothum
2024-07-12 12:45 ` Jason Gunthorpe
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Shameer Kolothum @ 2024-07-12 11:31 UTC (permalink / raw)
To: iommu, linux-kernel, will
Cc: robin.murphy, joro, jgg, ryan.roberts, kevin.tian, joao.m.martins,
linuxarm
Fixes the compile issue when CONFIG_IOMMU_API is not set.
Fixes: 4fe88fd8b4ae ("iommu/io-pgtable-arm: Add read_and_clear_dirty() support")
Reported-by: kernel test robot <lkp@intel.com>
Closes: https://lore.kernel.org/oe-kbuild-all/202407121602.HL9ih1it-lkp@intel.com/
Signed-off-by: Shameer Kolothum <shameerali.kolothum.thodi@huawei.com>
---
include/linux/iommu.h | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/include/linux/iommu.h b/include/linux/iommu.h
index 7bc8dff7cf6d..104ce84647d4 100644
--- a/include/linux/iommu.h
+++ b/include/linux/iommu.h
@@ -317,6 +317,9 @@ enum iommu_dev_features {
#define IOMMU_PASID_INVALID (-1U)
typedef unsigned int ioasid_t;
+/* Read but do not clear any dirty bits */
+#define IOMMU_DIRTY_NO_CLEAR (1 << 0)
+
#ifdef CONFIG_IOMMU_API
/**
@@ -353,9 +356,6 @@ struct iommu_dirty_bitmap {
struct iommu_iotlb_gather *gather;
};
-/* Read but do not clear any dirty bits */
-#define IOMMU_DIRTY_NO_CLEAR (1 << 0)
-
/**
* struct iommu_dirty_ops - domain specific dirty tracking operations
* @set_dirty_tracking: Enable or Disable dirty tracking on the iommu domain
--
2.34.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] iommu: Move IOMMU_DIRTY_NO_CLEAR define
2024-07-12 11:31 [PATCH] iommu: Move IOMMU_DIRTY_NO_CLEAR define Shameer Kolothum
@ 2024-07-12 12:45 ` Jason Gunthorpe
2024-07-12 15:16 ` Joao Martins
2024-07-12 15:44 ` Will Deacon
2 siblings, 0 replies; 4+ messages in thread
From: Jason Gunthorpe @ 2024-07-12 12:45 UTC (permalink / raw)
To: Shameer Kolothum
Cc: iommu, linux-kernel, will, robin.murphy, joro, ryan.roberts,
kevin.tian, joao.m.martins, linuxarm
On Fri, Jul 12, 2024 at 12:31:32PM +0100, Shameer Kolothum wrote:
> Fixes the compile issue when CONFIG_IOMMU_API is not set.
>
> Fixes: 4fe88fd8b4ae ("iommu/io-pgtable-arm: Add read_and_clear_dirty() support")
> Reported-by: kernel test robot <lkp@intel.com>
> Closes: https://lore.kernel.org/oe-kbuild-all/202407121602.HL9ih1it-lkp@intel.com/
> Signed-off-by: Shameer Kolothum <shameerali.kolothum.thodi@huawei.com>
> ---
> include/linux/iommu.h | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
Reviewed-by: Jason Gunthorpe <jgg@nvidia.com>
Jason
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] iommu: Move IOMMU_DIRTY_NO_CLEAR define
2024-07-12 11:31 [PATCH] iommu: Move IOMMU_DIRTY_NO_CLEAR define Shameer Kolothum
2024-07-12 12:45 ` Jason Gunthorpe
@ 2024-07-12 15:16 ` Joao Martins
2024-07-12 15:44 ` Will Deacon
2 siblings, 0 replies; 4+ messages in thread
From: Joao Martins @ 2024-07-12 15:16 UTC (permalink / raw)
To: Shameer Kolothum
Cc: robin.murphy, joro, jgg, ryan.roberts, kevin.tian, linuxarm,
linux-kernel, iommu, will
On 12/07/2024 12:31, Shameer Kolothum wrote:
> Fixes the compile issue when CONFIG_IOMMU_API is not set.
>
> Fixes: 4fe88fd8b4ae ("iommu/io-pgtable-arm: Add read_and_clear_dirty() support")
> Reported-by: kernel test robot <lkp@intel.com>
> Closes: https://lore.kernel.org/oe-kbuild-all/202407121602.HL9ih1it-lkp@intel.com/
> Signed-off-by: Shameer Kolothum <shameerali.kolothum.thodi@huawei.com>
Reviewed-by: Joao Martins <joao.m.martins@oracle.com>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] iommu: Move IOMMU_DIRTY_NO_CLEAR define
2024-07-12 11:31 [PATCH] iommu: Move IOMMU_DIRTY_NO_CLEAR define Shameer Kolothum
2024-07-12 12:45 ` Jason Gunthorpe
2024-07-12 15:16 ` Joao Martins
@ 2024-07-12 15:44 ` Will Deacon
2 siblings, 0 replies; 4+ messages in thread
From: Will Deacon @ 2024-07-12 15:44 UTC (permalink / raw)
To: iommu, linux-kernel, Shameer Kolothum
Cc: catalin.marinas, kernel-team, Will Deacon, robin.murphy, joro,
ryan.roberts, kevin.tian, joao.m.martins, linuxarm,
Jason Gunthorpe
On Fri, 12 Jul 2024 12:31:32 +0100, Shameer Kolothum wrote:
> Fixes the compile issue when CONFIG_IOMMU_API is not set.
>
>
Applied to iommu (arm/smmu), thanks!
[1/1] iommu: Move IOMMU_DIRTY_NO_CLEAR define
https://git.kernel.org/iommu/c/9b2bc6b9a264
Cheers,
--
Will
https://fixes.arm64.dev
https://next.arm64.dev
https://will.arm64.dev
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2024-07-12 15:44 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-07-12 11:31 [PATCH] iommu: Move IOMMU_DIRTY_NO_CLEAR define Shameer Kolothum
2024-07-12 12:45 ` Jason Gunthorpe
2024-07-12 15:16 ` Joao Martins
2024-07-12 15:44 ` Will Deacon
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox