* [PATCH] drm/msm/adreno: Fix error return if missing firmware-name
@ 2024-07-16 16:06 Rob Clark
2024-07-16 16:49 ` Dmitry Baryshkov
2024-07-16 21:46 ` Akhil P Oommen
0 siblings, 2 replies; 3+ messages in thread
From: Rob Clark @ 2024-07-16 16:06 UTC (permalink / raw)
To: dri-devel
Cc: linux-arm-msm, freedreno, Dmitry Baryshkov, Rob Clark, Rob Clark,
Sean Paul, Konrad Dybcio, Abhinav Kumar, Marijn Suijten,
David Airlie, Daniel Vetter, open list
From: Rob Clark <robdclark@chromium.org>
-ENODEV is used to signify that there is no zap shader for the platform,
and the CPU can directly take the GPU out of secure mode. We want to
use this return code when there is no zap-shader node. But not when
there is, but without a firmware-name property. This case we want to
treat as-if the needed fw is not found.
Signed-off-by: Rob Clark <robdclark@chromium.org>
---
drivers/gpu/drm/msm/adreno/adreno_gpu.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/msm/adreno/adreno_gpu.c b/drivers/gpu/drm/msm/adreno/adreno_gpu.c
index b46e7e93b3ed..0d84be3be0b7 100644
--- a/drivers/gpu/drm/msm/adreno/adreno_gpu.c
+++ b/drivers/gpu/drm/msm/adreno/adreno_gpu.c
@@ -99,7 +99,7 @@ static int zap_shader_load_mdt(struct msm_gpu *gpu, const char *fwname,
* was a bad idea, and is only provided for backwards
* compatibility for older targets.
*/
- return -ENODEV;
+ return -ENOENT;
}
if (IS_ERR(fw)) {
--
2.45.2
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] drm/msm/adreno: Fix error return if missing firmware-name
2024-07-16 16:06 [PATCH] drm/msm/adreno: Fix error return if missing firmware-name Rob Clark
@ 2024-07-16 16:49 ` Dmitry Baryshkov
2024-07-16 21:46 ` Akhil P Oommen
1 sibling, 0 replies; 3+ messages in thread
From: Dmitry Baryshkov @ 2024-07-16 16:49 UTC (permalink / raw)
To: Rob Clark
Cc: dri-devel, linux-arm-msm, freedreno, Rob Clark, Sean Paul,
Konrad Dybcio, Abhinav Kumar, Marijn Suijten, David Airlie,
Daniel Vetter, open list
On Tue, Jul 16, 2024 at 09:06:30AM GMT, Rob Clark wrote:
> From: Rob Clark <robdclark@chromium.org>
>
> -ENODEV is used to signify that there is no zap shader for the platform,
> and the CPU can directly take the GPU out of secure mode. We want to
> use this return code when there is no zap-shader node. But not when
> there is, but without a firmware-name property. This case we want to
> treat as-if the needed fw is not found.
>
> Signed-off-by: Rob Clark <robdclark@chromium.org>
> ---
> drivers/gpu/drm/msm/adreno/adreno_gpu.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
--
With best wishes
Dmitry
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] drm/msm/adreno: Fix error return if missing firmware-name
2024-07-16 16:06 [PATCH] drm/msm/adreno: Fix error return if missing firmware-name Rob Clark
2024-07-16 16:49 ` Dmitry Baryshkov
@ 2024-07-16 21:46 ` Akhil P Oommen
1 sibling, 0 replies; 3+ messages in thread
From: Akhil P Oommen @ 2024-07-16 21:46 UTC (permalink / raw)
To: Rob Clark
Cc: dri-devel, linux-arm-msm, freedreno, Dmitry Baryshkov, Rob Clark,
Sean Paul, Konrad Dybcio, Abhinav Kumar, Marijn Suijten,
David Airlie, Daniel Vetter, open list
On Tue, Jul 16, 2024 at 09:06:30AM -0700, Rob Clark wrote:
> From: Rob Clark <robdclark@chromium.org>
>
> -ENODEV is used to signify that there is no zap shader for the platform,
> and the CPU can directly take the GPU out of secure mode. We want to
> use this return code when there is no zap-shader node. But not when
> there is, but without a firmware-name property. This case we want to
> treat as-if the needed fw is not found.
>
> Signed-off-by: Rob Clark <robdclark@chromium.org>
> ---
Reviewed-by: Akhil P Oommen <quic_akhilpo@quicinc.com>
-Akhil
> drivers/gpu/drm/msm/adreno/adreno_gpu.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/msm/adreno/adreno_gpu.c b/drivers/gpu/drm/msm/adreno/adreno_gpu.c
> index b46e7e93b3ed..0d84be3be0b7 100644
> --- a/drivers/gpu/drm/msm/adreno/adreno_gpu.c
> +++ b/drivers/gpu/drm/msm/adreno/adreno_gpu.c
> @@ -99,7 +99,7 @@ static int zap_shader_load_mdt(struct msm_gpu *gpu, const char *fwname,
> * was a bad idea, and is only provided for backwards
> * compatibility for older targets.
> */
> - return -ENODEV;
> + return -ENOENT;
> }
>
> if (IS_ERR(fw)) {
> --
> 2.45.2
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2024-07-16 21:46 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-07-16 16:06 [PATCH] drm/msm/adreno: Fix error return if missing firmware-name Rob Clark
2024-07-16 16:49 ` Dmitry Baryshkov
2024-07-16 21:46 ` Akhil P Oommen
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox