* [PATCH] kbuild: Fix broken "make binrpm-pkg"
@ 2024-07-24 12:59 Juergen Gross
2024-07-24 13:03 ` Sedat Dilek
0 siblings, 1 reply; 2+ messages in thread
From: Juergen Gross @ 2024-07-24 12:59 UTC (permalink / raw)
To: linux-kernel, linux-kbuild
Cc: Juergen Gross, Masahiro Yamada, Nathan Chancellor, Nicolas Schier
Due to a typo "make binrpm-pkg" isn't working when using e.g. german
locale. rpmbuild will tell me:
error: bad date in %changelog: Mi Jul 24 2024 Juergen Gross <jgross@suse.com>
Reason is that setting "LC_ALL=C" must not be followed by a semicolon
in order to affect the following "date" command.
Fixes: 301c10908e42 ("kbuild: rpm-pkg: introduce a simple changelog section for kernel.spec")
Signed-off-by: Juergen Gross <jgross@suse.com>
---
scripts/package/mkspec | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/scripts/package/mkspec b/scripts/package/mkspec
index ead54d67a024..4dc1466dfc81 100755
--- a/scripts/package/mkspec
+++ b/scripts/package/mkspec
@@ -50,6 +50,6 @@ fi
cat << EOF
%changelog
-* $(LC_ALL=C; date +'%a %b %d %Y') ${name} <${email}>
+* $(LC_ALL=C date +'%a %b %d %Y') ${name} <${email}>
- Custom built Linux kernel.
EOF
--
2.43.0
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH] kbuild: Fix broken "make binrpm-pkg"
2024-07-24 12:59 [PATCH] kbuild: Fix broken "make binrpm-pkg" Juergen Gross
@ 2024-07-24 13:03 ` Sedat Dilek
0 siblings, 0 replies; 2+ messages in thread
From: Sedat Dilek @ 2024-07-24 13:03 UTC (permalink / raw)
To: Juergen Gross
Cc: linux-kernel, linux-kbuild, Masahiro Yamada, Nathan Chancellor,
Nicolas Schier
On Wed, Jul 24, 2024 at 2:59 PM Juergen Gross <jgross@suse.com> wrote:
>
> Due to a typo "make binrpm-pkg" isn't working when using e.g. german
> locale. rpmbuild will tell me:
>
> error: bad date in %changelog: Mi Jul 24 2024 Juergen Gross <jgross@suse.com>
>
> Reason is that setting "LC_ALL=C" must not be followed by a semicolon
> in order to affect the following "date" command.
>
> Fixes: 301c10908e42 ("kbuild: rpm-pkg: introduce a simple changelog section for kernel.spec")
> Signed-off-by: Juergen Gross <jgross@suse.com>
> ---
> scripts/package/mkspec | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/scripts/package/mkspec b/scripts/package/mkspec
> index ead54d67a024..4dc1466dfc81 100755
> --- a/scripts/package/mkspec
> +++ b/scripts/package/mkspec
> @@ -50,6 +50,6 @@ fi
> cat << EOF
>
> %changelog
> -* $(LC_ALL=C; date +'%a %b %d %Y') ${name} <${email}>
> +* $(LC_ALL=C date +'%a %b %d %Y') ${name} <${email}>
> - Custom built Linux kernel.
> EOF
> --
> 2.43.0
>
>
Fixed in kbuild.git#fixes
https://git.kernel.org/pub/scm/linux/kernel/git/masahiroy/linux-kbuild.git/log/?h=fixes
https://git.kernel.org/pub/scm/linux/kernel/git/masahiroy/linux-kbuild.git/commit/?h=fixes&id=ba6c664081afd18da86ac49cb22ceb266f89a561
-Sedat-
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2024-07-24 13:04 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-07-24 12:59 [PATCH] kbuild: Fix broken "make binrpm-pkg" Juergen Gross
2024-07-24 13:03 ` Sedat Dilek
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox