* [PATCH] staging: rtl8192e: remove duplicate macros from rtllib.h
@ 2024-07-30 8:29 Michael Straube
2024-07-31 5:11 ` Philipp Hortmann
0 siblings, 1 reply; 2+ messages in thread
From: Michael Straube @ 2024-07-30 8:29 UTC (permalink / raw)
To: gregkh; +Cc: philipp.g.hortmann, linux-staging, linux-kernel, Michael Straube
These macros just duplicate macros from include/linux/ieee80211.h.
We can safely remove them from rtllib.h.
Signed-off-by: Michael Straube <straube.linux@gmail.com>
---
compile-tested only
drivers/staging/rtl8192e/rtllib.h | 11 -----------
1 file changed, 11 deletions(-)
diff --git a/drivers/staging/rtl8192e/rtllib.h b/drivers/staging/rtl8192e/rtllib.h
index 022851b7f1a9..e87313a30741 100644
--- a/drivers/staging/rtl8192e/rtllib.h
+++ b/drivers/staging/rtl8192e/rtllib.h
@@ -414,17 +414,6 @@ enum _REG_PREAMBLE_MODE {
#define WLAN_GET_SEQ_FRAG(seq) ((seq) & RTLLIB_SCTL_FRAG)
#define WLAN_GET_SEQ_SEQ(seq) (((seq) & RTLLIB_SCTL_SEQ) >> 4)
-/* Authentication algorithms */
-#define WLAN_AUTH_OPEN 0
-#define WLAN_AUTH_SHARED_KEY 1
-#define WLAN_AUTH_LEAP 128
-
-#define WLAN_CAPABILITY_ESS (1<<0)
-#define WLAN_CAPABILITY_IBSS (1<<1)
-#define WLAN_CAPABILITY_PRIVACY (1<<4)
-#define WLAN_CAPABILITY_SHORT_PREAMBLE (1<<5)
-#define WLAN_CAPABILITY_SHORT_SLOT_TIME (1<<10)
-
#define RTLLIB_STATMASK_SIGNAL (1<<0)
#define RTLLIB_STATMASK_RSSI (1<<1)
#define RTLLIB_STATMASK_NOISE (1<<2)
--
2.45.2
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] staging: rtl8192e: remove duplicate macros from rtllib.h
2024-07-30 8:29 [PATCH] staging: rtl8192e: remove duplicate macros from rtllib.h Michael Straube
@ 2024-07-31 5:11 ` Philipp Hortmann
0 siblings, 0 replies; 2+ messages in thread
From: Philipp Hortmann @ 2024-07-31 5:11 UTC (permalink / raw)
To: Michael Straube, gregkh; +Cc: linux-staging, linux-kernel
On 7/30/24 10:29, Michael Straube wrote:
> These macros just duplicate macros from include/linux/ieee80211.h.
> We can safely remove them from rtllib.h.
>
> Signed-off-by: Michael Straube <straube.linux@gmail.com>
> ---
> compile-tested only
>
> drivers/staging/rtl8192e/rtllib.h | 11 -----------
> 1 file changed, 11 deletions(-)
>
> diff --git a/drivers/staging/rtl8192e/rtllib.h b/drivers/staging/rtl8192e/rtllib.h
> index 022851b7f1a9..e87313a30741 100644
> --- a/drivers/staging/rtl8192e/rtllib.h
> +++ b/drivers/staging/rtl8192e/rtllib.h
> @@ -414,17 +414,6 @@ enum _REG_PREAMBLE_MODE {
> #define WLAN_GET_SEQ_FRAG(seq) ((seq) & RTLLIB_SCTL_FRAG)
> #define WLAN_GET_SEQ_SEQ(seq) (((seq) & RTLLIB_SCTL_SEQ) >> 4)
>
> -/* Authentication algorithms */
> -#define WLAN_AUTH_OPEN 0
> -#define WLAN_AUTH_SHARED_KEY 1
> -#define WLAN_AUTH_LEAP 128
> -
> -#define WLAN_CAPABILITY_ESS (1<<0)
> -#define WLAN_CAPABILITY_IBSS (1<<1)
> -#define WLAN_CAPABILITY_PRIVACY (1<<4)
> -#define WLAN_CAPABILITY_SHORT_PREAMBLE (1<<5)
> -#define WLAN_CAPABILITY_SHORT_SLOT_TIME (1<<10)
> -
> #define RTLLIB_STATMASK_SIGNAL (1<<0)
> #define RTLLIB_STATMASK_RSSI (1<<1)
> #define RTLLIB_STATMASK_NOISE (1<<2)
Tested-by: Philipp Hortmann <philipp.g.hortmann@gmail.com>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2024-07-31 5:11 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-07-30 8:29 [PATCH] staging: rtl8192e: remove duplicate macros from rtllib.h Michael Straube
2024-07-31 5:11 ` Philipp Hortmann
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox