From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Sean Whitton <spwhitton@spwhitton.name>
Cc: ~lkcamp/patches@lists.sr.ht, helen.koike@collabora.com,
Hans de Goede <hdegoede@redhat.com>,
Mauro Carvalho Chehab <mchehab@kernel.org>,
Sakari Ailus <sakari.ailus@linux.intel.com>,
linux-media@vger.kernel.org, linux-staging@lists.linux.dev,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] staging: media: atomisp: Add parentheses around macro definitions
Date: Tue, 30 Jul 2024 08:38:51 +0200 [thread overview]
Message-ID: <2024073020-reload-vanquish-f937@gregkh> (raw)
In-Reply-To: <20240730062348.46205-2-spwhitton@spwhitton.name>
On Tue, Jul 30, 2024 at 03:23:45PM +0900, Sean Whitton wrote:
> Fix checkpatch error
> "ERROR: Macros with complex values should be enclosed in parentheses"
> at hive_isp_css_include/sp.h:41, hive_isp_css_include/sp.h:42.
>
> Signed-off-by: Sean Whitton <spwhitton@spwhitton.name>
> ---
> drivers/staging/media/atomisp/pci/hive_isp_css_include/sp.h | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> This is my first Linux kernel patch, from Helen Koike's DebConf24 workshop.
> Thanks!
>
> diff --git a/drivers/staging/media/atomisp/pci/hive_isp_css_include/sp.h b/drivers/staging/media/atomisp/pci/hive_isp_css_include/sp.h
> index a7d00c7bb8bc..128109afe842 100644
> --- a/drivers/staging/media/atomisp/pci/hive_isp_css_include/sp.h
> +++ b/drivers/staging/media/atomisp/pci/hive_isp_css_include/sp.h
> @@ -38,8 +38,8 @@
> #define STORAGE_CLASS_SP_C
> #include "sp_public.h"
> #else /* __INLINE_SP__ */
> -#define STORAGE_CLASS_SP_H static inline
> -#define STORAGE_CLASS_SP_C static inline
> +#define STORAGE_CLASS_SP_H (static inline)
> +#define STORAGE_CLASS_SP_C (static inline)
This isn't a "complex values", and really should just be removed
entirely and use the correct "static inline" properly.
thanks,
greg k-h
next prev parent reply other threads:[~2024-07-30 6:38 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-30 6:23 [PATCH] staging: media: atomisp: Add parentheses around macro definitions Sean Whitton
2024-07-30 6:38 ` Greg Kroah-Hartman [this message]
2024-08-03 3:28 ` Sean Whitton
2024-08-03 4:28 ` Dan Carpenter
2024-08-03 5:33 ` Sean Whitton
2024-08-03 6:10 ` Dan Carpenter
2024-08-04 3:36 ` Sean Whitton
2024-07-30 14:43 ` Dan Carpenter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2024073020-reload-vanquish-f937@gregkh \
--to=gregkh@linuxfoundation.org \
--cc=hdegoede@redhat.com \
--cc=helen.koike@collabora.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=mchehab@kernel.org \
--cc=sakari.ailus@linux.intel.com \
--cc=spwhitton@spwhitton.name \
--cc=~lkcamp/patches@lists.sr.ht \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox