From: Sean Whitton <spwhitton@spwhitton.name>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: ~lkcamp/patches@lists.sr.ht, helen.koike@collabora.com,
Hans de Goede <hdegoede@redhat.com>,
Mauro Carvalho Chehab <mchehab@kernel.org>,
Sakari Ailus <sakari.ailus@linux.intel.com>,
linux-media@vger.kernel.org, linux-staging@lists.linux.dev,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] staging: media: atomisp: Add parentheses around macro definitions
Date: Sat, 03 Aug 2024 11:28:02 +0800 [thread overview]
Message-ID: <87v80i475p.fsf@melete.silentflame.com> (raw)
In-Reply-To: <2024073020-reload-vanquish-f937@gregkh> (Greg Kroah-Hartman's message of "Tue, 30 Jul 2024 08:38:51 +0200")
Hello,
On Tue 30 Jul 2024 at 08:38am +02, Greg Kroah-Hartman wrote:
> This isn't a "complex values", and really should just be removed
> entirely and use the correct "static inline" properly.
I found that there are several headers in
atomisp/pci/hive_isp_css_include which have this pattern of defining an
_INLINE_*_ preprocessor constant, and using it to choose between
'extern' and 'static inline' in each file where the header is included.
I don't know what the author's intention was. Are you saying that you
think this preprocessor mechanism should just be replaced with
hardcoding 'extern' or 'static inline' in each file which includes one
of these headers?
Thanks!
--
Sean Whitton
next prev parent reply other threads:[~2024-08-03 3:29 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-30 6:23 [PATCH] staging: media: atomisp: Add parentheses around macro definitions Sean Whitton
2024-07-30 6:38 ` Greg Kroah-Hartman
2024-08-03 3:28 ` Sean Whitton [this message]
2024-08-03 4:28 ` Dan Carpenter
2024-08-03 5:33 ` Sean Whitton
2024-08-03 6:10 ` Dan Carpenter
2024-08-04 3:36 ` Sean Whitton
2024-07-30 14:43 ` Dan Carpenter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87v80i475p.fsf@melete.silentflame.com \
--to=spwhitton@spwhitton.name \
--cc=gregkh@linuxfoundation.org \
--cc=hdegoede@redhat.com \
--cc=helen.koike@collabora.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=mchehab@kernel.org \
--cc=sakari.ailus@linux.intel.com \
--cc=~lkcamp/patches@lists.sr.ht \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox