[PATCH] staging: media: atomisp: remove trailing statement

[PATCH] staging: media: atomisp: remove trailing statement

[Sai Sree Kartheek Adivi]

this patch fixes the following checkpatch.pl error..
ERROR: trailing statements should be on next line
#48: FILE: drivers/staging/media/atomisp/pci/isp/kernels/anr/anr_1.0/ia_css_anr.host.c:48:
+	if (!anr) return;

Signed-off-by: Sai Sree Kartheek Adivi <sskartheekadivi@gmail.com>
---
Just started contributing to the kernel. please help me understand my
mistakes if any.

 .../atomisp/pci/isp/kernels/anr/anr_1.0/ia_css_anr.host.c      | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/staging/media/atomisp/pci/isp/kernels/anr/anr_1.0/ia_css_anr.host.c b/drivers/staging/media/atomisp/pci/isp/kernels/anr/anr_1.0/ia_css_anr.host.c
index 3f079c954..73364a65f 100644
--- a/drivers/staging/media/atomisp/pci/isp/kernels/anr/anr_1.0/ia_css_anr.host.c
+++ b/drivers/staging/media/atomisp/pci/isp/kernels/anr/anr_1.0/ia_css_anr.host.c
@@ -45,7 +45,8 @@ ia_css_anr_dump(
     const struct sh_css_isp_anr_params *anr,
     unsigned int level)
 {
-	if (!anr) return;
+	if (!anr)
+		return;
 	ia_css_debug_dtrace(level, "Advance Noise Reduction:\n");
 	ia_css_debug_dtrace(level, "\t%-32s = %d\n",
 			    "anr_threshold", anr->threshold);
-- 
2.20.1

Re: [PATCH] staging: media: atomisp: remove trailing statement

[Greg Kroah-Hartman]

On Tue, Jul 30, 2024 at 07:18:08AM +0000, Sai Sree Kartheek Adivi wrote:
> this patch fixes the following checkpatch.pl error..
> ERROR: trailing statements should be on next line
> #48: FILE: drivers/staging/media/atomisp/pci/isp/kernels/anr/anr_1.0/ia_css_anr.host.c:48:
> +	if (!anr) return;
> 
> Signed-off-by: Sai Sree Kartheek Adivi <sskartheekadivi@gmail.com>
> ---
> Just started contributing to the kernel. please help me understand my
> mistakes if any.

Please use scripts/get_maintainer.pl to determine who to send this
change to (hint, you didn't catch the maintainers of this file...)

thanks,

greg k-h

Re: [PATCH] staging: media: atomisp: remove trailing statement

[Dan Carpenter]

On Tue, Jul 30, 2024 at 07:18:08AM +0000, Sai Sree Kartheek Adivi wrote:
> this patch fixes the following checkpatch.pl error..
> ERROR: trailing statements should be on next line
> #48: FILE: drivers/staging/media/atomisp/pci/isp/kernels/anr/anr_1.0/ia_css_anr.host.c:48:
> +	if (!anr) return;
> 
> Signed-off-by: Sai Sree Kartheek Adivi <sskartheekadivi@gmail.com>
> ---
> Just started contributing to the kernel. please help me understand my
> mistakes if any.
> 

Reviewed-by: Dan Carpenter <dan.carpenter@linaro.org>

regards,
dan carpenter