答复: 答复: 答复: [PATCH v2] usb: gadget: uvc: Fixes the abnormal enumeration problem of mobile phone as UVC camera.

答复: 答复: 答复: [PATCH v2] usb: gadget: uvc: Fixes the abnormal enumeration problem of mobile phone as UVC camera.

[胡连勤]

Hello linux community expert:

I see no "Fixes:" tag here :(
 ----- Modify the email title Fixed -> Fixes

From the previous communication, the following message seems not to be placed in the body of the email, 
so I changed the title of the email to it, so there is - Modify "Fixes:" tag on the commit.

usb: gadget: uvc: Fixes the abnormal enumeration problem of mobile phone as UVC camera.

Thanks

-----邮件原件-----
发件人: gregkh@linuxfoundation.org <gregkh@linuxfoundation.org> 
发送时间: 2024年7月31日 17:49
收件人: 胡连勤 <hulianqin@vivo.com>
抄送: akpm@linux-foundation.org; linux-kernel@vger.kernel.org; opensource.kernel <opensource.kernel@vivo.com>
主题: Re: 答复: 答复: [PATCH v2] usb: gadget: uvc: Fixed the abnormal enumeration problem of mobile phone as UVC camera.

On Wed, Jul 31, 2024 at 09:39:16AM +0000, 胡连勤 wrote:
> When the phone is connected to the computer to use the webcam 
> function, the phone needs to be enumerated as a uvc camera function.
> 
> Because uvc->func.bind_deactivated is configured as true in the f_uvc 
> driver uvc_alloc function, the usb_gadget_deactivate function is 
> called during the execution of the configfs_composite_bind function to 
> set gadget->deactivated to true, which in turn causes the 
> usb_gadget_connect_locked function to fail to call the corresponding 
> controller pullup operation (such as: dwc3_gadget_pullup, 
> mtu3_gadget_pullup), and the USB cannot be enumerated normally under 
> the uvc function combination.
> 
> After applying this patch, we measured that under the uvc function, 
> the dwc3 controller and the mtu3 controller can be enumerated 
> normally, and the webcam function is normal.
> 
> Therefore, modify the f_uvc driver to remove the operation of setting
> uvc->func.bind_deactivated to true.
> 
> Signed-off-by: Lianqin Hu <hulianqin@vivo.com>
> ---
> v2:
>   - Modify "Fixes:" tag on the commit
>   - Modify description information.

I see no "Fixes:" tag here :(

Re: 答复: 答复: 答复: [PATCH v2] usb: gadget: uvc: Fixes the abnormal enumeration problem of mobile phone as UVC camera.

[gregkh]

A: http://en.wikipedia.org/wiki/Top_post
Q: Were do I find info about this thing called top-posting?
A: Because it messes up the order in which people normally read text.
Q: Why is top-posting such a bad thing?
A: Top-posting.
Q: What is the most annoying thing in e-mail?

A: No.
Q: Should I include quotations after my reply?

http://daringfireball.net/2007/07/on_top

On Wed, Jul 31, 2024 at 10:01:45AM +0000, 胡连勤 wrote:
> Hello linux community expert:
> 
> I see no "Fixes:" tag here :(
>  ----- Modify the email title Fixed -> Fixes

Please read the kernel documentation for how to mark something with a
Fixes tag correctly.

thanks,

greg k-h