public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Willy Tarreau <w@1wt.eu>
To: "Thomas Weißschuh" <linux@weissschuh.net>
Cc: Shuah Khan <shuah@kernel.org>,
	linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org
Subject: Re: [PATCH 03/12] tools/nolibc: move entrypoint specifics to compiler.h
Date: Sat, 3 Aug 2024 11:22:04 +0200	[thread overview]
Message-ID: <20240803092204.GA29127@1wt.eu> (raw)
In-Reply-To: <20240728-nolibc-llvm-v1-3-bc384269bc35@weissschuh.net>

Hi Thomas,

On Sun, Jul 28, 2024 at 12:09:57PM +0200, Thomas Weißschuh wrote:
> The specific attributes for the _start entrypoint are duplicated for
> each architecture.
> Deduplicate it into a dedicated #define into compiler.h.
> This make the code shorter and will make it easier to adapt for clang
> compatibility.
> 
> For clang compatibility, the epilogue will also need to be adapted, so
> move that one, too.

I'm fine with the general approach, however I think that if we start to
add specific attributes and macros like this, we should prefix them with
"nolibc" to make sure they won't collide with userland.

Thanks,
willy

  reply	other threads:[~2024-08-03  9:29 UTC|newest]

Thread overview: 30+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-07-28 10:09 [PATCH 00/12] tools/nolibc: improve LLVM/clang support Thomas Weißschuh
2024-07-28 10:09 ` [PATCH 01/12] tools/nolibc: use clang-compatible asm syntax in arch-arm.h Thomas Weißschuh
2024-07-28 10:09 ` [PATCH 02/12] tools/nolibc: limit powerpc stack-protector workaround to GCC Thomas Weißschuh
2024-07-28 10:09 ` [PATCH 03/12] tools/nolibc: move entrypoint specifics to compiler.h Thomas Weißschuh
2024-08-03  9:22   ` Willy Tarreau [this message]
2024-08-03 18:26     ` Thomas Weißschuh 
2024-07-28 10:09 ` [PATCH 04/12] tools/nolibc: use attribute((naked)) if available Thomas Weißschuh
2024-08-03  9:25   ` Willy Tarreau
2024-08-03 18:28     ` Thomas Weißschuh 
2024-08-03 18:32       ` Willy Tarreau
2024-08-03 20:55         ` Thomas Weißschuh 
2024-08-04  3:47           ` Willy Tarreau
2024-07-28 10:09 ` [PATCH 05/12] selftests/nolibc: report failure if no testcase passed Thomas Weißschuh
2024-07-28 10:10 ` [PATCH 06/12] selftests/nolibc: avoid passing NULL to printf("%s") Thomas Weißschuh
2024-08-03  9:33   ` Willy Tarreau
2024-08-03 18:29     ` Thomas Weißschuh 
2024-08-03 18:33       ` Willy Tarreau
2024-07-28 10:10 ` [PATCH 07/12] selftests/nolibc: determine $(srctree) first Thomas Weißschuh
2024-08-03  9:40   ` Willy Tarreau
2024-08-04 15:55     ` Thomas Weißschuh
2024-07-28 10:10 ` [PATCH 08/12] selftests/nolibc: setup objtree without Makefile.include Thomas Weißschuh
2024-07-28 10:10 ` [PATCH 09/12] selftests/nolibc: add support for LLVM= parameter Thomas Weißschuh
2024-08-03  9:45   ` Willy Tarreau
2024-08-04 15:59     ` Thomas Weißschuh
2024-07-28 10:10 ` [PATCH 10/12] selftests/nolibc: add cc-option compatible with clang cross builds Thomas Weißschuh
2024-07-28 10:10 ` [PATCH 11/12] selftests/nolibc: run-tests.sh: avoid overwriting CFLAGS_EXTRA Thomas Weißschuh
2024-07-28 10:10 ` [PATCH 12/12] selftests/nolibc: run-tests.sh: allow building through LLVM Thomas Weißschuh
2024-07-29 19:26 ` [PATCH 00/12] tools/nolibc: improve LLVM/clang support Shuah Khan
2024-07-29 19:27   ` Shuah Khan
2024-08-03  9:50 ` Willy Tarreau

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240803092204.GA29127@1wt.eu \
    --to=w@1wt.eu \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-kselftest@vger.kernel.org \
    --cc=linux@weissschuh.net \
    --cc=shuah@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox