* Re: [PATCH 6.1 00/86] 6.1.104-rc1 review
2024-08-07 14:59 [PATCH 6.1 00/86] 6.1.104-rc1 review Greg Kroah-Hartman
@ 2024-08-07 17:32 ` Pavel Machek
2024-08-07 17:42 ` Mark Brown
` (4 subsequent siblings)
5 siblings, 0 replies; 12+ messages in thread
From: Pavel Machek @ 2024-08-07 17:32 UTC (permalink / raw)
To: Greg Kroah-Hartman
Cc: stable, patches, linux-kernel, torvalds, akpm, linux, shuah,
patches, lkft-triage, pavel, jonathanh, f.fainelli,
sudipm.mukherjee, srw, rwarsow, conor, allen.lkml, broonie
[-- Attachment #1: Type: text/plain, Size: 659 bytes --]
Hi!
> This is the start of the stable review cycle for the 6.1.104 release.
> There are 86 patches in this series, all will be posted as a response
> to this one. If anyone has any issues with these being applied, please
> let me know.
CIP testing did not find any problems here:
https://gitlab.com/cip-project/cip-testing/linux-stable-rc-ci/-/tree/linux-6.1.y
Tested-by: Pavel Machek (CIP) <pavel@denx.de>
Best regards,
Pavel
--
DENX Software Engineering GmbH, Managing Director: Erika Unter
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 195 bytes --]
^ permalink raw reply [flat|nested] 12+ messages in thread* Re: [PATCH 6.1 00/86] 6.1.104-rc1 review
2024-08-07 14:59 [PATCH 6.1 00/86] 6.1.104-rc1 review Greg Kroah-Hartman
2024-08-07 17:32 ` Pavel Machek
@ 2024-08-07 17:42 ` Mark Brown
2024-08-07 18:22 ` Anders Roxell
` (3 subsequent siblings)
5 siblings, 0 replies; 12+ messages in thread
From: Mark Brown @ 2024-08-07 17:42 UTC (permalink / raw)
To: Greg Kroah-Hartman
Cc: stable, patches, linux-kernel, torvalds, akpm, linux, shuah,
patches, lkft-triage, pavel, jonathanh, f.fainelli,
sudipm.mukherjee, srw, rwarsow, conor, allen.lkml
[-- Attachment #1: Type: text/plain, Size: 5196 bytes --]
On Wed, Aug 07, 2024 at 04:59:39PM +0200, Greg Kroah-Hartman wrote:
> This is the start of the stable review cycle for the 6.1.104 release.
> There are 86 patches in this series, all will be posted as a response
> to this one. If anyone has any issues with these being applied, please
> let me know.
This breaks boot for an arm multi_v7_defconfig on qemu
virt-2.11,gic-version=3 with the oops below. Full log including the
qemu parameters at:
https://lava.sirena.org.uk/scheduler/job/617206
Bisect running but I'm not sure when I'll have time to pull the results
out.
<6>[ 0.000000] GICv3: 224 SPIs implemented
<6>[ 0.000000] GICv3: 0 Extended SPIs implemented
<6>[ 0.000000] GICv3: GICv3 features: 16 PPIs
<6>[ 0.000000] GICv3: CPU0: found redistributor 0 region 0:0x080a0000
<1>[ 0.000000] 8<--- cut here ---
<1>[ 0.000000] Unable to handle kernel NULL pointer dereference at virtual address 00000001
<1>[ 0.000000] [00000001] *pgd=00000000
<0>[ 0.000000] Internal error: Oops: 805 [#1] SMP ARM
<4>[ 0.000000] Modules linked in:
<4>[ 0.000000] CPU: 0 PID: 0 Comm: swapper/0 Not tainted 6.1.104-rc1-00087-gb22fe5fc2a45 #1
<4>[ 0.000000] Hardware name: Generic DT based system
<4>[ 0.000000] PC is at _set_bit+0x4/0x40
<4>[ 0.000000] LR is at enable_percpu_irq+0x64/0xcc
<4>[ 0.000000] pc : [<c10c58e4>] lr : [<c03a6f90>] psr: 000000d3
<4>[ 0.000000] sp : c1b01df8 ip : 00000001 fp : 00000001
<4>[ 0.000000] r10: 08000000 r9 : c1da9624 r8 : c1b0adb8
<4>[ 0.000000] r7 : 00000000 r6 : 00000010 r5 : c208b800 r4 : 00000000
<4>[ 0.000000] r3 : c1b09780 r2 : 00000000 r1 : c200574d r0 : 00000000
<4>[ 0.000000] Flags: nzcv IRQs off FIQs off Mode SVC_32 ISA ARM Segment none
<4>[ 0.000000] Control: 10c5387d Table: 4020406a DAC: 00000051
<1>[ 0.000000] Register r0 information: NULL pointer
<1>[ 0.000000] Register r1 information: slab kmalloc-64 start c2005740 pointer offset 13 size 64
<1>[ 0.000000] Register r2 information: NULL pointer
<1>[ 0.000000] Register r3 information: non-slab/vmalloc memory
<1>[ 0.000000] Register r4 information: NULL pointer
<1>[ 0.000000] Register r5 information: slab kmalloc-256 start c208b800 pointer offset 0 size 256
<1>[ 0.000000] Register r6 information: zero-size pointer
<1>[ 0.000000] Register r7 information: NULL pointer
<1>[ 0.000000] Register r8 information: non-slab/vmalloc memory
<1>[ 0.000000] Register r9 information: non-slab/vmalloc memory
<1>[ 0.000000] Register r10 information: non-paged memory
<1>[ 0.000000] Register r11 information: non-paged memory
<1>[ 0.000000] Register r12 information: non-paged memory
<0>[ 0.000000] Process swapper/0 (pid: 0, stack limit = 0x(ptrval))
<0>[ 0.000000] Stack: (0xc1b01df8 to 0xc1b02000)
<0>[ 0.000000] 1de0: 00000008 c1905bdc
<0>[ 0.000000] 1e00: 600000d3 00000000 c1b01e44 00000000 c1b04cdc 00000000 c1b09780 c030ee40
<0>[ 0.000000] 1e20: c1b05a38 dbbd8514 00000000 c1932778 c1b01e44 00000000 00000000 00f60000
<0>[ 0.000000] 1e40: 00000000 dbbd8514 00000001 00000000 00000000 00000000 00000000 00000000
<0>[ 0.000000] 1e60: 00000000 00000000 00000000 00000000 00000000 00000000 00000000 00000000
<0>[ 0.000000] 1e80: 00000000 00000000 00000000 00000000 dbbd8508 08000000 e0810000 c2005680
<0>[ 0.000000] 1ea0: 00000001 c2005690 c1675080 c19329fc 00000000 00000000 dbbd8514 c177f004
<0>[ 0.000000] 1ec0: 00000001 c1a4bc20 00000000 00000000 00000000 080a0000 08ffffff dbbd8574
<0>[ 0.000000] 1ee0: 00000200 00000000 00000000 00000000 00000000 c0ea2944 c1a4f89c 00000000
<0>[ 0.000000] 1f00: 00000000 c1a4f960 00000000 00000000 00000000 00000000 c1b01f4c c20055c0
<0>[ 0.000000] 1f20: 00000000 c1b01f4c c1b01f54 c1b01f4c 00000122 00000100 c162c61c c19a3cbc
<0>[ 0.000000] 1f40: 00000000 00000000 00000000 c1b01f4c c1b01f4c c1b01f54 c1b01f54 00000000
<0>[ 0.000000] 1f60: c1b09268 c19cda5c c1a54000 c1b04e48 c1900fe0 dbfff080 00000000 c178fa04
<0>[ 0.000000] 1f80: c1b09268 c1903c50 c1900fe0 c1d6a000 c1d998b0 c1d6a000 c1d998b0 c1b04cc0
<0>[ 0.000000] 1fa0: dbfff088 c1900fe0 ffffffff ffffffff 00000000 c19006ec c1b09780 c178fa04
<0>[ 0.000000] 1fc0: 00000000 c19cda6c 00000000 00000000 00000000 c1900420 00000051 10c0387d
<0>[ 0.000000] 1fe0: ffffffff 48786000 414fc0f0 10c5387d 00000000 00000000 00000000 00000000
<0>[ 0.000000] _set_bit from enable_percpu_irq+0x64/0xcc
<0>[ 0.000000] enable_percpu_irq from ipi_setup+0x34/0x80
<0>[ 0.000000] ipi_setup from gic_init_bases+0x5cc/0x68c
<0>[ 0.000000] gic_init_bases from gic_of_init+0x1c4/0x2cc
<0>[ 0.000000] gic_of_init from of_irq_init+0x1d4/0x324
<0>[ 0.000000] of_irq_init from init_IRQ+0xb0/0x110
<0>[ 0.000000] init_IRQ from start_kernel+0x528/0x6e4
<0>[ 0.000000] start_kernel from 0x0
<0>[ 0.000000] Code: e12fff1e e3e0000d e12fff1e e211c003 (15cc1000)
<4>[ 0.000000] ---[ end trace 0000000000000000 ]---
<0>[ 0.000000] Kernel panic - not syncing: Attempted to kill the idle task!
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
^ permalink raw reply [flat|nested] 12+ messages in thread* Re: [PATCH 6.1 00/86] 6.1.104-rc1 review
2024-08-07 14:59 [PATCH 6.1 00/86] 6.1.104-rc1 review Greg Kroah-Hartman
2024-08-07 17:32 ` Pavel Machek
2024-08-07 17:42 ` Mark Brown
@ 2024-08-07 18:22 ` Anders Roxell
2024-08-07 20:35 ` Salvatore Bonaccorso
` (2 subsequent siblings)
5 siblings, 0 replies; 12+ messages in thread
From: Anders Roxell @ 2024-08-07 18:22 UTC (permalink / raw)
To: Greg Kroah-Hartman
Cc: stable, patches, linux-kernel, torvalds, akpm, linux, shuah,
patches, lkft-triage, pavel, jonathanh, f.fainelli,
sudipm.mukherjee, srw, rwarsow, conor, allen.lkml, broonie,
Andy Shevchenko, Thomas Gleixner
On Wed, 7 Aug 2024 at 17:13, Greg Kroah-Hartman
<gregkh@linuxfoundation.org> wrote:
>
> This is the start of the stable review cycle for the 6.1.104 release.
> There are 86 patches in this series, all will be posted as a response
> to this one. If anyone has any issues with these being applied, please
> let me know.
>
> Responses should be made by Fri, 09 Aug 2024 15:00:24 +0000.
> Anything received after that time might be too late.
>
> The whole patch series can be found in one patch at:
> https://www.kernel.org/pub/linux/kernel/v6.x/stable-review/patch-6.1.104-rc1.gz
> or in the git tree and branch at:
> git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git linux-6.1.y
> and the diffstat can be found below.
>
> thanks,
>
> greg k-h
The following kernel panic noticed on stable-rc linux-6.1.y on while booting
qemu-arm64 and qemu-arm.
GOOD: v6.1.102-441-gdbbffaaee188
BAD: v6.1.103-87-gb22fe5fc2a45
Reported-by: Linux Kernel Functional Testing <lkft@linaro.org>
The git bisect results pointing to,
irqdomain: Use return value of strreplace()
[ Upstream commit 67a4e1a3bf7c68ed3fbefc4213648165d912cabb ]
Kernel panic:
--------
[ 0.000000] Booting Linux on physical CPU 0x0000000000 [0x000f0510]
[ 0.000000] Linux version 6.1.104-rc1 (tuxmake@tuxmake)
(aarch64-linux-gnu-gcc (Debian 13.2.0-12) 13.2.0, GNU ld (GNU Binutils
for Debian) 2.42) #1 SMP PREEMPT @1723045420
[ 0.000000] random: crng init done
[ 0.000000] Machine model: linux,dummy-virt
...
<6>[ 0.000000] GICv3: GICv3 features: 16 PPIs
<6>[ 0.000000] GICv3: CPU0: found redistributor 0 region 0:0x00000000080a0000
<1>[ 0.000000] Unable to handle kernel paging request at virtual
address ffff0000c003150d
<1>[ 0.000000] Mem abort info:
<1>[ 0.000000] ESR = 0x0000000096000061
<1>[ 0.000000] EC = 0x25: DABT (current EL), IL = 32 bits
<1>[ 0.000000] SET = 0, FnV = 0
<1>[ 0.000000] EA = 0, S1PTW = 0
<1>[ 0.000000] FSC = 0x21: alignment fault
<1>[ 0.000000] Data abort info:
<1>[ 0.000000] ISV = 0, ISS = 0x00000061
<1>[ 0.000000] CM = 0, WnR = 1
<1>[ 0.000000] swapper pgtable: 64k pages, 48-bit VAs, pgdp=0000000042120000
<1>[ 0.000000] [ffff0000c003150d] pgd=180000013dfd0003,
p4d=180000013dfd0003, pud=180000013dfd0003, pmd=180000013df60003,
pte=0068000100030707
<0>[ 0.000000] Internal error: Oops: 0000000096000061 [#1] PREEMPT SMP
<4>[ 0.000000] Modules linked in:
<4>[ 0.000000] CPU: 0 PID: 0 Comm: swapper/0 Not tainted 6.1.104-rc1 #1
<4>[ 0.000000] Hardware name: linux,dummy-virt (DT)
<4>[ 0.000000] pstate: 600000c9 (nZCv daIF -PAN -UAO -TCO -DIT
-SSBS BTYPE=--)
<4>[ 0.000000] pc : irq_percpu_enable
(arch/arm64/include/asm/atomic_ll_sc.h:203 (discriminator 2)
arch/arm64/include/asm/atomic.h:65 (discriminator 2)
include/linux/atomic/atomic-long.h:329 (discriminator 2)
include/asm-generic/bitops/atomic.h:18 (discriminator 2)
include/asm-generic/bitops/instrumented-atomic.h:29 (discriminator 2)
include/linux/cpumask.h:411 (discriminator 2) kernel/irq/chip.c:396
(discriminator 2))
<4>[ 0.000000] lr : irq_percpu_enable
(include/asm-generic/bitops/atomic.h:17
include/asm-generic/bitops/instrumented-atomic.h:29
include/linux/cpumask.h:411 kernel/irq/chip.c:396)
<4>[ 0.000000] sp : ffffc6d51bd6fb00
<4>[ 0.000000] x29: ffffc6d51bd6fb00 x28: 0000000000000018 x27:
0000000000000001
<4>[ 0.000000] x26: ffffc6d519227000 x25: ffffc6d51bd98000 x24:
0000000000000008
<4>[ 0.000000] x23: ffffc6d51b3c0008 x22: 0000000000000000 x21:
0000000000000001
<4>[ 0.000000] x20: 0000000000000000 x19: ffff0000c0061800 x18:
0000000000000006
<4>[ 0.000000] x17: 000000000000003f x16: 00000000ffffffff x15:
ffffc6d51bd6f5f0
<4>[ 0.000000] x14: 0000000000003f9f x13: 0000000000004000 x12:
0000000000000000
<4>[ 0.000000] x11: 0000000000000040 x10: ffffc6d51be2db60 x9 :
ffffc6d51989695c
<4>[ 0.000000] x8 : ffff000020000270 x7 : 0000000000000000 x6 :
0000000000000000
<4>[ 0.000000] x5 : ffff000020000248 x4 : ffff392be25e0000 x3 :
ffff0000c003150d
<4>[ 0.000000] x2 : 0000000000000001 x1 : 0000000000000001 x0 :
ffff0000c003150d
<4>[ 0.000000] Call trace:
<4>[ 0.000000] irq_percpu_enable
(arch/arm64/include/asm/atomic_ll_sc.h:203 (discriminator 2)
arch/arm64/include/asm/atomic.h:65 (discriminator 2)
include/linux/atomic/atomic-long.h:329 (discriminator 2)
include/asm-generic/bitops/atomic.h:18 (discriminator 2)
include/asm-generic/bitops/instrumented-atomic.h:29 (discriminator 2)
include/linux/cpumask.h:411 (discriminator 2) kernel/irq/chip.c:396
(discriminator 2))
<4>[ 0.000000] enable_percpu_irq (kernel/irq/internals.h:194
kernel/irq/manage.c:2396)
<4>[ 0.000000] ipi_setup.isra.0 (arch/arm64/kernel/smp.c:939
(discriminator 3) arch/arm64/kernel/smp.c:932 (discriminator 3))
<4>[ 0.000000] set_smp_ipi_range (arch/arm64/kernel/smp.c:978)
<4>[ 0.000000] gic_init_bases (drivers/irqchip/irq-gic.c:568)
<4>[ 0.000000] gic_of_init (drivers/irqchip/irq-gic-v3.c:2227)
<4>[ 0.000000] of_irq_init (drivers/of/irq.c:607)
<4>[ 0.000000] irqchip_init (drivers/irqchip/irqchip.c:32)
<4>[ 0.000000] init_IRQ (arch/arm64/kernel/irq.c:136)
<4>[ 0.000000] start_kernel (init/main.c:1045)
<4>[ 0.000000] __primary_switched (arch/arm64/kernel/head.S:469)
<0>[ 0.000000] Code: a8c27bfd d50323bf d65f03c0 f9800011 (c85f7c02)
All code
========
0: a8c27bfd ldp x29, x30, [sp], #32
4: d50323bf autiasp
8: d65f03c0 ret
c: f9800011 prfm pstl1strm, [x0]
10:* c85f7c02 ldxr x2, [x0] <-- trapping instruction
Code starting with the faulting instruction
===========================================
0: c85f7c02 ldxr x2, [x0]
<4>[ 0.000000] ---[ end trace 0000000000000000 ]---
<0>[ 0.000000] Kernel panic - not syncing: Attempted to kill the idle task!
<0>[ 0.000000] ---[ end Kernel panic - not syncing: Attempted to
kill the idle task! ]---
boot log:
-------
- https://qa-reports.linaro.org/lkft/linux-stable-rc-linux-6.1.y/build/v6.1.103-87-gb22fe5fc2a45/testrun/24787696/suite/boot/test/gcc-13-lkftconfig-rcutorture/log
details log:
-----------
- https://qa-reports.linaro.org/lkft/linux-stable-rc-linux-6.1.y/build/v6.1.103-87-gb22fe5fc2a45/testrun/24787696/suite/boot/test/gcc-13-lkftconfig-rcutorture/details/
Build log links:
-----
- https://storage.tuxsuite.com/public/linaro/lkft/builds/2kKvVPIRvZ26DxUefAqM4a0PwOs/
- https://storage.tuxsuite.com/public/linaro/lkft/builds/2kKvVPIRvZ26DxUefAqM4a0PwOs/config
metadata:
----
git_describe: v6.1.103-87-gb22fe5fc2a45
git_repo: https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git
git_sha: b22fe5fc2a455ab65a78fe39d86ef3a300d87243
git_short_log: b22fe5fc2a45 ("Linux 6.1.104-rc1")
--
Linaro LKFT
https://lkft.linaro.org
^ permalink raw reply [flat|nested] 12+ messages in thread* Re: [PATCH 6.1 00/86] 6.1.104-rc1 review
2024-08-07 14:59 [PATCH 6.1 00/86] 6.1.104-rc1 review Greg Kroah-Hartman
` (2 preceding siblings ...)
2024-08-07 18:22 ` Anders Roxell
@ 2024-08-07 20:35 ` Salvatore Bonaccorso
2024-08-11 10:09 ` Greg Kroah-Hartman
2024-08-07 21:10 ` Florian Fainelli
2024-08-07 21:39 ` Shuah Khan
5 siblings, 1 reply; 12+ messages in thread
From: Salvatore Bonaccorso @ 2024-08-07 20:35 UTC (permalink / raw)
To: Greg Kroah-Hartman
Cc: stable, patches, linux-kernel, torvalds, akpm, linux, shuah,
patches, lkft-triage, pavel, jonathanh, f.fainelli,
sudipm.mukherjee, srw, rwarsow, conor, allen.lkml, broonie,
Akemi Yagi, Hardik Garg
Hi Greg,
On Wed, Aug 07, 2024 at 04:59:39PM +0200, Greg Kroah-Hartman wrote:
> This is the start of the stable review cycle for the 6.1.104 release.
> There are 86 patches in this series, all will be posted as a response
> to this one. If anyone has any issues with these being applied, please
> let me know.
>
> Responses should be made by Fri, 09 Aug 2024 15:00:24 +0000.
> Anything received after that time might be too late.
6.1.103 had the regression of bpftool not building, due to a missing
backport:
https://lore.kernel.org/stable/v8lqgl$15bq$1@ciao.gmane.io/
The problem is that da5f8fd1f0d3 ("bpftool: Mount bpffs when pinmaps
path not under the bpffs") was backported to 6.1.103 but there is no
defintion of create_and_mount_bpffs_dir().
it was suggested to revert the commit completely.
Regards,
Salvatore
^ permalink raw reply [flat|nested] 12+ messages in thread* Re: [PATCH 6.1 00/86] 6.1.104-rc1 review
2024-08-07 20:35 ` Salvatore Bonaccorso
@ 2024-08-11 10:09 ` Greg Kroah-Hartman
2024-08-11 15:03 ` Salvatore Bonaccorso
0 siblings, 1 reply; 12+ messages in thread
From: Greg Kroah-Hartman @ 2024-08-11 10:09 UTC (permalink / raw)
To: Salvatore Bonaccorso
Cc: stable, patches, linux-kernel, torvalds, akpm, linux, shuah,
patches, lkft-triage, pavel, jonathanh, f.fainelli,
sudipm.mukherjee, srw, rwarsow, conor, allen.lkml, broonie,
Akemi Yagi, Hardik Garg
On Wed, Aug 07, 2024 at 10:35:11PM +0200, Salvatore Bonaccorso wrote:
> Hi Greg,
>
> On Wed, Aug 07, 2024 at 04:59:39PM +0200, Greg Kroah-Hartman wrote:
> > This is the start of the stable review cycle for the 6.1.104 release.
> > There are 86 patches in this series, all will be posted as a response
> > to this one. If anyone has any issues with these being applied, please
> > let me know.
> >
> > Responses should be made by Fri, 09 Aug 2024 15:00:24 +0000.
> > Anything received after that time might be too late.
>
> 6.1.103 had the regression of bpftool not building, due to a missing
> backport:
>
> https://lore.kernel.org/stable/v8lqgl$15bq$1@ciao.gmane.io/
>
> The problem is that da5f8fd1f0d3 ("bpftool: Mount bpffs when pinmaps
> path not under the bpffs") was backported to 6.1.103 but there is no
> defintion of create_and_mount_bpffs_dir().
>
> it was suggested to revert the commit completely.
Thanks for this, I'll fix it up after this release.
greg k-h
^ permalink raw reply [flat|nested] 12+ messages in thread* Re: [PATCH 6.1 00/86] 6.1.104-rc1 review
2024-08-11 10:09 ` Greg Kroah-Hartman
@ 2024-08-11 15:03 ` Salvatore Bonaccorso
2024-08-11 15:40 ` Greg Kroah-Hartman
0 siblings, 1 reply; 12+ messages in thread
From: Salvatore Bonaccorso @ 2024-08-11 15:03 UTC (permalink / raw)
To: Greg Kroah-Hartman
Cc: stable, patches, linux-kernel, torvalds, akpm, linux, shuah,
patches, lkft-triage, pavel, jonathanh, f.fainelli,
sudipm.mukherjee, srw, rwarsow, conor, allen.lkml, broonie,
Akemi Yagi, Hardik Garg, Quentin Monnet, bpf
Hi Greg,
On Sun, Aug 11, 2024 at 12:09:30PM +0200, Greg Kroah-Hartman wrote:
> On Wed, Aug 07, 2024 at 10:35:11PM +0200, Salvatore Bonaccorso wrote:
> > Hi Greg,
> >
> > On Wed, Aug 07, 2024 at 04:59:39PM +0200, Greg Kroah-Hartman wrote:
> > > This is the start of the stable review cycle for the 6.1.104 release.
> > > There are 86 patches in this series, all will be posted as a response
> > > to this one. If anyone has any issues with these being applied, please
> > > let me know.
> > >
> > > Responses should be made by Fri, 09 Aug 2024 15:00:24 +0000.
> > > Anything received after that time might be too late.
> >
> > 6.1.103 had the regression of bpftool not building, due to a missing
> > backport:
> >
> > https://lore.kernel.org/stable/v8lqgl$15bq$1@ciao.gmane.io/
> >
> > The problem is that da5f8fd1f0d3 ("bpftool: Mount bpffs when pinmaps
> > path not under the bpffs") was backported to 6.1.103 but there is no
> > defintion of create_and_mount_bpffs_dir().
> >
> > it was suggested to revert the commit completely.
>
> Thanks for this, I'll fix it up after this release.
Thanks! Note today Quentin Monnet proposed another solution by
cherry-picking two commits:
https://lore.kernel.org/stable/67bfcb8a-e00e-47b2-afe2-970a60e4a173@kernel.org/
Quoting:
> You should be able to fix the build by first cherry-picking commit
> 2a36c26fe3b8 ("bpftool: Support bpffs mountpoint as pin path for prog
> loadall"), and then commit 478a535ae54a ("bpftool: Mount bpffs on
> provided dir instead of parent dir") as you figured. Both commits have a
> minor conflict on tools/bpf/bpftool/struct_ops.c, which should be
> addressed by discarding the relevant hunk (for both commit).
>
> Alternatively, it's also fine to revert the breaking commit. It's a
> quality of life improvement without which users may have to manually
> mount the bpffs at the location they want to pin their maps when loading
> multiple BPF programs with "bpftool prog loadall", in the unlikely event
> they're not using /sys/kernel/bpf, prior to running the bpftool command.
> It's not in use during the kernel build process or for the BPF
> selftests, so not necessary on stable branches.
>
> I hope this helps,
> Quentin
I cannot judge which is less risky, but I will for Debian in any case
follow what will be picked (if needed to cherry-pick those in advance;
I was meaning to release another update but can now as well wait for
6.1.105 with that bpftool fix).
Regards,
Salvatore
^ permalink raw reply [flat|nested] 12+ messages in thread* Re: [PATCH 6.1 00/86] 6.1.104-rc1 review
2024-08-11 15:03 ` Salvatore Bonaccorso
@ 2024-08-11 15:40 ` Greg Kroah-Hartman
2024-08-12 17:49 ` Salvatore Bonaccorso
0 siblings, 1 reply; 12+ messages in thread
From: Greg Kroah-Hartman @ 2024-08-11 15:40 UTC (permalink / raw)
To: Salvatore Bonaccorso
Cc: stable, patches, linux-kernel, torvalds, akpm, linux, shuah,
patches, lkft-triage, pavel, jonathanh, f.fainelli,
sudipm.mukherjee, srw, rwarsow, conor, allen.lkml, broonie,
Akemi Yagi, Hardik Garg, Quentin Monnet, bpf
On Sun, Aug 11, 2024 at 05:03:45PM +0200, Salvatore Bonaccorso wrote:
> Hi Greg,
>
> On Sun, Aug 11, 2024 at 12:09:30PM +0200, Greg Kroah-Hartman wrote:
> > On Wed, Aug 07, 2024 at 10:35:11PM +0200, Salvatore Bonaccorso wrote:
> > > Hi Greg,
> > >
> > > On Wed, Aug 07, 2024 at 04:59:39PM +0200, Greg Kroah-Hartman wrote:
> > > > This is the start of the stable review cycle for the 6.1.104 release.
> > > > There are 86 patches in this series, all will be posted as a response
> > > > to this one. If anyone has any issues with these being applied, please
> > > > let me know.
> > > >
> > > > Responses should be made by Fri, 09 Aug 2024 15:00:24 +0000.
> > > > Anything received after that time might be too late.
> > >
> > > 6.1.103 had the regression of bpftool not building, due to a missing
> > > backport:
> > >
> > > https://lore.kernel.org/stable/v8lqgl$15bq$1@ciao.gmane.io/
> > >
> > > The problem is that da5f8fd1f0d3 ("bpftool: Mount bpffs when pinmaps
> > > path not under the bpffs") was backported to 6.1.103 but there is no
> > > defintion of create_and_mount_bpffs_dir().
> > >
> > > it was suggested to revert the commit completely.
> >
> > Thanks for this, I'll fix it up after this release.
>
> Thanks! Note today Quentin Monnet proposed another solution by
> cherry-picking two commits:
>
> https://lore.kernel.org/stable/67bfcb8a-e00e-47b2-afe2-970a60e4a173@kernel.org/
They don't apply cleanly, so I'll just add a revert...
thanks,
greg k-h
^ permalink raw reply [flat|nested] 12+ messages in thread* Re: [PATCH 6.1 00/86] 6.1.104-rc1 review
2024-08-11 15:40 ` Greg Kroah-Hartman
@ 2024-08-12 17:49 ` Salvatore Bonaccorso
2024-08-13 6:08 ` Greg Kroah-Hartman
0 siblings, 1 reply; 12+ messages in thread
From: Salvatore Bonaccorso @ 2024-08-12 17:49 UTC (permalink / raw)
To: Greg Kroah-Hartman
Cc: stable, patches, linux-kernel, torvalds, akpm, linux, shuah,
patches, lkft-triage, pavel, jonathanh, f.fainelli,
sudipm.mukherjee, srw, rwarsow, conor, allen.lkml, broonie,
Akemi Yagi, Hardik Garg, Quentin Monnet, bpf
Hi Greg,
On Sun, Aug 11, 2024 at 05:40:58PM +0200, Greg Kroah-Hartman wrote:
> On Sun, Aug 11, 2024 at 05:03:45PM +0200, Salvatore Bonaccorso wrote:
> > Hi Greg,
> >
> > On Sun, Aug 11, 2024 at 12:09:30PM +0200, Greg Kroah-Hartman wrote:
> > > On Wed, Aug 07, 2024 at 10:35:11PM +0200, Salvatore Bonaccorso wrote:
> > > > Hi Greg,
> > > >
> > > > On Wed, Aug 07, 2024 at 04:59:39PM +0200, Greg Kroah-Hartman wrote:
> > > > > This is the start of the stable review cycle for the 6.1.104 release.
> > > > > There are 86 patches in this series, all will be posted as a response
> > > > > to this one. If anyone has any issues with these being applied, please
> > > > > let me know.
> > > > >
> > > > > Responses should be made by Fri, 09 Aug 2024 15:00:24 +0000.
> > > > > Anything received after that time might be too late.
> > > >
> > > > 6.1.103 had the regression of bpftool not building, due to a missing
> > > > backport:
> > > >
> > > > https://lore.kernel.org/stable/v8lqgl$15bq$1@ciao.gmane.io/
> > > >
> > > > The problem is that da5f8fd1f0d3 ("bpftool: Mount bpffs when pinmaps
> > > > path not under the bpffs") was backported to 6.1.103 but there is no
> > > > defintion of create_and_mount_bpffs_dir().
> > > >
> > > > it was suggested to revert the commit completely.
> > >
> > > Thanks for this, I'll fix it up after this release.
> >
> > Thanks! Note today Quentin Monnet proposed another solution by
> > cherry-picking two commits:
> >
> > https://lore.kernel.org/stable/67bfcb8a-e00e-47b2-afe2-970a60e4a173@kernel.org/
>
> They don't apply cleanly, so I'll just add a revert...
FYI: Just realized that the breaking commit was as well queued for
older series 5.15.y, 5.10.y and 5.4.y, so that needs to be dropped
from those queues as well.
Regards,
Salvatore
^ permalink raw reply [flat|nested] 12+ messages in thread* Re: [PATCH 6.1 00/86] 6.1.104-rc1 review
2024-08-12 17:49 ` Salvatore Bonaccorso
@ 2024-08-13 6:08 ` Greg Kroah-Hartman
0 siblings, 0 replies; 12+ messages in thread
From: Greg Kroah-Hartman @ 2024-08-13 6:08 UTC (permalink / raw)
To: Salvatore Bonaccorso
Cc: stable, patches, linux-kernel, torvalds, akpm, linux, shuah,
patches, lkft-triage, pavel, jonathanh, f.fainelli,
sudipm.mukherjee, srw, rwarsow, conor, allen.lkml, broonie,
Akemi Yagi, Hardik Garg, Quentin Monnet, bpf
On Mon, Aug 12, 2024 at 07:49:34PM +0200, Salvatore Bonaccorso wrote:
> Hi Greg,
>
> On Sun, Aug 11, 2024 at 05:40:58PM +0200, Greg Kroah-Hartman wrote:
> > On Sun, Aug 11, 2024 at 05:03:45PM +0200, Salvatore Bonaccorso wrote:
> > > Hi Greg,
> > >
> > > On Sun, Aug 11, 2024 at 12:09:30PM +0200, Greg Kroah-Hartman wrote:
> > > > On Wed, Aug 07, 2024 at 10:35:11PM +0200, Salvatore Bonaccorso wrote:
> > > > > Hi Greg,
> > > > >
> > > > > On Wed, Aug 07, 2024 at 04:59:39PM +0200, Greg Kroah-Hartman wrote:
> > > > > > This is the start of the stable review cycle for the 6.1.104 release.
> > > > > > There are 86 patches in this series, all will be posted as a response
> > > > > > to this one. If anyone has any issues with these being applied, please
> > > > > > let me know.
> > > > > >
> > > > > > Responses should be made by Fri, 09 Aug 2024 15:00:24 +0000.
> > > > > > Anything received after that time might be too late.
> > > > >
> > > > > 6.1.103 had the regression of bpftool not building, due to a missing
> > > > > backport:
> > > > >
> > > > > https://lore.kernel.org/stable/v8lqgl$15bq$1@ciao.gmane.io/
> > > > >
> > > > > The problem is that da5f8fd1f0d3 ("bpftool: Mount bpffs when pinmaps
> > > > > path not under the bpffs") was backported to 6.1.103 but there is no
> > > > > defintion of create_and_mount_bpffs_dir().
> > > > >
> > > > > it was suggested to revert the commit completely.
> > > >
> > > > Thanks for this, I'll fix it up after this release.
> > >
> > > Thanks! Note today Quentin Monnet proposed another solution by
> > > cherry-picking two commits:
> > >
> > > https://lore.kernel.org/stable/67bfcb8a-e00e-47b2-afe2-970a60e4a173@kernel.org/
> >
> > They don't apply cleanly, so I'll just add a revert...
>
> FYI: Just realized that the breaking commit was as well queued for
> older series 5.15.y, 5.10.y and 5.4.y, so that needs to be dropped
> from those queues as well.
Good catch, I'll go drop it now from them, thanks!
greg k-h
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH 6.1 00/86] 6.1.104-rc1 review
2024-08-07 14:59 [PATCH 6.1 00/86] 6.1.104-rc1 review Greg Kroah-Hartman
` (3 preceding siblings ...)
2024-08-07 20:35 ` Salvatore Bonaccorso
@ 2024-08-07 21:10 ` Florian Fainelli
2024-08-07 21:39 ` Shuah Khan
5 siblings, 0 replies; 12+ messages in thread
From: Florian Fainelli @ 2024-08-07 21:10 UTC (permalink / raw)
To: Greg Kroah-Hartman, stable, Justin Chen, Andy Shevchenko
Cc: patches, linux-kernel, torvalds, akpm, linux, shuah, patches,
lkft-triage, pavel, jonathanh, sudipm.mukherjee, srw, rwarsow,
conor, allen.lkml, broonie
On 8/7/24 07:59, Greg Kroah-Hartman wrote:
> This is the start of the stable review cycle for the 6.1.104 release.
> There are 86 patches in this series, all will be posted as a response
> to this one. If anyone has any issues with these being applied, please
> let me know.
>
> Responses should be made by Fri, 09 Aug 2024 15:00:24 +0000.
> Anything received after that time might be too late.
>
> The whole patch series can be found in one patch at:
> https://www.kernel.org/pub/linux/kernel/v6.x/stable-review/patch-6.1.104-rc1.gz
> or in the git tree and branch at:
> git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git linux-6.1.y
> and the diffstat can be found below.
>
> thanks,
>
> greg k-h
I have been getting some fairly unexplained oopses with 6.1.104-rc1,
whereas 6.1.103 was stable. This is only seen with ARM64, not with ARM32
running on the same board for some reason.
Here are a few samples, they most often fall within the workqueue code,
but not always:
Loading modules...[ 4.538506] usb 1-1: new high-speed USB device
number 2 using xhci-hcd
[ 4.621340] Unable to handle kernel paging request at virtual address
ffffff8004ea078d
[ 4.629297] Mem abort info:
[ 4.632097] ESR = 0x0000000096000021
[ 4.635851] EC = 0x25: DABT (current EL), IL = 32 bits
[ 4.641172] SET = 0, FnV = 0
[ 4.644229] EA = 0, S1PTW = 0
[ 4.647374] FSC = 0x21: alignment fault
[ 4.651389] Data abort info:
[ 4.654274] ISV = 0, ISS = 0x00000021
[ 4.658115] CM = 0, WnR = 0
[ 4.661085] swapper pgtable: 4k pages, 39-bit VAs, pgdp=000000004102f000
[ 4.667795] [ffffff8004ea078d] pgd=18000000bdff8003,
p4d=18000000bdff8003, pud=18000000bdff8003, pmd=18000000bdfd6003,
pte=0068000044ea0707
[ 4.680345] Internal error: Oops: 0000000096000021 [#1] SMP
[ 4.685930] Modules linked in: udc_core(+)
[ 4.690039] CPU: 0 PID: 1086 Comm: modprobe Not tainted
6.1.104-1.1pre-gfcba0aeec90f #2
[ 4.698058] Hardware name: BCM972164PCK (DT)
[ 4.702334] pstate: 600000c5 (nZCv daIF -PAN -UAO -TCO -DIT -SSBS
BTYPE=--)
[ 4.709308] pc : queue_work_on+0x70/0x90
[ 4.713248] lr : queue_work_on+0x28/0x90
[ 4.717178] sp : ffffffc00cd23940
[ 4.720497] x29: ffffffc00cd23940 x28: ffffff8002de6800 x27:
0000000000000000
[ 4.727648] x26: ffffffc00a7b5c68 x25: ffffffc00cd23978 x24:
0000000000000000
[ 4.734798] x23: ffffffc00a630578 x22: ffffff8002c12c00 x21:
0000000000000100
[ 4.741948] x20: 0000000000000000 x19: ffffff8004ea078d x18:
0000000000000000
[ 4.749098] x17: 0000000000000000 x16: 0000000000000000 x15:
000000000000000a
[ 4.756247] x14: 0000000000000001 x13: 6e69622f7273752f x12:
3a6e6962732f7273
[ 4.763397] x11: 752f3a6e69622f3a x10: 0000000000000073 x9 :
ffffffc00804d610
[ 4.770547] x8 : ffffff8004ea080d x7 : 0000000000000000 x6 :
0000000080200006
[ 4.777696] x5 : 00000000ffffffff x4 : 0000000000000dc0 x3 :
0000000000000080
[ 4.784846] x2 : ffffff8004ea078d x1 : ffffff8002c12c00 x0 :
0000000000000000
[ 4.791997] Call trace:
[ 4.794446] queue_work_on+0x70/0x90
[ 4.798028] call_usermodehelper_exec+0xd4/0x1cc
[ 4.802654] kobject_uevent_env+0x6a0/0x6e0
[ 4.806849] kobject_uevent+0x10/0x18
[ 4.810519] kset_register+0x50/0x60
[ 4.814102] bus_register+0xa4/0x234
[ 4.817686] usb_udc_init+0x7c/0x1000 [udc_core]
[ 4.822338] do_one_initcall+0x80/0x1b0
[ 4.826183] do_init_module+0x54/0x1d8
[ 4.829942] load_module+0x1818/0x18e4
[ 4.833699] __do_sys_finit_module+0xec/0x10c
[ 4.838064] __arm64_sys_finit_module+0x20/0x28
[ 4.842603] invoke_syscall+0x80/0x118
[ 4.846360] el0_svc_common.constprop.3+0xb8/0xe4
[ 4.851071] do_el0_svc+0x98/0xbc
[ 4.854392] el0_svc+0x14/0x3c
[ 4.857455] el0t_64_sync_handler+0x64/0x140
[ 4.861732] el0t_64_sync+0x148/0x14c
[ 4.865402] Code: a9425bf5 a8c37bfd d65f03c0 f9800271 (c85f7e60)
[ 4.871506] ---[ end trace 0000000000000000 ]---
[ 4.876130] note: modprobe[1086] exited with irqs disabled
/sbin/load_modules: line 21: 1086 Segmentation fault modprobe -q $m
done
Another one was:
[ 5.833060] Unable to handle kernel paging request at virtual address
ffffff800586ebc6
[ 5.841005] Mem abort info:
[ 5.843812] ESR = 0x0000000096000021
[ 5.847576] EC = 0x25: DABT (current EL), IL = 32 bits
[ 5.852907] SET = 0, FnV = 0
[ 5.855974] EA = 0, S1PTW = 0
[ 5.859128] FSC = 0x21: alignment fault
[ 5.863154] Data abort info:
[ 5.866047] ISV = 0, ISS = 0x00000021
[ 5.869897] CM = 0, WnR = 0
[ 5.872878] swapper pgtable: 4k pages, 39-bit VAs, pgdp=000000000102f000
[ 5.879601] [ffffff800586ebc6] pgd=180000007dff8003,
p4d=180000007dff8003, pud=180000007dff8003, pmd=180000007dfd1003,
pte=006800000586e707
[ 5.892173] Internal error: Oops: 0000000096000021 [#1] SMP
[ 5.897764] Modules linked in:
[ 5.900832] CPU: 1 PID: 24 Comm: kworker/u4:1 Not tainted
6.1.104-1.1pre-gfcba0aeec90f #2
[ 5.909032] Hardware name: BCM972604DV2GB (DT)
[ 5.913489] Workqueue: events_unbound deferred_probe_work_func
[ 5.919349] pstate: 80000005 (Nzcv daif -PAN -UAO -TCO -DIT -SSBS
BTYPE=--)
[ 5.926330] pc : kobject_get+0x6c/0x94
[ 5.930096] lr : kobject_add_internal+0x5c/0x25c
[ 5.934730] sp : ffffffc00aa1b760
[ 5.938054] x29: ffffffc00aa1b760 x28: 0000000000000000 x27:
0000000000000000
[ 5.945213] x26: 000000000f700001 x25: ffffff8002f6ac10 x24:
ffffff8002f6ac10
[ 5.952373] x23: ffffffc008d99430 x22: ffffff800586eb8e x21:
ffffffc008d99430
[ 5.959533] x20: ffffff8004c49000 x19: ffffff800586eb8e x18:
0000000000000000
[ 5.966693] x17: 5f696368652e3030 x16: 3330306230663a6d x15:
000000000000000a
[ 5.973853] x14: 0000000000000001 x13: ffffff800589fa88 x12:
ffffffffffffffff
[ 5.981012] x11: 0000000000000020 x10: 0000000000000000 x9 :
ffffffc00858c200
[ 5.988171] x8 : 0101010101010101 x7 : 7f7f7f7f7f7f7f7f x6 :
ffffff800345c098
[ 5.995331] x5 : ffffffc00aa1b880 x4 : ffffff800586ebc6 x3 :
ffffff800589fa80
[ 6.002490] x2 : ffffffc00aa1b7b0 x1 : 0000000000000000 x0 :
ffffff800586ebc6
[ 6.009650] Call trace:
[ 6.012104] kobject_get+0x6c/0x94
[ 6.015518] kobject_add_internal+0x5c/0x25c
[ 6.019804] kobject_add+0xe0/0xfc
[ 6.023220] device_add+0x164/0x688
[ 6.026724] device_create_groups_vargs+0xac/0xfc
[ 6.031445] device_create+0x70/0x94
[ 6.035035] mon_bin_add+0x6c/0x80
[ 6.038449] mon_bus_init+0x74/0xa8
[ 6.041954] mon_notify+0x50/0xf8
[ 6.045282] notifier_call_chain+0x6c/0x8c
[ 6.049398] blocking_notifier_call_chain+0x48/0x70
[ 6.054294] usb_notify_add_bus+0x24/0x2c
[ 6.058319] usb_add_hcd+0x1f4/0x5fc
[ 6.061908] ehci_brcm_probe+0x164/0x1ac
[ 6.065846] platform_probe+0x6c/0xb8
[ 6.069524] really_probe+0x1b8/0x38c
[ 6.073198] __driver_probe_device+0x134/0x14c
[ 6.077656] driver_probe_device+0x40/0xf8
[ 6.081766] __device_attach_driver+0x108/0x11c
[ 6.086311] bus_for_each_drv+0xa0/0xc4
[ 6.090158] __device_attach+0xf0/0x178
[ 6.094007] device_initial_probe+0x18/0x20
[ 6.098203] bus_probe_device+0x34/0x94
[ 6.102052] deferred_probe_work_func+0xd4/0xe8
[ 6.106597] process_one_work+0x1a4/0x254
[ 6.110623] process_scheduled_works+0x44/0x48
[ 6.115083] worker_thread+0x1e8/0x264
[ 6.118846] kthread+0xbc/0xcc
[ 6.121912] ret_from_fork+0x10/0x20
[ 6.125506] Code: a8c27bfd d65f03c0 9100e264 f9800091 (885f7c81)
[ 6.131615] ---[ end trace 0000000000000000 ]---
It appears to be somewhat probabilistic because out of our dozen or so
boards in the farm, not all of them will hit the panic for a given
"bad" commit in the bisection. The bisection eventually landed on:
commit 2f7f85911e7559b06c44561c1e31a69ee80a5f60
Author: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Date: Wed Jun 28 18:02:51 2023 +0300
irqdomain: Use return value of strreplace()
[ Upstream commit 67a4e1a3bf7c68ed3fbefc4213648165d912cabb ]
Since strreplace() returns the pointer to the string itself, use it
directly.
Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
Link:
https://lore.kernel.org/r/20230628150251.17832-1-andriy.shevchenko@linux.intel.com
Stable-dep-of: 6ce3e98184b6 ("irqdomain: Fixed unbalanced fwnode
get and put")
Signed-off-by: Sasha Levin <sashal@kernel.org>
kernel/irq/irqdomain.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
Reverting that commit on top of 6.1.104-rc1 gives me a stable system
again, but I really have no explanation why because the transformation
seems correct to me, it is the *first* bad commit.
Andy, does that make any sense to you?
--
Florian
^ permalink raw reply [flat|nested] 12+ messages in thread* Re: [PATCH 6.1 00/86] 6.1.104-rc1 review
2024-08-07 14:59 [PATCH 6.1 00/86] 6.1.104-rc1 review Greg Kroah-Hartman
` (4 preceding siblings ...)
2024-08-07 21:10 ` Florian Fainelli
@ 2024-08-07 21:39 ` Shuah Khan
5 siblings, 0 replies; 12+ messages in thread
From: Shuah Khan @ 2024-08-07 21:39 UTC (permalink / raw)
To: Greg Kroah-Hartman, stable
Cc: patches, linux-kernel, torvalds, akpm, linux, shuah, patches,
lkft-triage, pavel, jonathanh, f.fainelli, sudipm.mukherjee, srw,
rwarsow, conor, allen.lkml, broonie, Shuah Khan
On 8/7/24 08:59, Greg Kroah-Hartman wrote:
> This is the start of the stable review cycle for the 6.1.104 release.
> There are 86 patches in this series, all will be posted as a response
> to this one. If anyone has any issues with these being applied, please
> let me know.
>
> Responses should be made by Fri, 09 Aug 2024 15:00:24 +0000.
> Anything received after that time might be too late.
>
> The whole patch series can be found in one patch at:
> https://www.kernel.org/pub/linux/kernel/v6.x/stable-review/patch-6.1.104-rc1.gz
> or in the git tree and branch at:
> git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git linux-6.1.y
> and the diffstat can be found below.
>
> thanks,
>
> greg k-h
>
Compiled and booted on my test system. No dmesg regressions.
Tested-by: Shuah Khan <skhan@linuxfoundation.org>
thanks,
-- Shuah
^ permalink raw reply [flat|nested] 12+ messages in thread