* [PATCH v1] pinctrl: starfive: jh7110: Correct the level trigger configuration of iev register
@ 2024-08-12 7:01 Hal Feng
2024-08-23 16:15 ` Linus Walleij
0 siblings, 1 reply; 2+ messages in thread
From: Hal Feng @ 2024-08-12 7:01 UTC (permalink / raw)
To: Linus Walleij, Conor Dooley, Emil Renner Berthing, Jianlong Huang,
Hal Feng
Cc: linux-gpio, linux-kernel
A mistake was made in level trigger register configuration. Correct it.
Fixes: 447976ab62c5 ("pinctrl: starfive: Add StarFive JH7110 sys controller driver")
Signed-off-by: Hal Feng <hal.feng@starfivetech.com>
---
Hi,
When we tested some modules that use gpio level trigger, we found
the current level trigger register configuration was set wrong.
Submit this patch to correct.
Best regards,
Hal
---
drivers/pinctrl/starfive/pinctrl-starfive-jh7110.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/pinctrl/starfive/pinctrl-starfive-jh7110.c b/drivers/pinctrl/starfive/pinctrl-starfive-jh7110.c
index 4ce080caa233..1d0d6c224c10 100644
--- a/drivers/pinctrl/starfive/pinctrl-starfive-jh7110.c
+++ b/drivers/pinctrl/starfive/pinctrl-starfive-jh7110.c
@@ -793,12 +793,12 @@ static int jh7110_irq_set_type(struct irq_data *d, unsigned int trigger)
case IRQ_TYPE_LEVEL_HIGH:
irq_type = 0; /* 0: level triggered */
edge_both = 0; /* 0: ignored */
- polarity = mask; /* 1: high level */
+ polarity = 0; /* 0: high level */
break;
case IRQ_TYPE_LEVEL_LOW:
irq_type = 0; /* 0: level triggered */
edge_both = 0; /* 0: ignored */
- polarity = 0; /* 0: low level */
+ polarity = mask; /* 1: low level */
break;
default:
return -EINVAL;
base-commit: 7c626ce4bae1ac14f60076d00eafe71af30450ba
--
2.43.2
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH v1] pinctrl: starfive: jh7110: Correct the level trigger configuration of iev register
2024-08-12 7:01 [PATCH v1] pinctrl: starfive: jh7110: Correct the level trigger configuration of iev register Hal Feng
@ 2024-08-23 16:15 ` Linus Walleij
0 siblings, 0 replies; 2+ messages in thread
From: Linus Walleij @ 2024-08-23 16:15 UTC (permalink / raw)
To: Hal Feng
Cc: Conor Dooley, Emil Renner Berthing, Jianlong Huang, linux-gpio,
linux-kernel
On Mon, Aug 12, 2024 at 9:02 AM Hal Feng <hal.feng@starfivetech.com> wrote:
> A mistake was made in level trigger register configuration. Correct it.
>
> Fixes: 447976ab62c5 ("pinctrl: starfive: Add StarFive JH7110 sys controller driver")
> Signed-off-by: Hal Feng <hal.feng@starfivetech.com>
Patch applied for fixes!
Yours,
Linus Walleij
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2024-08-23 16:15 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-08-12 7:01 [PATCH v1] pinctrl: starfive: jh7110: Correct the level trigger configuration of iev register Hal Feng
2024-08-23 16:15 ` Linus Walleij
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox