* [PATCH v1 1/1] serial: 8250_bcm2835aux: Switch to DEFINE_SIMPLE_DEV_PM_OPS()
@ 2024-08-12 14:35 Andy Shevchenko
2024-08-12 20:40 ` Stefan Wahren
0 siblings, 1 reply; 3+ messages in thread
From: Andy Shevchenko @ 2024-08-12 14:35 UTC (permalink / raw)
To: Greg Kroah-Hartman, Andy Shevchenko, linux-kernel, linux-serial,
linux-rpi-kernel, linux-arm-kernel
Cc: Jiri Slaby, Florian Fainelli,
Broadcom internal kernel review list, Ray Jui, Scott Branden,
Stefan Wahren
The SIMPLE_DEV_PM_OPS() is deprecated, replace it with the
DEFINE_SIMPLE_DEV_PM_OPS() for setting the driver's PM routines.
Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
---
drivers/tty/serial/8250/8250_bcm2835aux.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/tty/serial/8250/8250_bcm2835aux.c b/drivers/tty/serial/8250/8250_bcm2835aux.c
index 36e2bb34d82b..829abef2564d 100644
--- a/drivers/tty/serial/8250/8250_bcm2835aux.c
+++ b/drivers/tty/serial/8250/8250_bcm2835aux.c
@@ -245,9 +245,7 @@ static int bcm2835aux_resume(struct device *dev)
return 0;
}
-static const struct dev_pm_ops bcm2835aux_dev_pm_ops = {
- SYSTEM_SLEEP_PM_OPS(bcm2835aux_suspend, bcm2835aux_resume)
-};
+static DEFINE_SIMPLE_DEV_PM_OPS(bcm2835aux_dev_pm_ops, bcm2835aux_suspend, bcm2835aux_resume);
static struct platform_driver bcm2835aux_serial_driver = {
.driver = {
--
2.43.0.rc1.1336.g36b5255a03ac
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH v1 1/1] serial: 8250_bcm2835aux: Switch to DEFINE_SIMPLE_DEV_PM_OPS()
2024-08-12 14:35 [PATCH v1 1/1] serial: 8250_bcm2835aux: Switch to DEFINE_SIMPLE_DEV_PM_OPS() Andy Shevchenko
@ 2024-08-12 20:40 ` Stefan Wahren
2024-08-13 8:20 ` Andy Shevchenko
0 siblings, 1 reply; 3+ messages in thread
From: Stefan Wahren @ 2024-08-12 20:40 UTC (permalink / raw)
To: Andy Shevchenko, Greg Kroah-Hartman, linux-kernel, linux-serial,
linux-rpi-kernel, linux-arm-kernel
Cc: Jiri Slaby, Florian Fainelli,
Broadcom internal kernel review list, Ray Jui, Scott Branden
Hi Andy,
Am 12.08.24 um 16:35 schrieb Andy Shevchenko:
> The SIMPLE_DEV_PM_OPS() is deprecated, replace it with the
> DEFINE_SIMPLE_DEV_PM_OPS() for setting the driver's PM routines.
it's possible the implementation doesn't use the optimal macros here.
But this sentence is a little bit confusing to me, because the code
doesn't use SIMPLE_DEV_PM_OPS().
Best regards
>
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> ---
> drivers/tty/serial/8250/8250_bcm2835aux.c | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/drivers/tty/serial/8250/8250_bcm2835aux.c b/drivers/tty/serial/8250/8250_bcm2835aux.c
> index 36e2bb34d82b..829abef2564d 100644
> --- a/drivers/tty/serial/8250/8250_bcm2835aux.c
> +++ b/drivers/tty/serial/8250/8250_bcm2835aux.c
> @@ -245,9 +245,7 @@ static int bcm2835aux_resume(struct device *dev)
> return 0;
> }
>
> -static const struct dev_pm_ops bcm2835aux_dev_pm_ops = {
> - SYSTEM_SLEEP_PM_OPS(bcm2835aux_suspend, bcm2835aux_resume)
> -};
> +static DEFINE_SIMPLE_DEV_PM_OPS(bcm2835aux_dev_pm_ops, bcm2835aux_suspend, bcm2835aux_resume);
>
> static struct platform_driver bcm2835aux_serial_driver = {
> .driver = {
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH v1 1/1] serial: 8250_bcm2835aux: Switch to DEFINE_SIMPLE_DEV_PM_OPS()
2024-08-12 20:40 ` Stefan Wahren
@ 2024-08-13 8:20 ` Andy Shevchenko
0 siblings, 0 replies; 3+ messages in thread
From: Andy Shevchenko @ 2024-08-13 8:20 UTC (permalink / raw)
To: Stefan Wahren
Cc: Greg Kroah-Hartman, linux-kernel, linux-serial, linux-rpi-kernel,
linux-arm-kernel, Jiri Slaby, Florian Fainelli,
Broadcom internal kernel review list, Ray Jui, Scott Branden
On Mon, Aug 12, 2024 at 10:40:15PM +0200, Stefan Wahren wrote:
> Am 12.08.24 um 16:35 schrieb Andy Shevchenko:
> > The SIMPLE_DEV_PM_OPS() is deprecated, replace it with the
> > DEFINE_SIMPLE_DEV_PM_OPS() for setting the driver's PM routines.
> it's possible the implementation doesn't use the optimal macros here.
> But this sentence is a little bit confusing to me, because the code
> doesn't use SIMPLE_DEV_PM_OPS().
Thanks, fixed in v2:
https://lore.kernel.org/r/20240813081954.1408792-1-andriy.shevchenko@linux.intel.com.
--
With Best Regards,
Andy Shevchenko
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2024-08-13 8:21 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-08-12 14:35 [PATCH v1 1/1] serial: 8250_bcm2835aux: Switch to DEFINE_SIMPLE_DEV_PM_OPS() Andy Shevchenko
2024-08-12 20:40 ` Stefan Wahren
2024-08-13 8:20 ` Andy Shevchenko
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox