* [PATCH] Initialize symbol 'entity' in sched_main.c
@ 2024-08-17 16:20 Dipendra Khadka
2024-08-18 3:49 ` Matthew Brost
0 siblings, 1 reply; 2+ messages in thread
From: Dipendra Khadka @ 2024-08-17 16:20 UTC (permalink / raw)
To: ltuikov89, matthew.brost, maarten.lankhorst, mripard, tzimmermann,
airlied, daniel
Cc: Dipendra Khadka, dri-devel, linux-kernel
smatch reported following error:
'''
staging/drivers/gpu/drm/scheduler/sched_main.c:1063 drm_sched_select_entity() error: uninitialized symbol 'entity'.
'''
The symbol entity is initialized.
Signed-off-by: Dipendra Khadka <kdipendra88@gmail.com>
---
drivers/gpu/drm/scheduler/sched_main.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/scheduler/sched_main.c b/drivers/gpu/drm/scheduler/sched_main.c
index 7e90c9f95611..dcfd4d0f7c6e 100644
--- a/drivers/gpu/drm/scheduler/sched_main.c
+++ b/drivers/gpu/drm/scheduler/sched_main.c
@@ -1047,7 +1047,7 @@ void drm_sched_wakeup(struct drm_gpu_scheduler *sched,
static struct drm_sched_entity *
drm_sched_select_entity(struct drm_gpu_scheduler *sched)
{
- struct drm_sched_entity *entity;
+ struct drm_sched_entity *entity = NULL;
int i;
/* Start with the highest priority.
--
2.43.0
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH] Initialize symbol 'entity' in sched_main.c
2024-08-17 16:20 [PATCH] Initialize symbol 'entity' in sched_main.c Dipendra Khadka
@ 2024-08-18 3:49 ` Matthew Brost
0 siblings, 0 replies; 2+ messages in thread
From: Matthew Brost @ 2024-08-18 3:49 UTC (permalink / raw)
To: Dipendra Khadka
Cc: ltuikov89, maarten.lankhorst, mripard, tzimmermann, airlied,
daniel, dri-devel, linux-kernel
On Sat, Aug 17, 2024 at 04:20:24PM +0000, Dipendra Khadka wrote:
> smatch reported following error:
>
> '''
> staging/drivers/gpu/drm/scheduler/sched_main.c:1063 drm_sched_select_entity() error: uninitialized symbol 'entity'.
> '''
>
> The symbol entity is initialized.
>
Looks like false postive, no opposed merging it but since
'sched->num_rqs' must be greater than zero it entity should always be
set unless I'm missing something.
Matt
> Signed-off-by: Dipendra Khadka <kdipendra88@gmail.com>
> ---
> drivers/gpu/drm/scheduler/sched_main.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/scheduler/sched_main.c b/drivers/gpu/drm/scheduler/sched_main.c
> index 7e90c9f95611..dcfd4d0f7c6e 100644
> --- a/drivers/gpu/drm/scheduler/sched_main.c
> +++ b/drivers/gpu/drm/scheduler/sched_main.c
> @@ -1047,7 +1047,7 @@ void drm_sched_wakeup(struct drm_gpu_scheduler *sched,
> static struct drm_sched_entity *
> drm_sched_select_entity(struct drm_gpu_scheduler *sched)
> {
> - struct drm_sched_entity *entity;
> + struct drm_sched_entity *entity = NULL;
> int i;
>
> /* Start with the highest priority.
> --
> 2.43.0
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2024-08-18 3:50 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-08-17 16:20 [PATCH] Initialize symbol 'entity' in sched_main.c Dipendra Khadka
2024-08-18 3:49 ` Matthew Brost
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox