* [PATCH] Staging: rtl8192e: Fix arguments alignment
@ 2024-08-22 0:30 Ana Carolina Hernandes
2024-08-22 7:53 ` Greg Kroah-Hartman
0 siblings, 1 reply; 3+ messages in thread
From: Ana Carolina Hernandes @ 2024-08-22 0:30 UTC (permalink / raw)
To: Greg Kroah-Hartman, linux-staging, linux-kernel, ~lkcamp/patches
Fix the alignment of arguments in function _rtl92e_query_rxphystatus in
order to silence the following checkpatch warning:
CHECK: Lines should not end with a '('
Signed-off-by: Ana Carolina Hernandes <anachan.01h@gmail.com>
---
.../staging/rtl8192e/rtl8192e/r8192E_dev.c | 19 +++++++++----------
1 file changed, 9 insertions(+), 10 deletions(-)
diff --git a/drivers/staging/rtl8192e/rtl8192e/r8192E_dev.c b/drivers/staging/rtl8192e/rtl8192e/r8192E_dev.c
index b3d4b3394284..bca6e4f57bf2 100644
--- a/drivers/staging/rtl8192e/rtl8192e/r8192E_dev.c
+++ b/drivers/staging/rtl8192e/rtl8192e/r8192E_dev.c
@@ -1145,16 +1145,15 @@ static long _rtl92e_signal_scale_mapping(struct r8192_priv *priv, long currsig)
_pdrvinfo->RxRate == DESC90_RATE11M) &&\
!_pdrvinfo->RxHT)
-static void _rtl92e_query_rxphystatus(
- struct r8192_priv *priv,
- struct rtllib_rx_stats *pstats,
- struct rx_desc *pdesc,
- struct rx_fwinfo *pdrvinfo,
- struct rtllib_rx_stats *precord_stats,
- bool bpacket_match_bssid,
- bool bpacket_toself,
- bool bPacketBeacon,
- bool bToSelfBA
+static void _rtl92e_query_rxphystatus(struct r8192_priv *priv,
+ struct rtllib_rx_stats *pstats,
+ struct rx_desc *pdesc,
+ struct rx_fwinfo *pdrvinfo,
+ struct rtllib_rx_stats *precord_stats,
+ bool bpacket_match_bssid,
+ bool bpacket_toself,
+ bool bPacketBeacon,
+ bool bToSelfBA
)
{
struct phy_sts_ofdm_819xpci *pofdm_buf;
--
2.34.1
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] Staging: rtl8192e: Fix arguments alignment
2024-08-22 0:30 [PATCH] Staging: rtl8192e: Fix arguments alignment Ana Carolina Hernandes
@ 2024-08-22 7:53 ` Greg Kroah-Hartman
2024-08-22 20:07 ` Ana Carolina H.
0 siblings, 1 reply; 3+ messages in thread
From: Greg Kroah-Hartman @ 2024-08-22 7:53 UTC (permalink / raw)
To: Ana Carolina Hernandes; +Cc: linux-staging, linux-kernel, ~lkcamp/patches
On Wed, Aug 21, 2024 at 09:30:43PM -0300, Ana Carolina Hernandes wrote:
> Fix the alignment of arguments in function _rtl92e_query_rxphystatus in
> order to silence the following checkpatch warning:
>
> CHECK: Lines should not end with a '('
>
> Signed-off-by: Ana Carolina Hernandes <anachan.01h@gmail.com>
> ---
> .../staging/rtl8192e/rtl8192e/r8192E_dev.c | 19 +++++++++----------
> 1 file changed, 9 insertions(+), 10 deletions(-)
>
> diff --git a/drivers/staging/rtl8192e/rtl8192e/r8192E_dev.c b/drivers/staging/rtl8192e/rtl8192e/r8192E_dev.c
> index b3d4b3394284..bca6e4f57bf2 100644
> --- a/drivers/staging/rtl8192e/rtl8192e/r8192E_dev.c
> +++ b/drivers/staging/rtl8192e/rtl8192e/r8192E_dev.c
> @@ -1145,16 +1145,15 @@ static long _rtl92e_signal_scale_mapping(struct r8192_priv *priv, long currsig)
> _pdrvinfo->RxRate == DESC90_RATE11M) &&\
> !_pdrvinfo->RxHT)
>
> -static void _rtl92e_query_rxphystatus(
> - struct r8192_priv *priv,
> - struct rtllib_rx_stats *pstats,
> - struct rx_desc *pdesc,
> - struct rx_fwinfo *pdrvinfo,
> - struct rtllib_rx_stats *precord_stats,
> - bool bpacket_match_bssid,
> - bool bpacket_toself,
> - bool bPacketBeacon,
> - bool bToSelfBA
> +static void _rtl92e_query_rxphystatus(struct r8192_priv *priv,
> + struct rtllib_rx_stats *pstats,
> + struct rx_desc *pdesc,
> + struct rx_fwinfo *pdrvinfo,
> + struct rtllib_rx_stats *precord_stats,
> + bool bpacket_match_bssid,
> + bool bpacket_toself,
> + bool bPacketBeacon,
> + bool bToSelfBA
> )
So close, why leave the ")" on the line all by itself there? It needs
to go up one line, didn't checkpatch tell you that when you ran it on
this change?
thanks,
greg k-h
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] Staging: rtl8192e: Fix arguments alignment
2024-08-22 7:53 ` Greg Kroah-Hartman
@ 2024-08-22 20:07 ` Ana Carolina H.
0 siblings, 0 replies; 3+ messages in thread
From: Ana Carolina H. @ 2024-08-22 20:07 UTC (permalink / raw)
To: Greg Kroah-Hartman; +Cc: linux-staging, linux-kernel, ~lkcamp/patches
On Thu, Aug 22, 2024 at 4:53 AM Greg Kroah-Hartman
<gregkh@linuxfoundation.org> wrote:
>
> On Wed, Aug 21, 2024 at 09:30:43PM -0300, Ana Carolina Hernandes wrote:
> > Fix the alignment of arguments in function _rtl92e_query_rxphystatus in
> > order to silence the following checkpatch warning:
> >
> > CHECK: Lines should not end with a '('
> >
> > Signed-off-by: Ana Carolina Hernandes <anachan.01h@gmail.com>
> > ---
> > .../staging/rtl8192e/rtl8192e/r8192E_dev.c | 19 +++++++++----------
> > 1 file changed, 9 insertions(+), 10 deletions(-)
> >
> > diff --git a/drivers/staging/rtl8192e/rtl8192e/r8192E_dev.c b/drivers/staging/rtl8192e/rtl8192e/r8192E_dev.c
> > index b3d4b3394284..bca6e4f57bf2 100644
> > --- a/drivers/staging/rtl8192e/rtl8192e/r8192E_dev.c
> > +++ b/drivers/staging/rtl8192e/rtl8192e/r8192E_dev.c
> > @@ -1145,16 +1145,15 @@ static long _rtl92e_signal_scale_mapping(struct r8192_priv *priv, long currsig)
> > _pdrvinfo->RxRate == DESC90_RATE11M) &&\
> > !_pdrvinfo->RxHT)
> >
> > -static void _rtl92e_query_rxphystatus(
> > - struct r8192_priv *priv,
> > - struct rtllib_rx_stats *pstats,
> > - struct rx_desc *pdesc,
> > - struct rx_fwinfo *pdrvinfo,
> > - struct rtllib_rx_stats *precord_stats,
> > - bool bpacket_match_bssid,
> > - bool bpacket_toself,
> > - bool bPacketBeacon,
> > - bool bToSelfBA
> > +static void _rtl92e_query_rxphystatus(struct r8192_priv *priv,
> > + struct rtllib_rx_stats *pstats,
> > + struct rx_desc *pdesc,
> > + struct rx_fwinfo *pdrvinfo,
> > + struct rtllib_rx_stats *precord_stats,
> > + bool bpacket_match_bssid,
> > + bool bpacket_toself,
> > + bool bPacketBeacon,
> > + bool bToSelfBA
> > )
>
> So close, why leave the ")" on the line all by itself there? It needs
> to go up one line, didn't checkpatch tell you that when you ran it on
> this change?
>
> thanks,
>
> greg k-h
Checkpatch didn't warn me about the ")", but I will fix it too.
Thanks,
Ana Carolina Hernandes
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2024-08-22 20:07 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-08-22 0:30 [PATCH] Staging: rtl8192e: Fix arguments alignment Ana Carolina Hernandes
2024-08-22 7:53 ` Greg Kroah-Hartman
2024-08-22 20:07 ` Ana Carolina H.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox