* [PATCH v2] drivers:block:Use IS_ERR() to check debugfs_create_dir() return value
@ 2024-08-22 12:41 Yang Ruibin
2024-08-22 12:50 ` Yang Ruibin
0 siblings, 1 reply; 4+ messages in thread
From: Yang Ruibin @ 2024-08-22 12:41 UTC (permalink / raw)
To: linux-block, Jens Axboe, Andy Whitcroft, Joe Perches,
Dwaipayan Ray, Lukas Bulwahn, Borislav Petkov, Ingo Molnar,
linux-kernel
Cc: opensource.kernel, Yang Ruibin
The debugfs_create_dir() function returns error pointers.It
never returns NULL. So use IS_ERR() to check its return value.
Fixes: 011d82611172 ("RAS: Add a Corrected Errors Collector")
Signed-off-by: Yang Ruibin <11162571@vivo.com>
---
drivers/block/pktcdvd.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/block/pktcdvd.c b/drivers/block/pktcdvd.c
index 7cece5884b9c..030b7a063a0b 100644
--- a/drivers/block/pktcdvd.c
+++ b/drivers/block/pktcdvd.c
@@ -498,7 +498,7 @@ static void pkt_debugfs_dev_new(struct pktcdvd_device *pd)
if (!pkt_debugfs_root)
return;
pd->dfs_d_root = debugfs_create_dir(pd->disk->disk_name, pkt_debugfs_root);
- if (!pd->dfs_d_root)
+ if (IS_ERR(pd->dfs_d_root))
return;
pd->dfs_f_info = debugfs_create_file("info", 0444, pd->dfs_d_root,
--
2.34.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH v2] drivers:block:Use IS_ERR() to check debugfs_create_dir() return value
2024-08-22 12:41 Yang Ruibin
@ 2024-08-22 12:50 ` Yang Ruibin
0 siblings, 0 replies; 4+ messages in thread
From: Yang Ruibin @ 2024-08-22 12:50 UTC (permalink / raw)
To: linux-block, Jens Axboe, Andy Whitcroft, Joe Perches,
Dwaipayan Ray, Lukas Bulwahn, Borislav Petkov, Ingo Molnar,
linux-kernel
Cc: opensource.kernel
Sorry, please ignore this patch for now. The wrong Fixes were used. This
patch will be updated later.
在 2024/8/22 20:41, Yang Ruibin 写道:
> The debugfs_create_dir() function returns error pointers.It
> never returns NULL. So use IS_ERR() to check its return value.
>
> Fixes: 011d82611172 ("RAS: Add a Corrected Errors Collector")
> Signed-off-by: Yang Ruibin <11162571@vivo.com>
> ---
> drivers/block/pktcdvd.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/block/pktcdvd.c b/drivers/block/pktcdvd.c
> index 7cece5884b9c..030b7a063a0b 100644
> --- a/drivers/block/pktcdvd.c
> +++ b/drivers/block/pktcdvd.c
> @@ -498,7 +498,7 @@ static void pkt_debugfs_dev_new(struct pktcdvd_device *pd)
> if (!pkt_debugfs_root)
> return;
> pd->dfs_d_root = debugfs_create_dir(pd->disk->disk_name, pkt_debugfs_root);
> - if (!pd->dfs_d_root)
> + if (IS_ERR(pd->dfs_d_root))
> return;
>
> pd->dfs_f_info = debugfs_create_file("info", 0444, pd->dfs_d_root,
^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH v2] drivers:block:Use IS_ERR() to check debugfs_create_dir() return value
@ 2024-08-22 13:23 Yang Ruibin
2024-08-23 8:29 ` Jonathan Cameron
0 siblings, 1 reply; 4+ messages in thread
From: Yang Ruibin @ 2024-08-22 13:23 UTC (permalink / raw)
To: Tony Luck, Borislav Petkov, Andy Whitcroft, Joe Perches,
Dwaipayan Ray, Lukas Bulwahn, Ingo Molnar, linux-edac,
linux-kernel
Cc: opensource.kernel, Yang Ruibin
The debugfs_create_dir() function returns error pointers.It
never returns NULL. So use IS_ERR() to check its return value.
Fixes: 011d82611172 ("RAS: Add a Corrected Errors Collector")
Signed-off-by: Yang Ruibin <11162571@vivo.com>
---
drivers/ras/cec.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/ras/cec.c b/drivers/ras/cec.c
index e440b15fbabc..ebd4631b685b 100644
--- a/drivers/ras/cec.c
+++ b/drivers/ras/cec.c
@@ -489,7 +489,7 @@ static int __init create_debugfs_nodes(void)
}
d = debugfs_create_dir("cec", dfs);
- if (!d) {
+ if (IS_ERR(d)) {
pr_warn("Error creating cec debugfs node!\n");
return -1;
}
--
2.34.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH v2] drivers:block:Use IS_ERR() to check debugfs_create_dir() return value
2024-08-22 13:23 [PATCH v2] drivers:block:Use IS_ERR() to check debugfs_create_dir() return value Yang Ruibin
@ 2024-08-23 8:29 ` Jonathan Cameron
0 siblings, 0 replies; 4+ messages in thread
From: Jonathan Cameron @ 2024-08-23 8:29 UTC (permalink / raw)
To: Yang Ruibin
Cc: Tony Luck, Borislav Petkov, Andy Whitcroft, Joe Perches,
Dwaipayan Ray, Lukas Bulwahn, Ingo Molnar, linux-edac,
linux-kernel, opensource.kernel
On Thu, 22 Aug 2024 21:23:58 +0800
Yang Ruibin <11162571@vivo.com> wrote:
Patch title needs an update as this isn't in block and that's not the
style used for this subsystem.
Otherwise fine.
> The debugfs_create_dir() function returns error pointers.It
> never returns NULL. So use IS_ERR() to check its return value.
>
> Fixes: 011d82611172 ("RAS: Add a Corrected Errors Collector")
> Signed-off-by: Yang Ruibin <11162571@vivo.com>
> ---
> drivers/ras/cec.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/ras/cec.c b/drivers/ras/cec.c
> index e440b15fbabc..ebd4631b685b 100644
> --- a/drivers/ras/cec.c
> +++ b/drivers/ras/cec.c
> @@ -489,7 +489,7 @@ static int __init create_debugfs_nodes(void)
> }
>
> d = debugfs_create_dir("cec", dfs);
> - if (!d) {
> + if (IS_ERR(d)) {
> pr_warn("Error creating cec debugfs node!\n");
> return -1;
> }
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2024-08-23 8:30 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-08-22 13:23 [PATCH v2] drivers:block:Use IS_ERR() to check debugfs_create_dir() return value Yang Ruibin
2024-08-23 8:29 ` Jonathan Cameron
-- strict thread matches above, loose matches on Subject: below --
2024-08-22 12:41 Yang Ruibin
2024-08-22 12:50 ` Yang Ruibin
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox