From: Sasha Levin <sashal@kernel.org>
To: linux-kernel@vger.kernel.org, stable@vger.kernel.org
Cc: Moon Yeounsu <yyyynoom@gmail.com>,
Christophe JAILLET <christophe.jaillet@wanadoo.fr>,
"David S . Miller" <davem@davemloft.net>,
Sasha Levin <sashal@kernel.org>,
cooldavid@cooldavid.org, edumazet@google.com, kuba@kernel.org,
pabeni@redhat.com, shannon.nelson@amd.com,
jacob.e.keller@intel.com, netdev@vger.kernel.org
Subject: [PATCH AUTOSEL 6.10 11/24] net: ethernet: use ip_hdrlen() instead of bit shift
Date: Fri, 23 Aug 2024 10:00:33 -0400 [thread overview]
Message-ID: <20240823140121.1974012-11-sashal@kernel.org> (raw)
In-Reply-To: <20240823140121.1974012-1-sashal@kernel.org>
From: Moon Yeounsu <yyyynoom@gmail.com>
[ Upstream commit 9a039eeb71a42c8b13408a1976e300f3898e1be0 ]
`ip_hdr(skb)->ihl << 2` is the same as `ip_hdrlen(skb)`
Therefore, we should use a well-defined function not a bit shift
to find the header length.
It also compresses two lines to a single line.
Signed-off-by: Moon Yeounsu <yyyynoom@gmail.com>
Reviewed-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Sasha Levin <sashal@kernel.org>
---
drivers/net/ethernet/jme.c | 10 ++++------
1 file changed, 4 insertions(+), 6 deletions(-)
diff --git a/drivers/net/ethernet/jme.c b/drivers/net/ethernet/jme.c
index b06e245629739..d8be0e4dcb072 100644
--- a/drivers/net/ethernet/jme.c
+++ b/drivers/net/ethernet/jme.c
@@ -946,15 +946,13 @@ jme_udpsum(struct sk_buff *skb)
if (skb->protocol != htons(ETH_P_IP))
return csum;
skb_set_network_header(skb, ETH_HLEN);
- if ((ip_hdr(skb)->protocol != IPPROTO_UDP) ||
- (skb->len < (ETH_HLEN +
- (ip_hdr(skb)->ihl << 2) +
- sizeof(struct udphdr)))) {
+
+ if (ip_hdr(skb)->protocol != IPPROTO_UDP ||
+ skb->len < (ETH_HLEN + ip_hdrlen(skb) + sizeof(struct udphdr))) {
skb_reset_network_header(skb);
return csum;
}
- skb_set_transport_header(skb,
- ETH_HLEN + (ip_hdr(skb)->ihl << 2));
+ skb_set_transport_header(skb, ETH_HLEN + ip_hdrlen(skb));
csum = udp_hdr(skb)->check;
skb_reset_transport_header(skb);
skb_reset_network_header(skb);
--
2.43.0
next prev parent reply other threads:[~2024-08-23 14:01 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-23 14:00 [PATCH AUTOSEL 6.10 01/24] drm/mediatek: Set sensible cursor width/height values to fix crash Sasha Levin
2024-08-23 14:00 ` [PATCH AUTOSEL 6.10 02/24] ksmbd: override fsids for share path check Sasha Levin
2024-08-23 14:00 ` [PATCH AUTOSEL 6.10 03/24] ksmbd: override fsids for smb2_query_info() Sasha Levin
2024-08-23 14:00 ` [PATCH AUTOSEL 6.10 04/24] usbnet: ipheth: race between ipheth_close and error handling Sasha Levin
2024-08-23 14:00 ` [PATCH AUTOSEL 6.10 05/24] usbnet: ipheth: remove extraneous rx URB length check Sasha Levin
2024-08-23 14:00 ` [PATCH AUTOSEL 6.10 06/24] usbnet: ipheth: drop RX URBs with no payload Sasha Levin
2024-08-23 14:00 ` [PATCH AUTOSEL 6.10 07/24] usbnet: ipheth: do not stop RX on failing RX callback Sasha Levin
2024-08-23 14:00 ` [PATCH AUTOSEL 6.10 08/24] usbnet: ipheth: fix carrier detection in modes 1 and 4 Sasha Levin
2024-08-23 14:00 ` [PATCH AUTOSEL 6.10 09/24] kbuild: rust: skip -fmin-function-alignment in bindgen flags Sasha Levin
2024-08-24 14:45 ` Miguel Ojeda
2024-08-23 14:00 ` [PATCH AUTOSEL 6.10 10/24] rust: add intrinsics to fix `-Os` builds Sasha Levin
2024-08-24 14:45 ` Miguel Ojeda
2024-08-23 14:00 ` Sasha Levin [this message]
2024-08-23 14:00 ` [PATCH AUTOSEL 6.10 12/24] drm: panel-orientation-quirks: Add quirk for Ayn Loki Zero Sasha Levin
2024-08-23 14:00 ` [PATCH AUTOSEL 6.10 13/24] drm: panel-orientation-quirks: Add quirk for Ayn Loki Max Sasha Levin
2024-08-23 14:00 ` [PATCH AUTOSEL 6.10 14/24] net: phy: vitesse: repair vsc73xx autonegotiation Sasha Levin
2024-08-23 14:00 ` [PATCH AUTOSEL 6.10 15/24] powerpc/mm: Fix boot warning with hugepages and CONFIG_DEBUG_VIRTUAL Sasha Levin
2024-08-23 14:00 ` [PATCH AUTOSEL 6.10 16/24] wifi: mt76: mt7921: fix NULL pointer access in mt7921_ipv6_addr_change Sasha Levin
2024-08-23 14:00 ` [PATCH AUTOSEL 6.10 17/24] Squashfs: sanity check symbolic link size Sasha Levin
2024-08-23 14:00 ` [PATCH AUTOSEL 6.10 18/24] drm/amdgpu: Update kmd_fw_shared for VCN5 Sasha Levin
2024-08-23 14:00 ` [PATCH AUTOSEL 6.10 19/24] of/irq: Prevent device address out-of-bounds read in interrupt map walk Sasha Levin
2024-08-23 14:00 ` [PATCH AUTOSEL 6.10 20/24] lib/generic-radix-tree.c: Fix rare race in __genradix_ptr_alloc() Sasha Levin
2024-08-23 14:00 ` [PATCH AUTOSEL 6.10 21/24] net: hns3: void array out of bound when loop tnl_num Sasha Levin
2024-08-23 14:00 ` [PATCH AUTOSEL 6.10 22/24] net: hns3: use correct release function during uninitialization Sasha Levin
2024-08-23 14:00 ` [PATCH AUTOSEL 6.10 23/24] kunit/overflow: Fix UB in overflow_allocation_test Sasha Levin
2024-08-23 14:00 ` [PATCH AUTOSEL 6.10 24/24] btrfs: update target inode's ctime on unlink Sasha Levin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240823140121.1974012-11-sashal@kernel.org \
--to=sashal@kernel.org \
--cc=christophe.jaillet@wanadoo.fr \
--cc=cooldavid@cooldavid.org \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=jacob.e.keller@intel.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=shannon.nelson@amd.com \
--cc=stable@vger.kernel.org \
--cc=yyyynoom@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox