The Linux Kernel Mailing List
 help / color / mirror / Atom feed
From: Sasha Levin <sashal@kernel.org>
To: linux-kernel@vger.kernel.org, stable@vger.kernel.org
Cc: Namjae Jeon <linkinjeon@kernel.org>,
	Sangsoo Lee <constant.lee@samsung.com>,
	Steve French <stfrench@microsoft.com>,
	Sasha Levin <sashal@kernel.org>,
	sfrench@samba.org, linux-cifs@vger.kernel.org
Subject: [PATCH AUTOSEL 6.10 03/24] ksmbd: override fsids for smb2_query_info()
Date: Fri, 23 Aug 2024 10:00:25 -0400	[thread overview]
Message-ID: <20240823140121.1974012-3-sashal@kernel.org> (raw)
In-Reply-To: <20240823140121.1974012-1-sashal@kernel.org>

From: Namjae Jeon <linkinjeon@kernel.org>

[ Upstream commit f6bd41280a44dcc2e0a25ed72617d25f586974a7 ]

Sangsoo reported that a DAC denial error occurred when accessing
files through the ksmbd thread. This patch override fsids for
smb2_query_info().

Reported-by: Sangsoo Lee <constant.lee@samsung.com>
Signed-off-by: Namjae Jeon <linkinjeon@kernel.org>
Signed-off-by: Steve French <stfrench@microsoft.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>
---
 fs/smb/server/smb2pdu.c | 7 +++++++
 1 file changed, 7 insertions(+)

diff --git a/fs/smb/server/smb2pdu.c b/fs/smb/server/smb2pdu.c
index 373c7ecbf8033..49adf6e65cb46 100644
--- a/fs/smb/server/smb2pdu.c
+++ b/fs/smb/server/smb2pdu.c
@@ -5596,6 +5596,11 @@ int smb2_query_info(struct ksmbd_work *work)
 
 	ksmbd_debug(SMB, "GOT query info request\n");
 
+	if (ksmbd_override_fsids(work)) {
+		rc = -ENOMEM;
+		goto err_out;
+	}
+
 	switch (req->InfoType) {
 	case SMB2_O_INFO_FILE:
 		ksmbd_debug(SMB, "GOT SMB2_O_INFO_FILE\n");
@@ -5614,6 +5619,7 @@ int smb2_query_info(struct ksmbd_work *work)
 			    req->InfoType);
 		rc = -EOPNOTSUPP;
 	}
+	ksmbd_revert_fsids(work);
 
 	if (!rc) {
 		rsp->StructureSize = cpu_to_le16(9);
@@ -5623,6 +5629,7 @@ int smb2_query_info(struct ksmbd_work *work)
 					le32_to_cpu(rsp->OutputBufferLength));
 	}
 
+err_out:
 	if (rc < 0) {
 		if (rc == -EACCES)
 			rsp->hdr.Status = STATUS_ACCESS_DENIED;
-- 
2.43.0


  parent reply	other threads:[~2024-08-23 14:01 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-08-23 14:00 [PATCH AUTOSEL 6.10 01/24] drm/mediatek: Set sensible cursor width/height values to fix crash Sasha Levin
2024-08-23 14:00 ` [PATCH AUTOSEL 6.10 02/24] ksmbd: override fsids for share path check Sasha Levin
2024-08-23 14:00 ` Sasha Levin [this message]
2024-08-23 14:00 ` [PATCH AUTOSEL 6.10 04/24] usbnet: ipheth: race between ipheth_close and error handling Sasha Levin
2024-08-23 14:00 ` [PATCH AUTOSEL 6.10 05/24] usbnet: ipheth: remove extraneous rx URB length check Sasha Levin
2024-08-23 14:00 ` [PATCH AUTOSEL 6.10 06/24] usbnet: ipheth: drop RX URBs with no payload Sasha Levin
2024-08-23 14:00 ` [PATCH AUTOSEL 6.10 07/24] usbnet: ipheth: do not stop RX on failing RX callback Sasha Levin
2024-08-23 14:00 ` [PATCH AUTOSEL 6.10 08/24] usbnet: ipheth: fix carrier detection in modes 1 and 4 Sasha Levin
2024-08-23 14:00 ` [PATCH AUTOSEL 6.10 09/24] kbuild: rust: skip -fmin-function-alignment in bindgen flags Sasha Levin
2024-08-24 14:45   ` Miguel Ojeda
2024-08-23 14:00 ` [PATCH AUTOSEL 6.10 10/24] rust: add intrinsics to fix `-Os` builds Sasha Levin
2024-08-24 14:45   ` Miguel Ojeda
2024-08-23 14:00 ` [PATCH AUTOSEL 6.10 11/24] net: ethernet: use ip_hdrlen() instead of bit shift Sasha Levin
2024-08-23 14:00 ` [PATCH AUTOSEL 6.10 12/24] drm: panel-orientation-quirks: Add quirk for Ayn Loki Zero Sasha Levin
2024-08-23 14:00 ` [PATCH AUTOSEL 6.10 13/24] drm: panel-orientation-quirks: Add quirk for Ayn Loki Max Sasha Levin
2024-08-23 14:00 ` [PATCH AUTOSEL 6.10 14/24] net: phy: vitesse: repair vsc73xx autonegotiation Sasha Levin
2024-08-23 14:00 ` [PATCH AUTOSEL 6.10 15/24] powerpc/mm: Fix boot warning with hugepages and CONFIG_DEBUG_VIRTUAL Sasha Levin
2024-08-23 14:00 ` [PATCH AUTOSEL 6.10 16/24] wifi: mt76: mt7921: fix NULL pointer access in mt7921_ipv6_addr_change Sasha Levin
2024-08-23 14:00 ` [PATCH AUTOSEL 6.10 17/24] Squashfs: sanity check symbolic link size Sasha Levin
2024-08-23 14:00 ` [PATCH AUTOSEL 6.10 18/24] drm/amdgpu: Update kmd_fw_shared for VCN5 Sasha Levin
2024-08-23 14:00 ` [PATCH AUTOSEL 6.10 19/24] of/irq: Prevent device address out-of-bounds read in interrupt map walk Sasha Levin
2024-08-23 14:00 ` [PATCH AUTOSEL 6.10 20/24] lib/generic-radix-tree.c: Fix rare race in __genradix_ptr_alloc() Sasha Levin
2024-08-23 14:00 ` [PATCH AUTOSEL 6.10 21/24] net: hns3: void array out of bound when loop tnl_num Sasha Levin
2024-08-23 14:00 ` [PATCH AUTOSEL 6.10 22/24] net: hns3: use correct release function during uninitialization Sasha Levin
2024-08-23 14:00 ` [PATCH AUTOSEL 6.10 23/24] kunit/overflow: Fix UB in overflow_allocation_test Sasha Levin
2024-08-23 14:00 ` [PATCH AUTOSEL 6.10 24/24] btrfs: update target inode's ctime on unlink Sasha Levin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240823140121.1974012-3-sashal@kernel.org \
    --to=sashal@kernel.org \
    --cc=constant.lee@samsung.com \
    --cc=linkinjeon@kernel.org \
    --cc=linux-cifs@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=sfrench@samba.org \
    --cc=stable@vger.kernel.org \
    --cc=stfrench@microsoft.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox