From: Jeff Layton <jlayton@kernel.org>
To: Chuck Lever <chuck.lever@oracle.com>, Neil Brown <neilb@suse.de>,
Olga Kornievskaia <kolga@netapp.com>,
Dai Ngo <Dai.Ngo@oracle.com>, Tom Talpey <tom@talpey.com>
Cc: linux-nfs@vger.kernel.org, linux-kernel@vger.kernel.org,
Jeff Layton <jlayton@kernel.org>
Subject: [PATCH 1/3] nfsd: add more info to WARN_ON_ONCE on failed callbacks
Date: Mon, 26 Aug 2024 08:50:11 -0400 [thread overview]
Message-ID: <20240826-nfsd-cb-v1-1-82d3a4e5913b@kernel.org> (raw)
In-Reply-To: <20240826-nfsd-cb-v1-0-82d3a4e5913b@kernel.org>
Currently, you get the warning and stack trace, but nothing is printed
about the relevant error codes. Add that in.
Signed-off-by: Jeff Layton <jlayton@kernel.org>
---
fs/nfsd/nfs4callback.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/fs/nfsd/nfs4callback.c b/fs/nfsd/nfs4callback.c
index d756f443fc44..dee9477cc5b5 100644
--- a/fs/nfsd/nfs4callback.c
+++ b/fs/nfsd/nfs4callback.c
@@ -1333,7 +1333,8 @@ static void nfsd4_cb_done(struct rpc_task *task, void *calldata)
return;
if (cb->cb_status) {
- WARN_ON_ONCE(task->tk_status);
+ WARN_ONCE(task->tk_status, "cb_status=%d tk_status=%d",
+ cb->cb_status, task->tk_status);
task->tk_status = cb->cb_status;
}
--
2.46.0
next prev parent reply other threads:[~2024-08-26 12:50 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-26 12:50 [PATCH 0/3] nfsd: callback debugging improvements Jeff Layton
2024-08-26 12:50 ` Jeff Layton [this message]
2024-09-09 17:23 ` [PATCH 1/3] nfsd: add more info to WARN_ON_ONCE on failed callbacks Olga Kornievskaia
2024-09-09 17:34 ` Jeff Layton
2024-12-19 21:23 ` Olga Kornievskaia
2024-12-19 21:33 ` Jeff Layton
2024-12-19 21:42 ` Olga Kornievskaia
2024-08-26 12:50 ` [PATCH 2/3] nfsd: track the main opcode for callbacks Jeff Layton
2024-08-26 12:50 ` [PATCH 3/3] nfsd: add more nfsd_cb tracepoints Jeff Layton
2024-08-26 16:34 ` [PATCH 0/3] nfsd: callback debugging improvements Chuck Lever
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240826-nfsd-cb-v1-1-82d3a4e5913b@kernel.org \
--to=jlayton@kernel.org \
--cc=Dai.Ngo@oracle.com \
--cc=chuck.lever@oracle.com \
--cc=kolga@netapp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nfs@vger.kernel.org \
--cc=neilb@suse.de \
--cc=tom@talpey.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox