Re: [PATCH 1/3] nfsd: add more info to WARN_ON_ONCE on failed callbacks

[Jeff Layton <jlayton@kernel.org>]

On Thu, 2024-12-19 at 16:23 -0500, Olga Kornievskaia wrote:
> On Mon, Aug 26, 2024 at 8:54 AM Jeff Layton <jlayton@kernel.org> wrote:
> > 
> > Currently, you get the warning and stack trace, but nothing is printed
> > about the relevant error codes. Add that in.
> > 
> > Signed-off-by: Jeff Layton <jlayton@kernel.org>
> > ---
> >  fs/nfsd/nfs4callback.c | 3 ++-
> >  1 file changed, 2 insertions(+), 1 deletion(-)
> > 
> > diff --git a/fs/nfsd/nfs4callback.c b/fs/nfsd/nfs4callback.c
> > index d756f443fc44..dee9477cc5b5 100644
> > --- a/fs/nfsd/nfs4callback.c
> > +++ b/fs/nfsd/nfs4callback.c
> > @@ -1333,7 +1333,8 @@ static void nfsd4_cb_done(struct rpc_task *task, void *calldata)
> >                 return;
> > 
> >         if (cb->cb_status) {
> > -               WARN_ON_ONCE(task->tk_status);
> > +               WARN_ONCE(task->tk_status, "cb_status=%d tk_status=%d",
> > +                         cb->cb_status, task->tk_status);
> 
> Can we add cb->cb_ops->opcode to that as well?

I'd be fine with that, but this patch is already merged. Care to
propose one that could go on top?

> 
> >                 task->tk_status = cb->cb_status;
> >         }
> > 
> > 
> > --
> > 2.46.0
> > 
> > 

-- 
Jeff Layton <jlayton@kernel.org>