[PATCH -next 0/3] media: enable module autoloading

[PATCH -next 0/3] media: enable module autoloading

[Liao Chen]

Hi all,

This patchset aims to enable autoloading of some media modules.
By registering MDT, the kernel is allowed to automatically bind 
modules to devices that match the specified compatible strings.

Liao Chen (3):
  media: v4l2-subdev: enable module autoloading
  media: platform: rzg2l-cru: rzg2l-csi2: enable module autoloading
  media: tegra_cec: enable module autoloading

 drivers/media/cec/platform/tegra/tegra_cec.c          | 1 +
 drivers/media/i2c/mt9v111.c                           | 1 +
 drivers/media/platform/renesas/rzg2l-cru/rzg2l-csi2.c | 1 +
 3 files changed, 3 insertions(+)

-- 
2.34.1

[PATCH -next 1/3] media: v4l2-subdev: enable module autoloading

[Liao Chen]

Add MODULE_DEVICE_TABLE(), so modules could be properly autoloaded
based on the alias from of_device_id table.

Signed-off-by: Liao Chen <liaochen4@huawei.com>
---
 drivers/media/i2c/mt9v111.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/media/i2c/mt9v111.c b/drivers/media/i2c/mt9v111.c
index b0b98ed3c150..b6a2623798c5 100644
--- a/drivers/media/i2c/mt9v111.c
+++ b/drivers/media/i2c/mt9v111.c
@@ -1265,6 +1265,7 @@ static const struct of_device_id mt9v111_of_match[] = {
 	{ .compatible = "aptina,mt9v111", },
 	{ /* sentinel */ },
 };
+MODULE_DEVICE_TABLE(of, mt9v111_of_match);
 
 static struct i2c_driver mt9v111_driver = {
 	.driver = {
-- 
2.34.1

RE: [PATCH -next 1/3] media: v4l2-subdev: enable module autoloading

[Biju Das]

Hi Liao Chen,

Thanks for the patch.

> -----Original Message-----
> From: Liao Chen <liaochen4@huawei.com>
> Sent: Thursday, August 29, 2024 8:54 AM
> Subject: [PATCH -next 1/3] media: v4l2-subdev: enable module autoloading

Commit header is wrong.

> 
> Add MODULE_DEVICE_TABLE(), so modules could be properly autoloaded based on the alias from
> of_device_id table.
> 
> Signed-off-by: Liao Chen <liaochen4@huawei.com>
> ---
>  drivers/media/i2c/mt9v111.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/media/i2c/mt9v111.c b/drivers/media/i2c/mt9v111.c index
> b0b98ed3c150..b6a2623798c5 100644
> --- a/drivers/media/i2c/mt9v111.c
> +++ b/drivers/media/i2c/mt9v111.c
> @@ -1265,6 +1265,7 @@ static const struct of_device_id mt9v111_of_match[] = {
>  	{ .compatible = "aptina,mt9v111", },
>  	{ /* sentinel */ },

Nit: Comma can be dropped from terminator entry as a separate patch.

Cheers,
Biju

>  };
> +MODULE_DEVICE_TABLE(of, mt9v111_of_match);
> 
>  static struct i2c_driver mt9v111_driver = {
>  	.driver = {
> --
> 2.34.1

Re: [PATCH -next 1/3] media: v4l2-subdev: enable module autoloading

[Laurent Pinchart]

On Thu, Aug 29, 2024 at 08:27:06AM +0000, Biju Das wrote:
> Hi Liao Chen,
> On Thursday, August 29, 2024 8:54 AM, Liao Chen wrote:
> > Subject: [PATCH -next 1/3] media: v4l2-subdev: enable module autoloading
> 
> Commit header is wrong.

Indeed, it should be

media: i2c: mt9v111: Enable module autoloading

> > Add MODULE_DEVICE_TABLE(), so modules could be properly autoloaded based on the alias from
> > of_device_id table.

Please also reflow the commit message to 72 columns. With those issues
fixed,

Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>

> > 
> > Signed-off-by: Liao Chen <liaochen4@huawei.com>
> > ---
> >  drivers/media/i2c/mt9v111.c | 1 +
> >  1 file changed, 1 insertion(+)
> > 
> > diff --git a/drivers/media/i2c/mt9v111.c b/drivers/media/i2c/mt9v111.c index
> > b0b98ed3c150..b6a2623798c5 100644
> > --- a/drivers/media/i2c/mt9v111.c
> > +++ b/drivers/media/i2c/mt9v111.c
> > @@ -1265,6 +1265,7 @@ static const struct of_device_id mt9v111_of_match[] = {
> >  	{ .compatible = "aptina,mt9v111", },
> >  	{ /* sentinel */ },
> 
> Nit: Comma can be dropped from terminator entry as a separate patch.
> 
> Cheers,
> Biju
> 
> >  };
> > +MODULE_DEVICE_TABLE(of, mt9v111_of_match);
> > 
> >  static struct i2c_driver mt9v111_driver = {
> >  	.driver = {

-- 
Regards,

Laurent Pinchart

Re: [PATCH -next 1/3] media: v4l2-subdev: enable module autoloading

[liaochen (A)]

On 2024/8/29 17:45, Laurent Pinchart wrote:
> On Thu, Aug 29, 2024 at 08:27:06AM +0000, Biju Das wrote:
>> Hi Liao Chen,
>> On Thursday, August 29, 2024 8:54 AM, Liao Chen wrote:
>>> Subject: [PATCH -next 1/3] media: v4l2-subdev: enable module autoloading
>>
>> Commit header is wrong.
> 
> Indeed, it should be
> 
> media: i2c: mt9v111: Enable module autoloading
> 
>>> Add MODULE_DEVICE_TABLE(), so modules could be properly autoloaded based on the alias from
>>> of_device_id table.
> 
> Please also reflow the commit message to 72 columns. With those issues
> fixed,
> 
> Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> 
>>>
>>> Signed-off-by: Liao Chen <liaochen4@huawei.com>
>>> ---
>>>   drivers/media/i2c/mt9v111.c | 1 +
>>>   1 file changed, 1 insertion(+)
>>>
>>> diff --git a/drivers/media/i2c/mt9v111.c b/drivers/media/i2c/mt9v111.c index
>>> b0b98ed3c150..b6a2623798c5 100644
>>> --- a/drivers/media/i2c/mt9v111.c
>>> +++ b/drivers/media/i2c/mt9v111.c
>>> @@ -1265,6 +1265,7 @@ static const struct of_device_id mt9v111_of_match[] = {
>>>   	{ .compatible = "aptina,mt9v111", },
>>>   	{ /* sentinel */ },
>>
>> Nit: Comma can be dropped from terminator entry as a separate patch.
>>
>> Cheers,
>> Biju
>>
>>>   };
>>> +MODULE_DEVICE_TABLE(of, mt9v111_of_match);
>>>
>>>   static struct i2c_driver mt9v111_driver = {
>>>   	.driver = {
> 
Thanks for pointing out, just sent a patch series with these issues fixed.

Thanks,
Chen

[PATCH -next 2/3] media: platform: rzg2l-cru: rzg2l-csi2: enable module autoloading

[Liao Chen]

Add MODULE_DEVICE_TABLE(), so modules could be properly autoloaded
based on the alias from of_device_id table.

Signed-off-by: Liao Chen <liaochen4@huawei.com>
---
 drivers/media/platform/renesas/rzg2l-cru/rzg2l-csi2.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/media/platform/renesas/rzg2l-cru/rzg2l-csi2.c b/drivers/media/platform/renesas/rzg2l-cru/rzg2l-csi2.c
index e68fcdaea207..c7fdee347ac8 100644
--- a/drivers/media/platform/renesas/rzg2l-cru/rzg2l-csi2.c
+++ b/drivers/media/platform/renesas/rzg2l-cru/rzg2l-csi2.c
@@ -865,6 +865,7 @@ static const struct of_device_id rzg2l_csi2_of_table[] = {
 	{ .compatible = "renesas,rzg2l-csi2", },
 	{ /* sentinel */ }
 };
+MODULE_DEVICE_TABLE(of, rzg2l_csi2_of_table);
 
 static struct platform_driver rzg2l_csi2_pdrv = {
 	.remove_new = rzg2l_csi2_remove,
-- 
2.34.1

RE: [PATCH -next 2/3] media: platform: rzg2l-cru: rzg2l-csi2: enable module autoloading

[Biju Das]

Hi Liao,

It is same as [1]

[1] https://git.linuxtv.org/media_stage.git/commit/?id=07668fb0f867388bfdac0b60dbf51a4ad789f8e7

Cheers,
Biju

> -----Original Message-----
> From: Liao Chen <liaochen4@huawei.com>
> Sent: Thursday, August 29, 2024 8:54 AM
> To: linux-tegra@vger.kernel.org; linux-media@vger.kernel.org; linux-kernel@vger.kernel.org
> Cc: hverkuil-cisco@xs4all.nl; mchehab@kernel.org; thierry.reding@gmail.com; jonathanh@nvidia.com;
> jacopo@jmondi.org; sakari.ailus@linux.intel.com; laurent.pinchart@ideasonboard.com; Biju Das
> <biju.das.jz@bp.renesas.com>; tomi.valkeinen@ideasonboard.com; liaochen4@huawei.com
> Subject: [PATCH -next 2/3] media: platform: rzg2l-cru: rzg2l-csi2: enable module autoloading
> 
> Add MODULE_DEVICE_TABLE(), so modules could be properly autoloaded based on the alias from
> of_device_id table.
> 
> Signed-off-by: Liao Chen <liaochen4@huawei.com>
> ---
>  drivers/media/platform/renesas/rzg2l-cru/rzg2l-csi2.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/media/platform/renesas/rzg2l-cru/rzg2l-csi2.c
> b/drivers/media/platform/renesas/rzg2l-cru/rzg2l-csi2.c
> index e68fcdaea207..c7fdee347ac8 100644
> --- a/drivers/media/platform/renesas/rzg2l-cru/rzg2l-csi2.c
> +++ b/drivers/media/platform/renesas/rzg2l-cru/rzg2l-csi2.c
> @@ -865,6 +865,7 @@ static const struct of_device_id rzg2l_csi2_of_table[] = {
>  	{ .compatible = "renesas,rzg2l-csi2", },
>  	{ /* sentinel */ }
>  };
> +MODULE_DEVICE_TABLE(of, rzg2l_csi2_of_table);
> 
>  static struct platform_driver rzg2l_csi2_pdrv = {
>  	.remove_new = rzg2l_csi2_remove,
> --
> 2.34.1

[PATCH -next 3/3] media: tegra_cec: enable module autoloading

[Liao Chen]

Add MODULE_DEVICE_TABLE(), so modules could be properly autoloaded
based on the alias from of_device_id table.

Signed-off-by: Liao Chen <liaochen4@huawei.com>
---
 drivers/media/cec/platform/tegra/tegra_cec.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/media/cec/platform/tegra/tegra_cec.c b/drivers/media/cec/platform/tegra/tegra_cec.c
index 7c1022cee1e8..a199a4158942 100644
--- a/drivers/media/cec/platform/tegra/tegra_cec.c
+++ b/drivers/media/cec/platform/tegra/tegra_cec.c
@@ -458,6 +458,7 @@ static const struct of_device_id tegra_cec_of_match[] = {
 	{ .compatible = "nvidia,tegra210-cec", },
 	{},
 };
+MODULE_DEVICE_TABLE(of, tegra_cec_of_match);
 
 static struct platform_driver tegra_cec_driver = {
 	.driver = {
-- 
2.34.1