* [PATCH v5] staging: rtl8192e: Fix multiple assignments in rtl_wx.c
@ 2024-08-29 11:36 Alien Wesley
2024-08-29 18:21 ` Philipp Hortmann
0 siblings, 1 reply; 2+ messages in thread
From: Alien Wesley @ 2024-08-29 11:36 UTC (permalink / raw)
To: gregkh, linux-staging, linux-kernel, ~lkcamp/patches
Separated assignments for pairwise_key_type and group_key_type
in order to silence the following checkpatch warning.
CHECK: multiple assignments should be avoided.
Signed-off-by: Alien Wesley <alienwesley51@gmail.com>
---
V5: Line number removed from subject
v4: Squash v1 and v3
v3: Fix typo in commit message.
v2: Removed two spaces in front of "=".
---
drivers/staging/rtl8192e/rtl8192e/rtl_wx.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/staging/rtl8192e/rtl8192e/rtl_wx.c b/drivers/staging/rtl8192e/rtl8192e/rtl_wx.c
index fc8e7f73b2a4..67c4793e0fc1 100644
--- a/drivers/staging/rtl8192e/rtl8192e/rtl_wx.c
+++ b/drivers/staging/rtl8192e/rtl8192e/rtl_wx.c
@@ -526,7 +526,8 @@ static int _rtl92e_wx_set_enc(struct net_device *dev,
mutex_unlock(&priv->wx_mutex);
if (wrqu->encoding.flags & IW_ENCODE_DISABLED) {
- ieee->pairwise_key_type = ieee->group_key_type = KEY_TYPE_NA;
+ ieee->pairwise_key_type = KEY_TYPE_NA;
+ ieee->group_key_type = KEY_TYPE_NA;
rtl92e_cam_reset(dev);
memset(priv->rtllib->swcamtable, 0,
sizeof(struct sw_cam_table) * 32);
--
2.34.1
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH v5] staging: rtl8192e: Fix multiple assignments in rtl_wx.c
2024-08-29 11:36 [PATCH v5] staging: rtl8192e: Fix multiple assignments in rtl_wx.c Alien Wesley
@ 2024-08-29 18:21 ` Philipp Hortmann
0 siblings, 0 replies; 2+ messages in thread
From: Philipp Hortmann @ 2024-08-29 18:21 UTC (permalink / raw)
To: Alien Wesley, gregkh, linux-staging, linux-kernel,
~lkcamp/patches
On 8/29/24 13:36, Alien Wesley wrote:
> Separated assignments for pairwise_key_type and group_key_type
> in order to silence the following checkpatch warning.
>
> CHECK: multiple assignments should be avoided.
>
> Signed-off-by: Alien Wesley <alienwesley51@gmail.com>
> ---
> V5: Line number removed from subject
> v4: Squash v1 and v3
> v3: Fix typo in commit message.
> v2: Removed two spaces in front of "=".
> ---
> drivers/staging/rtl8192e/rtl8192e/rtl_wx.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/staging/rtl8192e/rtl8192e/rtl_wx.c b/drivers/staging/rtl8192e/rtl8192e/rtl_wx.c
> index fc8e7f73b2a4..67c4793e0fc1 100644
> --- a/drivers/staging/rtl8192e/rtl8192e/rtl_wx.c
> +++ b/drivers/staging/rtl8192e/rtl8192e/rtl_wx.c
> @@ -526,7 +526,8 @@ static int _rtl92e_wx_set_enc(struct net_device *dev,
> mutex_unlock(&priv->wx_mutex);
>
> if (wrqu->encoding.flags & IW_ENCODE_DISABLED) {
> - ieee->pairwise_key_type = ieee->group_key_type = KEY_TYPE_NA;
> + ieee->pairwise_key_type = KEY_TYPE_NA;
> + ieee->group_key_type = KEY_TYPE_NA;
> rtl92e_cam_reset(dev);
> memset(priv->rtllib->swcamtable, 0,
> sizeof(struct sw_cam_table) * 32);
Tested-by: Philipp Hortmann <philipp.g.hortmann@gmail.com>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2024-08-29 18:21 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-08-29 11:36 [PATCH v5] staging: rtl8192e: Fix multiple assignments in rtl_wx.c Alien Wesley
2024-08-29 18:21 ` Philipp Hortmann
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox