[PATCH -next 0/2] media: i2c: mt9v111: workaround

[PATCH -next 0/2] media: i2c: mt9v111: workaround

[Liao Chen]

Hi all, 

This patchset enables module autoloading feature of mt9v111 module and 
cleans the code up.

Liao Chen (2):
  media: i2c: mt9v111: Add missing MODULE_DEVICE_TABLE
  media: i2c: mt9v111: drop redundant comma

 drivers/media/i2c/mt9v111.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

-- 
2.34.1

[PATCH -next 1/2] media: i2c: mt9v111: Enable module autoloading

[Liao Chen]

Add MODULE_DEVICE_TABLE(), so modules could be properly autoloaded based
on the alias from of_device_id table.

Signed-off-by: Liao Chen <liaochen4@huawei.com>
---
 drivers/media/i2c/mt9v111.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/media/i2c/mt9v111.c b/drivers/media/i2c/mt9v111.c
index b0b98ed3c150..b6a2623798c5 100644
--- a/drivers/media/i2c/mt9v111.c
+++ b/drivers/media/i2c/mt9v111.c
@@ -1265,6 +1265,7 @@ static const struct of_device_id mt9v111_of_match[] = {
 	{ .compatible = "aptina,mt9v111", },
 	{ /* sentinel */ },
 };
+MODULE_DEVICE_TABLE(of, mt9v111_of_match);
 
 static struct i2c_driver mt9v111_driver = {
 	.driver = {
-- 
2.34.1

Re: [PATCH -next 1/2] media: i2c: mt9v111: Enable module autoloading

[Laurent Pinchart]

Hi Liao,

Thank you for the patch.

On Thu, Aug 29, 2024 at 12:52:02PM +0000, Liao Chen wrote:
> Add MODULE_DEVICE_TABLE(), so modules could be properly autoloaded based
> on the alias from of_device_id table.
> 
> Signed-off-by: Liao Chen <liaochen4@huawei.com>

Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>

Sakari, I expect you will merge this series through your tree.

> ---
>  drivers/media/i2c/mt9v111.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/media/i2c/mt9v111.c b/drivers/media/i2c/mt9v111.c
> index b0b98ed3c150..b6a2623798c5 100644
> --- a/drivers/media/i2c/mt9v111.c
> +++ b/drivers/media/i2c/mt9v111.c
> @@ -1265,6 +1265,7 @@ static const struct of_device_id mt9v111_of_match[] = {
>  	{ .compatible = "aptina,mt9v111", },
>  	{ /* sentinel */ },
>  };
> +MODULE_DEVICE_TABLE(of, mt9v111_of_match);
>  
>  static struct i2c_driver mt9v111_driver = {
>  	.driver = {

-- 
Regards,

Laurent Pinchart

Re: [PATCH -next 1/2] media: i2c: mt9v111: Enable module autoloading

[Sakari Ailus]

On Thu, Aug 29, 2024 at 04:47:08PM +0300, Laurent Pinchart wrote:
> Hi Liao,
> 
> Thank you for the patch.
> 
> On Thu, Aug 29, 2024 at 12:52:02PM +0000, Liao Chen wrote:
> > Add MODULE_DEVICE_TABLE(), so modules could be properly autoloaded based
> > on the alias from of_device_id table.
> > 
> > Signed-off-by: Liao Chen <liaochen4@huawei.com>
> 
> Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> 
> Sakari, I expect you will merge this series through your tree.

Yes, they were in my previous PR to Hans and in media stage tree now.

-- 
Sakari Ailus

[PATCH -next 2/2] media: i2c: mt9v111: Drop redundant comma

[Liao Chen]

Drop the redundant comma from mt9v111_of_match array to make the code
clean.

Signed-off-by: Liao Chen <liaochen4@huawei.com>
---
 drivers/media/i2c/mt9v111.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/media/i2c/mt9v111.c b/drivers/media/i2c/mt9v111.c
index b6a2623798c5..723fe138e7bc 100644
--- a/drivers/media/i2c/mt9v111.c
+++ b/drivers/media/i2c/mt9v111.c
@@ -1263,7 +1263,7 @@ static void mt9v111_remove(struct i2c_client *client)
 
 static const struct of_device_id mt9v111_of_match[] = {
 	{ .compatible = "aptina,mt9v111", },
-	{ /* sentinel */ },
+	{ /* sentinel */ }
 };
 MODULE_DEVICE_TABLE(of, mt9v111_of_match);
 
-- 
2.34.1

RE: [PATCH -next 2/2] media: i2c: mt9v111: Drop redundant comma

[Biju Das]

Hi Liao Chen,

> -----Original Message-----
> From: Liao Chen <liaochen4@huawei.com>
> Sent: Thursday, August 29, 2024 1:52 PM
> Subject: [PATCH -next 2/2] media: i2c: mt9v111: Drop redundant comma
> 
> Drop the redundant comma from mt9v111_of_match array to make the code clean.

LGTM.

Reviewed-by: Biju Das <biju.das.jz@bp.renesas.com>

Actually, Removing the trailing comma in the terminator entry for the ID table
making code robust against (theoretical) misrebases or other similar things
where the new entry goes _after_ the termination without the compiler noticing."


> 
> Signed-off-by: Liao Chen <liaochen4@huawei.com>
> ---
>  drivers/media/i2c/mt9v111.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/media/i2c/mt9v111.c b/drivers/media/i2c/mt9v111.c index
> b6a2623798c5..723fe138e7bc 100644
> --- a/drivers/media/i2c/mt9v111.c
> +++ b/drivers/media/i2c/mt9v111.c
> @@ -1263,7 +1263,7 @@ static void mt9v111_remove(struct i2c_client *client)
> 
>  static const struct of_device_id mt9v111_of_match[] = {
>  	{ .compatible = "aptina,mt9v111", },
> -	{ /* sentinel */ },
> +	{ /* sentinel */ }
>  };
>  MODULE_DEVICE_TABLE(of, mt9v111_of_match);
> 
> --
> 2.34.1

Re: [PATCH -next 2/2] media: i2c: mt9v111: Drop redundant comma

[Laurent Pinchart]

Hi Liao,

Thank you for the patch.

On Thu, Aug 29, 2024 at 12:52:03PM +0000, Liao Chen wrote:
> Drop the redundant comma from mt9v111_of_match array to make the code
> clean.
> 
> Signed-off-by: Liao Chen <liaochen4@huawei.com>

Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>

> ---
>  drivers/media/i2c/mt9v111.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/media/i2c/mt9v111.c b/drivers/media/i2c/mt9v111.c
> index b6a2623798c5..723fe138e7bc 100644
> --- a/drivers/media/i2c/mt9v111.c
> +++ b/drivers/media/i2c/mt9v111.c
> @@ -1263,7 +1263,7 @@ static void mt9v111_remove(struct i2c_client *client)
>  
>  static const struct of_device_id mt9v111_of_match[] = {
>  	{ .compatible = "aptina,mt9v111", },
> -	{ /* sentinel */ },
> +	{ /* sentinel */ }
>  };
>  MODULE_DEVICE_TABLE(of, mt9v111_of_match);
>  

-- 
Regards,

Laurent Pinchart