public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Greg KH <gregkh@linuxfoundation.org>
To: Ba Jing <bajing@cmss.chinamobile.com>
Cc: arve@android.com, tkjos@android.com, maco@android.com,
	joel@joelfernandes.org, brauner@kernel.org, cmllamas@google.com,
	surenb@google.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v4] binder: modify the comment for binder_proc_unlock
Date: Tue, 3 Sep 2024 12:02:08 +0200	[thread overview]
Message-ID: <2024090338-crimp-mountable-54d7@gregkh> (raw)
In-Reply-To: <20240902033754.2708-1-bajing@cmss.chinamobile.com>

On Mon, Sep 02, 2024 at 11:37:54AM +0800, Ba Jing wrote:
> Modify the comment for binder_proc_unlock() to clearly indicate which spinlock it releases and to better match the acquire comment block in binder_proc_lock().
> 
> Notes:
> v1: https://lore.kernel.org/all/20240830073743.2052-1-bajing@cmss.chinamobile.com/
> 
> v2: Reword commit log per suggestions from cmllamas@
> https://lore.kernel.org/all/20240902013636.1739-1-bajing@cmss.chinamobile.com/
> 
> v3: Wrap commit message. Add version history.
> https://lore.kernel.org/all/20240902025720.2334-1-bajing@cmss.chinamobile.com/
> 
> v4: Modify the commit information.

Again, all of these "what changed in what version" needs to go below the
--- line.

Also, please wrap your changelog text at 72 columns, like your editor
asked you to :)

thanks,

greg k-h

      reply	other threads:[~2024-09-03 10:34 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-09-02  3:37 [PATCH v4] binder: modify the comment for binder_proc_unlock Ba Jing
2024-09-03 10:02 ` Greg KH [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2024090338-crimp-mountable-54d7@gregkh \
    --to=gregkh@linuxfoundation.org \
    --cc=arve@android.com \
    --cc=bajing@cmss.chinamobile.com \
    --cc=brauner@kernel.org \
    --cc=cmllamas@google.com \
    --cc=joel@joelfernandes.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=maco@android.com \
    --cc=surenb@google.com \
    --cc=tkjos@android.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox