* [PATCH v4] binder: modify the comment for binder_proc_unlock
@ 2024-09-02 3:37 Ba Jing
2024-09-03 10:02 ` Greg KH
0 siblings, 1 reply; 2+ messages in thread
From: Ba Jing @ 2024-09-02 3:37 UTC (permalink / raw)
To: gregkh
Cc: arve, tkjos, maco, joel, brauner, cmllamas, surenb, linux-kernel,
Ba Jing
Modify the comment for binder_proc_unlock() to clearly indicate which spinlock it releases and to better match the acquire comment block in binder_proc_lock().
Notes:
v1: https://lore.kernel.org/all/20240830073743.2052-1-bajing@cmss.chinamobile.com/
v2: Reword commit log per suggestions from cmllamas@
https://lore.kernel.org/all/20240902013636.1739-1-bajing@cmss.chinamobile.com/
v3: Wrap commit message. Add version history.
https://lore.kernel.org/all/20240902025720.2334-1-bajing@cmss.chinamobile.com/
v4: Modify the commit information.
Signed-off-by: Ba Jing <bajing@cmss.chinamobile.com>
---
drivers/android/binder.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/android/binder.c b/drivers/android/binder.c
index fc55b5d0e4f3..578861d57045 100644
--- a/drivers/android/binder.c
+++ b/drivers/android/binder.c
@@ -277,7 +277,7 @@ _binder_proc_lock(struct binder_proc *proc, int line)
}
/**
- * binder_proc_unlock() - Release spinlock for given binder_proc
+ * binder_proc_unlock() - Release outer lock for given binder_proc
* @proc: struct binder_proc to acquire
*
* Release lock acquired via binder_proc_lock()
--
2.33.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH v4] binder: modify the comment for binder_proc_unlock
2024-09-02 3:37 [PATCH v4] binder: modify the comment for binder_proc_unlock Ba Jing
@ 2024-09-03 10:02 ` Greg KH
0 siblings, 0 replies; 2+ messages in thread
From: Greg KH @ 2024-09-03 10:02 UTC (permalink / raw)
To: Ba Jing; +Cc: arve, tkjos, maco, joel, brauner, cmllamas, surenb, linux-kernel
On Mon, Sep 02, 2024 at 11:37:54AM +0800, Ba Jing wrote:
> Modify the comment for binder_proc_unlock() to clearly indicate which spinlock it releases and to better match the acquire comment block in binder_proc_lock().
>
> Notes:
> v1: https://lore.kernel.org/all/20240830073743.2052-1-bajing@cmss.chinamobile.com/
>
> v2: Reword commit log per suggestions from cmllamas@
> https://lore.kernel.org/all/20240902013636.1739-1-bajing@cmss.chinamobile.com/
>
> v3: Wrap commit message. Add version history.
> https://lore.kernel.org/all/20240902025720.2334-1-bajing@cmss.chinamobile.com/
>
> v4: Modify the commit information.
Again, all of these "what changed in what version" needs to go below the
--- line.
Also, please wrap your changelog text at 72 columns, like your editor
asked you to :)
thanks,
greg k-h
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2024-09-03 10:34 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-09-02 3:37 [PATCH v4] binder: modify the comment for binder_proc_unlock Ba Jing
2024-09-03 10:02 ` Greg KH
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox