* [PATCH v1 1/2] uio: uio_dmem_genirq: Make use of irq_get_trigger_type()
2024-09-12 23:59 [PATCH v1 0/2] Use functionality of irq_get_trigger_type() Vasileios Amoiridis
@ 2024-09-12 23:59 ` Vasileios Amoiridis
2024-09-13 9:40 ` Andy Shevchenko
2024-09-12 23:59 ` [PATCH v1 2/2] uio: uio_pdrv_genirq: " Vasileios Amoiridis
2024-09-13 9:44 ` [PATCH v1 0/2] Use functionality " Andy Shevchenko
2 siblings, 1 reply; 6+ messages in thread
From: Vasileios Amoiridis @ 2024-09-12 23:59 UTC (permalink / raw)
To: gregkh; +Cc: linux-kernel, andriy.shevchenko, Vasileios Amoiridis
Convert the following case:
struct irq_data *irq_data = irq_get_irq_data(irq);
if (irq_data && irqd_get_trigger_type(irq_data) ... ) {
...
}
to the simpler:
if (irq_get_trigger_type(irq) ... ) {
...
}
by using the irq_get_trigger_type() function.
Suggested-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Signed-off-by: Vasileios Amoiridis <vassilisamir@gmail.com>
---
drivers/uio/uio_dmem_genirq.c | 5 +----
1 file changed, 1 insertion(+), 4 deletions(-)
diff --git a/drivers/uio/uio_dmem_genirq.c b/drivers/uio/uio_dmem_genirq.c
index 13cc35ab5d29..c70dd81bfc61 100644
--- a/drivers/uio/uio_dmem_genirq.c
+++ b/drivers/uio/uio_dmem_genirq.c
@@ -210,8 +210,6 @@ static int uio_dmem_genirq_probe(struct platform_device *pdev)
}
if (uioinfo->irq) {
- struct irq_data *irq_data = irq_get_irq_data(uioinfo->irq);
-
/*
* If a level interrupt, dont do lazy disable. Otherwise the
* irq will fire again since clearing of the actual cause, on
@@ -219,8 +217,7 @@ static int uio_dmem_genirq_probe(struct platform_device *pdev)
* irqd_is_level_type() isn't used since isn't valid until
* irq is configured.
*/
- if (irq_data &&
- irqd_get_trigger_type(irq_data) & IRQ_TYPE_LEVEL_MASK) {
+ if (irq_get_trigger_type(uioinfo->irq) & IRQ_TYPE_LEVEL_MASK) {
dev_dbg(&pdev->dev, "disable lazy unmask\n");
irq_set_status_flags(uioinfo->irq, IRQ_DISABLE_UNLAZY);
}
base-commit: 57f962b956f1d116cd64d5c406776c4975de549d
--
2.25.1
^ permalink raw reply related [flat|nested] 6+ messages in thread* Re: [PATCH v1 1/2] uio: uio_dmem_genirq: Make use of irq_get_trigger_type()
2024-09-12 23:59 ` [PATCH v1 1/2] uio: uio_dmem_genirq: Make use " Vasileios Amoiridis
@ 2024-09-13 9:40 ` Andy Shevchenko
2024-09-13 23:55 ` Vasileios Amoiridis
0 siblings, 1 reply; 6+ messages in thread
From: Andy Shevchenko @ 2024-09-13 9:40 UTC (permalink / raw)
To: Vasileios Amoiridis; +Cc: gregkh, linux-kernel
On Fri, Sep 13, 2024 at 01:59:24AM +0200, Vasileios Amoiridis wrote:
> Convert the following case:
>
> struct irq_data *irq_data = irq_get_irq_data(irq);
>
> if (irq_data && irqd_get_trigger_type(irq_data) ... ) {
> ...
> }
>
> to the simpler:
>
> if (irq_get_trigger_type(irq) ... ) {
> ...
> }
>
> by using the irq_get_trigger_type() function.
Btw, can you add a coccinelle ruleset for this?
--
With Best Regards,
Andy Shevchenko
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH v1 1/2] uio: uio_dmem_genirq: Make use of irq_get_trigger_type()
2024-09-13 9:40 ` Andy Shevchenko
@ 2024-09-13 23:55 ` Vasileios Amoiridis
0 siblings, 0 replies; 6+ messages in thread
From: Vasileios Amoiridis @ 2024-09-13 23:55 UTC (permalink / raw)
To: Andy Shevchenko; +Cc: Vasileios Amoiridis, gregkh, linux-kernel
On Fri, Sep 13, 2024 at 12:40:09PM +0300, Andy Shevchenko wrote:
> On Fri, Sep 13, 2024 at 01:59:24AM +0200, Vasileios Amoiridis wrote:
> > Convert the following case:
> >
> > struct irq_data *irq_data = irq_get_irq_data(irq);
> >
> > if (irq_data && irqd_get_trigger_type(irq_data) ... ) {
> > ...
> > }
> >
> > to the simpler:
> >
> > if (irq_get_trigger_type(irq) ... ) {
> > ...
> > }
> >
> > by using the irq_get_trigger_type() function.
>
> Btw, can you add a coccinelle ruleset for this?
>
> --
> With Best Regards,
> Andy Shevchenko
>
>
Hi Andy!
Thanks for the time for the review! Yes, I would like to try it.
Cheers,
Vasilis
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH v1 2/2] uio: uio_pdrv_genirq: Make use of irq_get_trigger_type()
2024-09-12 23:59 [PATCH v1 0/2] Use functionality of irq_get_trigger_type() Vasileios Amoiridis
2024-09-12 23:59 ` [PATCH v1 1/2] uio: uio_dmem_genirq: Make use " Vasileios Amoiridis
@ 2024-09-12 23:59 ` Vasileios Amoiridis
2024-09-13 9:44 ` [PATCH v1 0/2] Use functionality " Andy Shevchenko
2 siblings, 0 replies; 6+ messages in thread
From: Vasileios Amoiridis @ 2024-09-12 23:59 UTC (permalink / raw)
To: gregkh; +Cc: linux-kernel, andriy.shevchenko, Vasileios Amoiridis
Convert the following case:
struct irq_data *irq_data = irq_get_irq_data(irq);
if (irq_data && irqd_get_trigger_type(irq_data) ... ) {
...
}
to the simpler:
if (irq_get_trigger_type(irq) ... ) {
...
}
by using the irq_get_trigger_type() function.
Suggested-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Signed-off-by: Vasileios Amoiridis <vassilisamir@gmail.com>
---
drivers/uio/uio_pdrv_genirq.c | 5 +----
1 file changed, 1 insertion(+), 4 deletions(-)
diff --git a/drivers/uio/uio_pdrv_genirq.c b/drivers/uio/uio_pdrv_genirq.c
index 796f5be0a086..2ec7d25e8264 100644
--- a/drivers/uio/uio_pdrv_genirq.c
+++ b/drivers/uio/uio_pdrv_genirq.c
@@ -173,8 +173,6 @@ static int uio_pdrv_genirq_probe(struct platform_device *pdev)
}
if (uioinfo->irq) {
- struct irq_data *irq_data = irq_get_irq_data(uioinfo->irq);
-
/*
* If a level interrupt, dont do lazy disable. Otherwise the
* irq will fire again since clearing of the actual cause, on
@@ -182,8 +180,7 @@ static int uio_pdrv_genirq_probe(struct platform_device *pdev)
* irqd_is_level_type() isn't used since isn't valid until
* irq is configured.
*/
- if (irq_data &&
- irqd_get_trigger_type(irq_data) & IRQ_TYPE_LEVEL_MASK) {
+ if (irq_get_trigger_type(uioinfo->irq) & IRQ_TYPE_LEVEL_MASK) {
dev_dbg(&pdev->dev, "disable lazy unmask\n");
irq_set_status_flags(uioinfo->irq, IRQ_DISABLE_UNLAZY);
}
--
2.25.1
^ permalink raw reply related [flat|nested] 6+ messages in thread* Re: [PATCH v1 0/2] Use functionality of irq_get_trigger_type()
2024-09-12 23:59 [PATCH v1 0/2] Use functionality of irq_get_trigger_type() Vasileios Amoiridis
2024-09-12 23:59 ` [PATCH v1 1/2] uio: uio_dmem_genirq: Make use " Vasileios Amoiridis
2024-09-12 23:59 ` [PATCH v1 2/2] uio: uio_pdrv_genirq: " Vasileios Amoiridis
@ 2024-09-13 9:44 ` Andy Shevchenko
2 siblings, 0 replies; 6+ messages in thread
From: Andy Shevchenko @ 2024-09-13 9:44 UTC (permalink / raw)
To: Vasileios Amoiridis; +Cc: gregkh, linux-kernel
On Fri, Sep 13, 2024 at 01:59:23AM +0200, Vasileios Amoiridis wrote:
> Use the irq_get_trigger_type() function which internally calls the
> irq_get_trigger_data(), to remove check and remove the irqd_get_trigger_type().
>
> The series is compile tested.
LGTM, FWIW,
Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
--
With Best Regards,
Andy Shevchenko
^ permalink raw reply [flat|nested] 6+ messages in thread