[PATCH] drm/amd/display: Remove unused function bios_get_vga_enabled_displays

[PATCH] drm/amd/display: Remove unused function bios_get_vga_enabled_displays

[linux]

From: "Dr. David Alan Gilbert" <linux@treblig.org>

bios_get_vga_enabled_displays has been unused since
  commit 5a8132b9f606 ("drm/amd/display: remove dead dc vbios code")

Remove it.

Signed-off-by: Dr. David Alan Gilbert <linux@treblig.org>
---
 drivers/gpu/drm/amd/display/dc/bios/bios_parser_helper.c | 7 -------
 drivers/gpu/drm/amd/display/dc/bios/bios_parser_helper.h | 1 -
 2 files changed, 8 deletions(-)

diff --git a/drivers/gpu/drm/amd/display/dc/bios/bios_parser_helper.c b/drivers/gpu/drm/amd/display/dc/bios/bios_parser_helper.c
index adc710fe4a45..8d2cf95ae739 100644
--- a/drivers/gpu/drm/amd/display/dc/bios/bios_parser_helper.c
+++ b/drivers/gpu/drm/amd/display/dc/bios/bios_parser_helper.c
@@ -78,10 +78,3 @@ void bios_set_scratch_critical_state(
 	uint32_t critial_state = state ? 1 : 0;
 	REG_UPDATE(BIOS_SCRATCH_6, S6_CRITICAL_STATE, critial_state);
 }
-
-uint32_t bios_get_vga_enabled_displays(
-	struct dc_bios *bios)
-{
-	return REG_READ(BIOS_SCRATCH_3) & 0XFFFF;
-}
-
diff --git a/drivers/gpu/drm/amd/display/dc/bios/bios_parser_helper.h b/drivers/gpu/drm/amd/display/dc/bios/bios_parser_helper.h
index e1b4a40a353d..ab162f2fe577 100644
--- a/drivers/gpu/drm/amd/display/dc/bios/bios_parser_helper.h
+++ b/drivers/gpu/drm/amd/display/dc/bios/bios_parser_helper.h
@@ -34,7 +34,6 @@ uint8_t *bios_get_image(struct dc_bios *bp, uint32_t offset,
 bool bios_is_accelerated_mode(struct dc_bios *bios);
 void bios_set_scratch_acc_mode_change(struct dc_bios *bios, uint32_t state);
 void bios_set_scratch_critical_state(struct dc_bios *bios, bool state);
-uint32_t bios_get_vga_enabled_displays(struct dc_bios *bios);
 
 #define GET_IMAGE(type, offset) ((type *) bios_get_image(&bp->base, offset, sizeof(type)))
 
-- 
2.46.0

Re: [PATCH] drm/amd/display: Remove unused function bios_get_vga_enabled_displays

[Alex Deucher]

Acked-by: Alex Deucher <alexander.deucher@amd.com>

And applied.

Thanks!

On Sun, Sep 15, 2024 at 10:19 AM <linux@treblig.org> wrote:
>
> From: "Dr. David Alan Gilbert" <linux@treblig.org>
>
> bios_get_vga_enabled_displays has been unused since
>   commit 5a8132b9f606 ("drm/amd/display: remove dead dc vbios code")
>
> Remove it.
>
> Signed-off-by: Dr. David Alan Gilbert <linux@treblig.org>
> ---
>  drivers/gpu/drm/amd/display/dc/bios/bios_parser_helper.c | 7 -------
>  drivers/gpu/drm/amd/display/dc/bios/bios_parser_helper.h | 1 -
>  2 files changed, 8 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/display/dc/bios/bios_parser_helper.c b/drivers/gpu/drm/amd/display/dc/bios/bios_parser_helper.c
> index adc710fe4a45..8d2cf95ae739 100644
> --- a/drivers/gpu/drm/amd/display/dc/bios/bios_parser_helper.c
> +++ b/drivers/gpu/drm/amd/display/dc/bios/bios_parser_helper.c
> @@ -78,10 +78,3 @@ void bios_set_scratch_critical_state(
>         uint32_t critial_state = state ? 1 : 0;
>         REG_UPDATE(BIOS_SCRATCH_6, S6_CRITICAL_STATE, critial_state);
>  }
> -
> -uint32_t bios_get_vga_enabled_displays(
> -       struct dc_bios *bios)
> -{
> -       return REG_READ(BIOS_SCRATCH_3) & 0XFFFF;
> -}
> -
> diff --git a/drivers/gpu/drm/amd/display/dc/bios/bios_parser_helper.h b/drivers/gpu/drm/amd/display/dc/bios/bios_parser_helper.h
> index e1b4a40a353d..ab162f2fe577 100644
> --- a/drivers/gpu/drm/amd/display/dc/bios/bios_parser_helper.h
> +++ b/drivers/gpu/drm/amd/display/dc/bios/bios_parser_helper.h
> @@ -34,7 +34,6 @@ uint8_t *bios_get_image(struct dc_bios *bp, uint32_t offset,
>  bool bios_is_accelerated_mode(struct dc_bios *bios);
>  void bios_set_scratch_acc_mode_change(struct dc_bios *bios, uint32_t state);
>  void bios_set_scratch_critical_state(struct dc_bios *bios, bool state);
> -uint32_t bios_get_vga_enabled_displays(struct dc_bios *bios);
>
>  #define GET_IMAGE(type, offset) ((type *) bios_get_image(&bp->base, offset, sizeof(type)))
>
> --
> 2.46.0
>