From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Andi Shyti <andi.shyti@kernel.org>,
Wolfram Sang <wsa+renesas@sang-engineering.com>,
linux-i2c@vger.kernel.org, linux-kernel@vger.kernel.org
Cc: Jean Delvare <jdelvare@suse.com>,
Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Subject: [PATCH v2 10/11] i2c: isch: Prefer to use octal permission
Date: Mon, 16 Sep 2024 15:01:37 +0300 [thread overview]
Message-ID: <20240916120237.1385982-11-andriy.shevchenko@linux.intel.com> (raw)
In-Reply-To: <20240916120237.1385982-1-andriy.shevchenko@linux.intel.com>
Octal permissions are preferred over the symbolics ones
for readbility. This ceases warning message pointed by checkpatch.
Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
---
drivers/i2c/busses/i2c-isch.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/i2c/busses/i2c-isch.c b/drivers/i2c/busses/i2c-isch.c
index 1a18a276a857..b2857e8e1c58 100644
--- a/drivers/i2c/busses/i2c-isch.c
+++ b/drivers/i2c/busses/i2c-isch.c
@@ -49,7 +49,7 @@ struct sch_i2c {
};
static int backbone_speed = 33000; /* backbone speed in kHz */
-module_param(backbone_speed, int, S_IRUSR | S_IWUSR);
+module_param(backbone_speed, int, 0600);
MODULE_PARM_DESC(backbone_speed, "Backbone speed in kHz, (default = 33000)");
static inline u8 sch_io_rd8(struct sch_i2c *priv, unsigned int offset)
--
2.43.0.rc1.1336.g36b5255a03ac
next prev parent reply other threads:[~2024-09-16 12:02 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-16 12:01 [PATCH v2 00/11] i2c: isch: Put the driver into shape Andy Shevchenko
2024-09-16 12:01 ` [PATCH v2 01/11] i2c: isch: Pass pointer to struct i2c_adapter down Andy Shevchenko
2024-09-16 12:01 ` [PATCH v2 02/11] i2c: isch: Use string_choices API instead of ternary operator Andy Shevchenko
2024-09-16 12:01 ` [PATCH v2 03/11] i2c: isch: Switch to memory mapped IO accessors Andy Shevchenko
2024-09-16 12:01 ` [PATCH v2 04/11] i2c: isch: Use custom private data structure Andy Shevchenko
2024-09-16 12:01 ` [PATCH v2 05/11] i2c: isch: switch i2c registration to devm functions Andy Shevchenko
2024-09-16 12:01 ` [PATCH v2 06/11] i2c: isch: Utilize temporary variable to hold device pointer Andy Shevchenko
2024-09-16 12:01 ` [PATCH v2 07/11] i2c: isch: Use read_poll_timeout() Andy Shevchenko
2024-09-16 12:01 ` [PATCH v2 08/11] i2c: isch: Unify the name of the variable to hold an error code Andy Shevchenko
2024-09-16 12:01 ` [PATCH v2 09/11] i2c: isch: Don't use "proxy" headers Andy Shevchenko
2024-09-16 12:01 ` Andy Shevchenko [this message]
2024-09-16 12:01 ` [PATCH v2 11/11] i2c: isch: Convert to kernel-doc Andy Shevchenko
2024-09-16 14:40 ` [PATCH v2 00/11] i2c: isch: Put the driver into shape Andi Shyti
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240916120237.1385982-11-andriy.shevchenko@linux.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=andi.shyti@kernel.org \
--cc=jdelvare@suse.com \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=wsa+renesas@sang-engineering.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox