public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Andi Shyti <andi.shyti@kernel.org>,
	Wolfram Sang <wsa+renesas@sang-engineering.com>,
	linux-i2c@vger.kernel.org, linux-kernel@vger.kernel.org
Cc: Jean Delvare <jdelvare@suse.com>,
	Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Subject: [PATCH v2 05/11] i2c: isch: switch i2c registration to devm functions
Date: Mon, 16 Sep 2024 15:01:32 +0300	[thread overview]
Message-ID: <20240916120237.1385982-6-andriy.shevchenko@linux.intel.com> (raw)
In-Reply-To: <20240916120237.1385982-1-andriy.shevchenko@linux.intel.com>

Switch from i2c_add_adapter() to resource managed devm_i2c_add_adapter()
for matching rest of driver initialization, and more concise code.

Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
---
 drivers/i2c/busses/i2c-isch.c | 17 +----------------
 1 file changed, 1 insertion(+), 16 deletions(-)

diff --git a/drivers/i2c/busses/i2c-isch.c b/drivers/i2c/busses/i2c-isch.c
index 0fe7c9d1dd0d..d752f822b52e 100644
--- a/drivers/i2c/busses/i2c-isch.c
+++ b/drivers/i2c/busses/i2c-isch.c
@@ -274,7 +274,6 @@ static int smbus_sch_probe(struct platform_device *dev)
 {
 	struct sch_i2c *priv;
 	struct resource *res;
-	int retval;
 
 	priv = devm_kzalloc(&dev->dev, sizeof(*priv), GFP_KERNEL);
 	if (!priv)
@@ -299,20 +298,7 @@ static int smbus_sch_probe(struct platform_device *dev)
 	snprintf(priv->adapter.name, sizeof(priv->adapter.name),
 		 "SMBus SCH adapter at %04x", (unsigned short)res->start);
 
-	retval = i2c_add_adapter(&priv->adapter);
-	if (retval)
-		return retval;
-
-	platform_set_drvdata(dev, priv);
-
-	return 0;
-}
-
-static void smbus_sch_remove(struct platform_device *pdev)
-{
-	struct sch_i2c *priv = platform_get_drvdata(pdev);
-
-	i2c_del_adapter(&priv->adapter);
+	return devm_i2c_add_adapter(&dev->dev, &priv->adapter);
 }
 
 static struct platform_driver smbus_sch_driver = {
@@ -320,7 +306,6 @@ static struct platform_driver smbus_sch_driver = {
 		.name = "isch_smbus",
 	},
 	.probe		= smbus_sch_probe,
-	.remove_new	= smbus_sch_remove,
 };
 
 module_platform_driver(smbus_sch_driver);
-- 
2.43.0.rc1.1336.g36b5255a03ac


  parent reply	other threads:[~2024-09-16 12:02 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-09-16 12:01 [PATCH v2 00/11] i2c: isch: Put the driver into shape Andy Shevchenko
2024-09-16 12:01 ` [PATCH v2 01/11] i2c: isch: Pass pointer to struct i2c_adapter down Andy Shevchenko
2024-09-16 12:01 ` [PATCH v2 02/11] i2c: isch: Use string_choices API instead of ternary operator Andy Shevchenko
2024-09-16 12:01 ` [PATCH v2 03/11] i2c: isch: Switch to memory mapped IO accessors Andy Shevchenko
2024-09-16 12:01 ` [PATCH v2 04/11] i2c: isch: Use custom private data structure Andy Shevchenko
2024-09-16 12:01 ` Andy Shevchenko [this message]
2024-09-16 12:01 ` [PATCH v2 06/11] i2c: isch: Utilize temporary variable to hold device pointer Andy Shevchenko
2024-09-16 12:01 ` [PATCH v2 07/11] i2c: isch: Use read_poll_timeout() Andy Shevchenko
2024-09-16 12:01 ` [PATCH v2 08/11] i2c: isch: Unify the name of the variable to hold an error code Andy Shevchenko
2024-09-16 12:01 ` [PATCH v2 09/11] i2c: isch: Don't use "proxy" headers Andy Shevchenko
2024-09-16 12:01 ` [PATCH v2 10/11] i2c: isch: Prefer to use octal permission Andy Shevchenko
2024-09-16 12:01 ` [PATCH v2 11/11] i2c: isch: Convert to kernel-doc Andy Shevchenko
2024-09-16 14:40 ` [PATCH v2 00/11] i2c: isch: Put the driver into shape Andi Shyti

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240916120237.1385982-6-andriy.shevchenko@linux.intel.com \
    --to=andriy.shevchenko@linux.intel.com \
    --cc=andi.shyti@kernel.org \
    --cc=jdelvare@suse.com \
    --cc=linux-i2c@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=wsa+renesas@sang-engineering.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox