* [PATCH v2] iommu/arm-smmu-v3: Convert comma to semicolon
@ 2024-09-23 2:15 Chen Ni
2024-09-23 13:36 ` Jason Gunthorpe
2024-10-08 18:24 ` Will Deacon
0 siblings, 2 replies; 3+ messages in thread
From: Chen Ni @ 2024-09-23 2:15 UTC (permalink / raw)
To: will, robin.murphy, joro, jgg, nicolinc, mshavit, smostafa,
baolu.lu
Cc: linux-arm-kernel, iommu, linux-kernel, Chen Ni
Replace comma between expressions with semicolons.
Using a ',' in place of a ';' can have unintended side effects.
Although that is not the case here, it is seems best to use ';'
unless ',' is intended.
Found by inspection.
No functional change intended.
Compile tested only.
Fixes: e3b1be2e73db ("iommu/arm-smmu-v3: Reorganize struct arm_smmu_ctx_desc_cfg")
Signed-off-by: Chen Ni <nichen@iscas.ac.cn>
---
Changelog:
v1 -> v2:
1. Add Fixes tag.
---
drivers/iommu/arm/arm-smmu-v3/arm-smmu-v3.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/iommu/arm/arm-smmu-v3/arm-smmu-v3.c b/drivers/iommu/arm/arm-smmu-v3/arm-smmu-v3.c
index 737c5b882355..4815c5198642 100644
--- a/drivers/iommu/arm/arm-smmu-v3/arm-smmu-v3.c
+++ b/drivers/iommu/arm/arm-smmu-v3/arm-smmu-v3.c
@@ -1420,7 +1420,7 @@ static int arm_smmu_alloc_cd_tables(struct arm_smmu_master *master)
cd_table->s1fmt = STRTAB_STE_0_S1FMT_LINEAR;
cd_table->linear.num_ents = max_contexts;
- l1size = max_contexts * sizeof(struct arm_smmu_cd),
+ l1size = max_contexts * sizeof(struct arm_smmu_cd);
cd_table->linear.table = dma_alloc_coherent(smmu->dev, l1size,
&cd_table->cdtab_dma,
GFP_KERNEL);
--
2.25.1
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH v2] iommu/arm-smmu-v3: Convert comma to semicolon
2024-09-23 2:15 [PATCH v2] iommu/arm-smmu-v3: Convert comma to semicolon Chen Ni
@ 2024-09-23 13:36 ` Jason Gunthorpe
2024-10-08 18:24 ` Will Deacon
1 sibling, 0 replies; 3+ messages in thread
From: Jason Gunthorpe @ 2024-09-23 13:36 UTC (permalink / raw)
To: Chen Ni
Cc: will, robin.murphy, joro, nicolinc, mshavit, smostafa, baolu.lu,
linux-arm-kernel, iommu, linux-kernel
On Mon, Sep 23, 2024 at 10:15:57AM +0800, Chen Ni wrote:
> Replace comma between expressions with semicolons.
>
> Using a ',' in place of a ';' can have unintended side effects.
> Although that is not the case here, it is seems best to use ';'
> unless ',' is intended.
>
> Found by inspection.
> No functional change intended.
> Compile tested only.
>
> Fixes: e3b1be2e73db ("iommu/arm-smmu-v3: Reorganize struct arm_smmu_ctx_desc_cfg")
> Signed-off-by: Chen Ni <nichen@iscas.ac.cn>
> ---
> Changelog:
>
> v1 -> v2:
Reviewed-by: Jason Gunthorpe <jgg@nvidia.com>
Jason
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH v2] iommu/arm-smmu-v3: Convert comma to semicolon
2024-09-23 2:15 [PATCH v2] iommu/arm-smmu-v3: Convert comma to semicolon Chen Ni
2024-09-23 13:36 ` Jason Gunthorpe
@ 2024-10-08 18:24 ` Will Deacon
1 sibling, 0 replies; 3+ messages in thread
From: Will Deacon @ 2024-10-08 18:24 UTC (permalink / raw)
To: robin.murphy, joro, jgg, nicolinc, mshavit, smostafa, baolu.lu,
Chen Ni
Cc: catalin.marinas, kernel-team, Will Deacon, linux-arm-kernel,
iommu, linux-kernel
On Mon, 23 Sep 2024 10:15:57 +0800, Chen Ni wrote:
> Replace comma between expressions with semicolons.
>
> Using a ',' in place of a ';' can have unintended side effects.
> Although that is not the case here, it is seems best to use ';'
> unless ',' is intended.
>
> Found by inspection.
> No functional change intended.
> Compile tested only.
>
> [...]
Applied to will (for-joerg/arm-smmu/fixes), thanks!
[1/1] iommu/arm-smmu-v3: Convert comma to semicolon
https://git.kernel.org/will/c/7de7d35429aa
Cheers,
--
Will
https://fixes.arm64.dev
https://next.arm64.dev
https://will.arm64.dev
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2024-10-08 18:24 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-09-23 2:15 [PATCH v2] iommu/arm-smmu-v3: Convert comma to semicolon Chen Ni
2024-09-23 13:36 ` Jason Gunthorpe
2024-10-08 18:24 ` Will Deacon
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox