* [PATCH v1 1/1] drm/mediatek: dp: Add sdp path reset
@ 2024-09-23 13:35 Liankun Yang
2024-09-23 23:44 ` kernel test robot
2024-09-24 1:09 ` kernel test robot
0 siblings, 2 replies; 3+ messages in thread
From: Liankun Yang @ 2024-09-23 13:35 UTC (permalink / raw)
To: chunkuang.hu, p.zabel, airlied, simona, matthias.bgg,
angelogioacchino.delregno, jitao.shi, mac.shen, peng.liu,
liankun.yang
Cc: Project_Global_Chrome_Upstream_Group, dri-devel, linux-mediatek,
linux-kernel, linux-arm-kernel
When using type-c to type-c to connect to the monitor,
the sound plays normally. If you unplug the type-c and
connect the type-c to hdmi dongle to the monitor, there will be noise.
By capturing the audio data, it is found that
the data position is messy, and there is no error in the data.
Through experiments, it can be restored by resetting the SDP path
when unplugging it.
Signed-off-by: Liankun Yang <liankun.yang@mediatek.com>
---
drivers/gpu/drm/mediatek/mtk_dp.c | 15 +++++++++++++++
1 file changed, 15 insertions(+)
diff --git a/drivers/gpu/drm/mediatek/mtk_dp.c b/drivers/gpu/drm/mediatek/mtk_dp.c
index d8796a904eca..4003bd83f64e 100644
--- a/drivers/gpu/drm/mediatek/mtk_dp.c
+++ b/drivers/gpu/drm/mediatek/mtk_dp.c
@@ -1052,6 +1052,18 @@ static void mtk_dp_digital_sw_reset(struct mtk_dp *mtk_dp)
0, DP_TX_TRANSMITTER_4P_RESET_SW_DP_TRANS_P0);
}
+static void mtk_dp_sdp_path_reset(struct mtk_dp *mtk_dp)
+{
+ mtk_dp_update_bits(mtk_dp, MTK_DP_ENC0_P0_3004,
+ SDP_RESET_SW_DP_ENC0_P0,
+ SDP_RESET_SW_DP_ENC0_P0);
+
+ /* Wait for sdp path reset to complete */
+ usleep_range(1000, 5000);
+ mtk_dp_update_bits(mtk_dp, MTK_DP_ENC0_P0_3004,
+ 0, SDP_RESET_SW_DP_ENC0_P0);
+}
+
static void mtk_dp_set_lanes(struct mtk_dp *mtk_dp, int lanes)
{
mtk_dp_update_bits(mtk_dp, MTK_DP_TRANS_P0_35F0,
@@ -2314,6 +2326,9 @@ static void mtk_dp_bridge_atomic_disable(struct drm_bridge *bridge,
DP_PWR_STATE_BANDGAP_TPLL,
DP_PWR_STATE_MASK);
+ /* SDP path reset sw*/
+ mtk_dp_sdp_path_reset(mtk_dp);
+
/* Ensure the sink is muted */
msleep(20);
}
--
2.45.2
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH v1 1/1] drm/mediatek: dp: Add sdp path reset
2024-09-23 13:35 [PATCH v1 1/1] drm/mediatek: dp: Add sdp path reset Liankun Yang
@ 2024-09-23 23:44 ` kernel test robot
2024-09-24 1:09 ` kernel test robot
1 sibling, 0 replies; 3+ messages in thread
From: kernel test robot @ 2024-09-23 23:44 UTC (permalink / raw)
To: Liankun Yang, chunkuang.hu, p.zabel, airlied, simona,
matthias.bgg, angelogioacchino.delregno, jitao.shi, mac.shen,
peng.liu
Cc: oe-kbuild-all, Project_Global_Chrome_Upstream_Group, dri-devel,
linux-mediatek, linux-kernel, linux-arm-kernel
Hi Liankun,
kernel test robot noticed the following build errors:
[auto build test ERROR on pza/reset/next]
[also build test ERROR on linus/master v6.11 next-20240923]
[cannot apply to pza/imx-drm/next]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]
url: https://github.com/intel-lab-lkp/linux/commits/Liankun-Yang/drm-mediatek-dp-Add-sdp-path-reset/20240923-213747
base: https://git.pengutronix.de/git/pza/linux reset/next
patch link: https://lore.kernel.org/r/20240923133610.23728-1-liankun.yang%40mediatek.com
patch subject: [PATCH v1 1/1] drm/mediatek: dp: Add sdp path reset
config: arm-allmodconfig (https://download.01.org/0day-ci/archive/20240924/202409240700.ARp9pDUk-lkp@intel.com/config)
compiler: arm-linux-gnueabi-gcc (GCC) 14.1.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20240924/202409240700.ARp9pDUk-lkp@intel.com/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202409240700.ARp9pDUk-lkp@intel.com/
All errors (new ones prefixed by >>):
drivers/gpu/drm/mediatek/mtk_dp.c: In function 'mtk_dp_sdp_path_reset':
>> drivers/gpu/drm/mediatek/mtk_dp.c:1058:33: error: 'SDP_RESET_SW_DP_ENC0_P0' undeclared (first use in this function); did you mean 'SDP_PACKET_W_DP_ENC1_P0'?
1058 | SDP_RESET_SW_DP_ENC0_P0,
| ^~~~~~~~~~~~~~~~~~~~~~~
| SDP_PACKET_W_DP_ENC1_P0
drivers/gpu/drm/mediatek/mtk_dp.c:1058:33: note: each undeclared identifier is reported only once for each function it appears in
vim +1058 drivers/gpu/drm/mediatek/mtk_dp.c
1054
1055 static void mtk_dp_sdp_path_reset(struct mtk_dp *mtk_dp)
1056 {
1057 mtk_dp_update_bits(mtk_dp, MTK_DP_ENC0_P0_3004,
> 1058 SDP_RESET_SW_DP_ENC0_P0,
1059 SDP_RESET_SW_DP_ENC0_P0);
1060
1061 /* Wait for sdp path reset to complete */
1062 usleep_range(1000, 5000);
1063 mtk_dp_update_bits(mtk_dp, MTK_DP_ENC0_P0_3004,
1064 0, SDP_RESET_SW_DP_ENC0_P0);
1065 }
1066
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH v1 1/1] drm/mediatek: dp: Add sdp path reset
2024-09-23 13:35 [PATCH v1 1/1] drm/mediatek: dp: Add sdp path reset Liankun Yang
2024-09-23 23:44 ` kernel test robot
@ 2024-09-24 1:09 ` kernel test robot
1 sibling, 0 replies; 3+ messages in thread
From: kernel test robot @ 2024-09-24 1:09 UTC (permalink / raw)
To: Liankun Yang, chunkuang.hu, p.zabel, airlied, simona,
matthias.bgg, angelogioacchino.delregno, jitao.shi, mac.shen,
peng.liu
Cc: llvm, oe-kbuild-all, Project_Global_Chrome_Upstream_Group,
dri-devel, linux-mediatek, linux-kernel, linux-arm-kernel
Hi Liankun,
kernel test robot noticed the following build errors:
[auto build test ERROR on pza/reset/next]
[also build test ERROR on linus/master v6.11 next-20240923]
[cannot apply to pza/imx-drm/next]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]
url: https://github.com/intel-lab-lkp/linux/commits/Liankun-Yang/drm-mediatek-dp-Add-sdp-path-reset/20240923-213747
base: https://git.pengutronix.de/git/pza/linux reset/next
patch link: https://lore.kernel.org/r/20240923133610.23728-1-liankun.yang%40mediatek.com
patch subject: [PATCH v1 1/1] drm/mediatek: dp: Add sdp path reset
config: arm64-allmodconfig (https://download.01.org/0day-ci/archive/20240924/202409240818.3cqdkw5o-lkp@intel.com/config)
compiler: clang version 20.0.0git (https://github.com/llvm/llvm-project 8663a75fa2f31299ab8d1d90288d9df92aadee88)
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20240924/202409240818.3cqdkw5o-lkp@intel.com/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202409240818.3cqdkw5o-lkp@intel.com/
All errors (new ones prefixed by >>):
In file included from drivers/gpu/drm/mediatek/mtk_dp.c:9:
In file included from include/drm/display/drm_dp_helper.h:27:
In file included from include/linux/i2c.h:13:
In file included from include/linux/acpi.h:39:
In file included from include/acpi/acpi_io.h:7:
In file included from arch/arm64/include/asm/acpi.h:14:
In file included from include/linux/memblock.h:12:
In file included from include/linux/mm.h:2228:
include/linux/vmstat.h:503:43: warning: arithmetic between different enumeration types ('enum zone_stat_item' and 'enum numa_stat_item') [-Wenum-enum-conversion]
503 | return vmstat_text[NR_VM_ZONE_STAT_ITEMS +
| ~~~~~~~~~~~~~~~~~~~~~ ^
504 | item];
| ~~~~
include/linux/vmstat.h:510:43: warning: arithmetic between different enumeration types ('enum zone_stat_item' and 'enum numa_stat_item') [-Wenum-enum-conversion]
510 | return vmstat_text[NR_VM_ZONE_STAT_ITEMS +
| ~~~~~~~~~~~~~~~~~~~~~ ^
511 | NR_VM_NUMA_EVENT_ITEMS +
| ~~~~~~~~~~~~~~~~~~~~~~
include/linux/vmstat.h:517:36: warning: arithmetic between different enumeration types ('enum node_stat_item' and 'enum lru_list') [-Wenum-enum-conversion]
517 | return node_stat_name(NR_LRU_BASE + lru) + 3; // skip "nr_"
| ~~~~~~~~~~~ ^ ~~~
include/linux/vmstat.h:523:43: warning: arithmetic between different enumeration types ('enum zone_stat_item' and 'enum numa_stat_item') [-Wenum-enum-conversion]
523 | return vmstat_text[NR_VM_ZONE_STAT_ITEMS +
| ~~~~~~~~~~~~~~~~~~~~~ ^
524 | NR_VM_NUMA_EVENT_ITEMS +
| ~~~~~~~~~~~~~~~~~~~~~~
>> drivers/gpu/drm/mediatek/mtk_dp.c:1058:5: error: use of undeclared identifier 'SDP_RESET_SW_DP_ENC0_P0'
1058 | SDP_RESET_SW_DP_ENC0_P0,
| ^
drivers/gpu/drm/mediatek/mtk_dp.c:1059:5: error: use of undeclared identifier 'SDP_RESET_SW_DP_ENC0_P0'
1059 | SDP_RESET_SW_DP_ENC0_P0);
| ^
drivers/gpu/drm/mediatek/mtk_dp.c:1064:8: error: use of undeclared identifier 'SDP_RESET_SW_DP_ENC0_P0'
1064 | 0, SDP_RESET_SW_DP_ENC0_P0);
| ^
4 warnings and 3 errors generated.
vim +/SDP_RESET_SW_DP_ENC0_P0 +1058 drivers/gpu/drm/mediatek/mtk_dp.c
1054
1055 static void mtk_dp_sdp_path_reset(struct mtk_dp *mtk_dp)
1056 {
1057 mtk_dp_update_bits(mtk_dp, MTK_DP_ENC0_P0_3004,
> 1058 SDP_RESET_SW_DP_ENC0_P0,
1059 SDP_RESET_SW_DP_ENC0_P0);
1060
1061 /* Wait for sdp path reset to complete */
1062 usleep_range(1000, 5000);
1063 mtk_dp_update_bits(mtk_dp, MTK_DP_ENC0_P0_3004,
1064 0, SDP_RESET_SW_DP_ENC0_P0);
1065 }
1066
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2024-09-24 1:09 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-09-23 13:35 [PATCH v1 1/1] drm/mediatek: dp: Add sdp path reset Liankun Yang
2024-09-23 23:44 ` kernel test robot
2024-09-24 1:09 ` kernel test robot
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox