* Re: [PATCH] eeprom: fix cacography of switch
2024-09-21 10:36 [PATCH] eeprom: fix cacography of switch liujing
@ 2024-09-25 9:49 ` Greg KH
2024-09-25 10:51 ` Dr. David Alan Gilbert
1 sibling, 0 replies; 4+ messages in thread
From: Greg KH @ 2024-09-25 9:49 UTC (permalink / raw)
To: liujing; +Cc: arnd, W_Armin, hkallweit1, jdelvare, linux-kernel
On Sat, Sep 21, 2024 at 06:36:44PM +0800, liujing wrote:
> diff --git a/drivers/misc/eeprom/Kconfig b/drivers/misc/eeprom/Kconfig
> index 9df12399bda3..cb1c4b8e7fd3 100644
> --- a/drivers/misc/eeprom/Kconfig
> +++ b/drivers/misc/eeprom/Kconfig
> @@ -97,11 +97,11 @@ config EEPROM_DIGSY_MTC_CFG
> If unsure, say N.
>
> config EEPROM_IDT_89HPESX
> - tristate "IDT 89HPESx PCIe-swtiches EEPROM / CSR support"
> + tristate "IDT 89HPESx PCIe-switches EEPROM / CSR support"
> depends on I2C && SYSFS
> help
> Enable this driver to get read/write access to EEPROM / CSRs
> - over IDT PCIe-swtich i2c-slave interface.
> + over IDT PCIe-switch i2c-slave interface.
>
> This driver can also be built as a module. If so, the module
> will be called idt_89hpesx.
> --
> 2.27.0
>
>
>
Hi,
This is the friendly patch-bot of Greg Kroah-Hartman. You have sent him
a patch that has triggered this response. He used to manually respond
to these common problems, but in order to save his sanity (he kept
writing the same thing over and over, yet to different people), I was
created. Hopefully you will not take offence and will fix the problem
in your patch and resubmit it so that it can be accepted into the Linux
kernel tree.
You are receiving this message because of the following common error(s)
as indicated below:
- Your patch does not have a Signed-off-by: line. Please read the
kernel file, Documentation/process/submitting-patches.rst and resend
it after adding that line. Note, the line needs to be in the body of
the email, before the patch, not at the bottom of the patch or in the
email signature.
- You did not specify a description of why the patch is needed, or
possibly, any description at all, in the email body. Please read the
section entitled "The canonical patch format" in the kernel file,
Documentation/process/submitting-patches.rst for what is needed in
order to properly describe the change.
- You did not write a descriptive Subject: for the patch, allowing Greg,
and everyone else, to know what this patch is all about. Please read
the section entitled "The canonical patch format" in the kernel file,
Documentation/process/submitting-patches.rst for what a proper
Subject: line should look like.
- It looks like you did not use your "real" name for the patch on either
the Signed-off-by: line, or the From: line (both of which have to
match). Please read the kernel file,
Documentation/process/submitting-patches.rst for how to do this
correctly.
If you wish to discuss this problem further, or you have questions about
how to resolve this issue, please feel free to respond to this email and
Greg will reply once he has dug out from the pending patches received
from other developers.
thanks,
greg k-h's patch email bot
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] eeprom: fix cacography of switch
2024-09-21 10:36 [PATCH] eeprom: fix cacography of switch liujing
2024-09-25 9:49 ` Greg KH
@ 2024-09-25 10:51 ` Dr. David Alan Gilbert
2024-09-25 12:45 ` Jean Delvare
1 sibling, 1 reply; 4+ messages in thread
From: Dr. David Alan Gilbert @ 2024-09-25 10:51 UTC (permalink / raw)
To: liujing; +Cc: arnd, gregkh, W_Armin, hkallweit1, jdelvare, linux-kernel
* liujing (liujing@cmss.chinamobile.com) wrote:
As well as fixing the sign-off that Greg's script noticed,
I suggest changing 'cacography' to 'spelling'
'Cacography' is a rare word - I had to look it up!
Dave
> diff --git a/drivers/misc/eeprom/Kconfig b/drivers/misc/eeprom/Kconfig
> index 9df12399bda3..cb1c4b8e7fd3 100644
> --- a/drivers/misc/eeprom/Kconfig
> +++ b/drivers/misc/eeprom/Kconfig
> @@ -97,11 +97,11 @@ config EEPROM_DIGSY_MTC_CFG
> If unsure, say N.
>
> config EEPROM_IDT_89HPESX
> - tristate "IDT 89HPESx PCIe-swtiches EEPROM / CSR support"
> + tristate "IDT 89HPESx PCIe-switches EEPROM / CSR support"
> depends on I2C && SYSFS
> help
> Enable this driver to get read/write access to EEPROM / CSRs
> - over IDT PCIe-swtich i2c-slave interface.
> + over IDT PCIe-switch i2c-slave interface.
>
> This driver can also be built as a module. If so, the module
> will be called idt_89hpesx.
> --
> 2.27.0
>
>
>
>
--
-----Open up your eyes, open up your mind, open up your code -------
/ Dr. David Alan Gilbert | Running GNU/Linux | Happy \
\ dave @ treblig.org | | In Hex /
\ _________________________|_____ http://www.treblig.org |_______/
^ permalink raw reply [flat|nested] 4+ messages in thread